RE: [PATCH v2 1/3] mfd: add lp8788 mfd driver

2012-08-10 Thread Kim, Milo
> > Patch v2. > > (a) For interrupt handling, use generic irq rather than irq-domain > > This seems like a very substantial step backwards, why make this change? > Using irqdomain solves a bunch of problems, especially around virq > allocation, and is where we want all drivers to go longer term.

RE: [PATCH v2 1/3] mfd: add lp8788 mfd driver

2012-08-10 Thread Kim, Milo
Patch v2. (a) For interrupt handling, use generic irq rather than irq-domain This seems like a very substantial step backwards, why make this change? Using irqdomain solves a bunch of problems, especially around virq allocation, and is where we want all drivers to go longer term. Yes,

Re: [PATCH v2 1/3] mfd: add lp8788 mfd driver

2012-08-09 Thread Mark Brown
On Thu, Aug 09, 2012 at 08:22:38AM +, Kim, Milo wrote: > TI LP8788 PMU supports regulators, battery charger, RTC, > ADC, backlight driver and current sinks. > Patch v2. > (a) For interrupt handling, use generic irq rather than irq-domain This seems like a very substantial step backwards, why

[PATCH v2 1/3] mfd: add lp8788 mfd driver

2012-08-09 Thread Kim, Milo
TI LP8788 PMU supports regulators, battery charger, RTC, ADC, backlight driver and current sinks. Patch v2. (a) For interrupt handling, use generic irq rather than irq-domain (b) Replace EXPORT_SYMBOL() with EXPORT_SYMBOL_GPL() for regmap apis (c) Remove adc functions in mfd driver : add new

[PATCH v2 1/3] mfd: add lp8788 mfd driver

2012-08-09 Thread Kim, Milo
TI LP8788 PMU supports regulators, battery charger, RTC, ADC, backlight driver and current sinks. Patch v2. (a) For interrupt handling, use generic irq rather than irq-domain (b) Replace EXPORT_SYMBOL() with EXPORT_SYMBOL_GPL() for regmap apis (c) Remove adc functions in mfd driver : add new

Re: [PATCH v2 1/3] mfd: add lp8788 mfd driver

2012-08-09 Thread Mark Brown
On Thu, Aug 09, 2012 at 08:22:38AM +, Kim, Milo wrote: TI LP8788 PMU supports regulators, battery charger, RTC, ADC, backlight driver and current sinks. Patch v2. (a) For interrupt handling, use generic irq rather than irq-domain This seems like a very substantial step backwards, why