Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-24 Thread Frank Rowand
On 2020-06-24 11:14, Lee Jones wrote: > On Wed, 24 Jun 2020, Frank Rowand wrote: > >> On 2020-06-24 02:46, Lee Jones wrote: >>> On Tue, 23 Jun 2020, Frank Rowand wrote: >>> On 2020-06-23 14:59, Lee Jones wrote: >> >> < big snip > >> >> Thanks for the replies in the above portion. > > NP. >

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-24 Thread Lee Jones
On Wed, 24 Jun 2020, Frank Rowand wrote: > On 2020-06-24 02:46, Lee Jones wrote: > > On Tue, 23 Jun 2020, Frank Rowand wrote: > > > >> On 2020-06-23 14:59, Lee Jones wrote: > > < big snip > > > Thanks for the replies in the above portion. NP. > But yes or no to my solution #2 (with some

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-24 Thread Frank Rowand
On 2020-06-24 02:46, Lee Jones wrote: > On Tue, 23 Jun 2020, Frank Rowand wrote: > >> On 2020-06-23 14:59, Lee Jones wrote: < big snip > Thanks for the replies in the above portion. But yes or no to my solution #2 (with some slight changes to make it better (more gracious handling

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-24 Thread Lee Jones
On Wed, 24 Jun 2020, Michael Walle wrote: > Am 2020-06-24 10:23, schrieb Lee Jones: > > On Wed, 24 Jun 2020, Michael Walle wrote: > > [..] > > > > Although Rob mentioned to maybe relax that, but I sill fail to see > > > the advantage to have an arbitrary reg property instead of a unique > > >

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-24 Thread Michael Walle
Am 2020-06-24 10:23, schrieb Lee Jones: On Wed, 24 Jun 2020, Michael Walle wrote: [..] Although Rob mentioned to maybe relax that, but I sill fail to see the advantage to have an arbitrary reg property instead of a unique node name. I don't have a strong opinion either way. We can *also*

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-24 Thread Lee Jones
On Wed, 24 Jun 2020, Michael Walle wrote: > Hi, > > Am 2020-06-24 08:41, schrieb Lee Jones: > > On Tue, 23 Jun 2020, Frank Rowand wrote: > > > > > On 2020-06-11 14:10, Lee Jones wrote: > > > > Currently, when a child platform device (sometimes referred to as a > > > > sub-device) is registered

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-24 Thread Michael Walle
Hi, Am 2020-06-24 08:41, schrieb Lee Jones: On Tue, 23 Jun 2020, Frank Rowand wrote: On 2020-06-11 14:10, Lee Jones wrote: > Currently, when a child platform device (sometimes referred to as a > sub-device) is registered via the Multi-Functional Device (MFD) API, > the framework attempts to

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-24 Thread Lee Jones
On Tue, 23 Jun 2020, Frank Rowand wrote: > On 2020-06-23 14:59, Lee Jones wrote: > > Suggestion #2 > > > >> 2) Modify patch 1/3. The small part of the patch to modify is: > >> > >> +static int mfd_match_of_node_to_dev(struct platform_device *pdev, > >> +

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-24 Thread Lee Jones
On Tue, 23 Jun 2020, Frank Rowand wrote: > On 2020-06-11 14:10, Lee Jones wrote: > > Currently, when a child platform device (sometimes referred to as a > > sub-device) is registered via the Multi-Functional Device (MFD) API, > > the framework attempts to match the newly registered platform

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-24 Thread Lee Jones
On Tue, 23 Jun 2020, Frank Rowand wrote: > On 2020-06-11 14:10, Lee Jones wrote: > > Currently, when a child platform device (sometimes referred to as a > > sub-device) is registered via the Multi-Functional Device (MFD) API, > > the framework attempts to match the newly registered platform

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-23 Thread Frank Rowand
On 2020-06-11 14:10, Lee Jones wrote: > Currently, when a child platform device (sometimes referred to as a > sub-device) is registered via the Multi-Functional Device (MFD) API, > the framework attempts to match the newly registered platform device > with its associated Device Tree (OF) node.

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-23 Thread Frank Rowand
On 2020-06-23 14:59, Lee Jones wrote: > Suggestion #2 > >> 2) Modify patch 1/3. The small part of the patch to modify is: >> >> +static int mfd_match_of_node_to_dev(struct platform_device *pdev, >> +struct device_node *np, >> +

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-23 Thread Frank Rowand
On 2020-06-11 14:10, Lee Jones wrote: > Currently, when a child platform device (sometimes referred to as a > sub-device) is registered via the Multi-Functional Device (MFD) API, > the framework attempts to match the newly registered platform device > with its associated Device Tree (OF) node.

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-23 Thread Lee Jones
Suggestion #2 > 2) Modify patch 1/3. The small part of the patch to modify is: > > +static int mfd_match_of_node_to_dev(struct platform_device *pdev, > +struct device_node *np, > +const struct

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-23 Thread Frank Rowand
On 2020-06-23 01:47, Lee Jones wrote: > On Mon, 22 Jun 2020, Frank Rowand wrote: > >> On 2020-06-22 14:11, Lee Jones wrote: >>> On Mon, 22 Jun 2020, Frank Rowand wrote: >>> On 2020-06-22 10:10, Lee Jones wrote: > On Mon, 22 Jun 2020, Frank Rowand wrote: > >> On 2020-06-22 03:50,

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-23 Thread Lee Jones
On Mon, 22 Jun 2020, Frank Rowand wrote: > On 2020-06-22 14:11, Lee Jones wrote: > > On Mon, 22 Jun 2020, Frank Rowand wrote: > > > >> On 2020-06-22 10:10, Lee Jones wrote: > >>> On Mon, 22 Jun 2020, Frank Rowand wrote: > >>> > On 2020-06-22 03:50, Lee Jones wrote: > > On Thu, 18 Jun

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-22 Thread Frank Rowand
On 2020-06-22 20:17, Frank Rowand wrote: > On 2020-06-22 17:23, Frank Rowand wrote: >> On 2020-06-22 14:11, Lee Jones wrote: >>> On Mon, 22 Jun 2020, Frank Rowand wrote: >>> On 2020-06-22 10:10, Lee Jones wrote: > On Mon, 22 Jun 2020, Frank Rowand wrote: > >> On 2020-06-22 03:50,

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-22 Thread Frank Rowand
On 2020-06-22 17:23, Frank Rowand wrote: > On 2020-06-22 14:11, Lee Jones wrote: >> On Mon, 22 Jun 2020, Frank Rowand wrote: >> >>> On 2020-06-22 10:10, Lee Jones wrote: On Mon, 22 Jun 2020, Frank Rowand wrote: > On 2020-06-22 03:50, Lee Jones wrote: >> On Thu, 18 Jun 2020, Frank

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-22 Thread Frank Rowand
On 2020-06-22 14:11, Lee Jones wrote: > On Mon, 22 Jun 2020, Frank Rowand wrote: > >> On 2020-06-22 10:10, Lee Jones wrote: >>> On Mon, 22 Jun 2020, Frank Rowand wrote: >>> On 2020-06-22 03:50, Lee Jones wrote: > On Thu, 18 Jun 2020, Frank Rowand wrote: > >> On 2020-06-15 04:26,

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-22 Thread Lee Jones
On Mon, 22 Jun 2020, Frank Rowand wrote: > On 2020-06-22 10:10, Lee Jones wrote: > > On Mon, 22 Jun 2020, Frank Rowand wrote: > > > >> On 2020-06-22 03:50, Lee Jones wrote: > >>> On Thu, 18 Jun 2020, Frank Rowand wrote: > >>> > On 2020-06-15 04:26, Lee Jones wrote: > > On Sun, 14 Jun

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-22 Thread Frank Rowand
On 2020-06-22 13:01, Frank Rowand wrote: > On 2020-06-22 10:10, Lee Jones wrote: >> On Mon, 22 Jun 2020, Frank Rowand wrote: >> >>> On 2020-06-22 03:50, Lee Jones wrote: On Thu, 18 Jun 2020, Frank Rowand wrote: > On 2020-06-15 04:26, Lee Jones wrote: >> On Sun, 14 Jun 2020, Frank

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-22 Thread Frank Rowand
On 2020-06-22 10:10, Lee Jones wrote: > On Mon, 22 Jun 2020, Frank Rowand wrote: > >> On 2020-06-22 03:50, Lee Jones wrote: >>> On Thu, 18 Jun 2020, Frank Rowand wrote: >>> On 2020-06-15 04:26, Lee Jones wrote: > On Sun, 14 Jun 2020, Frank Rowand wrote: > >> Hi Lee, >> >>

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-22 Thread Lee Jones
On Mon, 22 Jun 2020, Frank Rowand wrote: > On 2020-06-22 03:09, Lee Jones wrote: > > On Thu, 11 Jun 2020, Lee Jones wrote: > > > >> Currently, when a child platform device (sometimes referred to as a > >> sub-device) is registered via the Multi-Functional Device (MFD) API, > >> the framework

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-22 Thread Frank Rowand
On 2020-06-22 03:09, Lee Jones wrote: > On Thu, 11 Jun 2020, Lee Jones wrote: > >> Currently, when a child platform device (sometimes referred to as a >> sub-device) is registered via the Multi-Functional Device (MFD) API, >> the framework attempts to match the newly registered platform device >>

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-22 Thread Lee Jones
On Mon, 22 Jun 2020, Frank Rowand wrote: > On 2020-06-22 03:50, Lee Jones wrote: > > On Thu, 18 Jun 2020, Frank Rowand wrote: > > > >> On 2020-06-15 04:26, Lee Jones wrote: > >>> On Sun, 14 Jun 2020, Frank Rowand wrote: > >>> > Hi Lee, > > I'm looking at 5.8-rc1. > > The

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-22 Thread Frank Rowand
On 2020-06-22 09:32, Frank Rowand wrote: > On 2020-06-22 03:50, Lee Jones wrote: >> On Thu, 18 Jun 2020, Frank Rowand wrote: >> >>> On 2020-06-15 04:26, Lee Jones wrote: On Sun, 14 Jun 2020, Frank Rowand wrote: > Hi Lee, > > I'm looking at 5.8-rc1. > > The only use of

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-22 Thread Frank Rowand
On 2020-06-22 03:50, Lee Jones wrote: > On Thu, 18 Jun 2020, Frank Rowand wrote: > >> On 2020-06-15 04:26, Lee Jones wrote: >>> On Sun, 14 Jun 2020, Frank Rowand wrote: >>> Hi Lee, I'm looking at 5.8-rc1. The only use of OF_MFD_CELL() where the same compatible is

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-22 Thread Lee Jones
On Thu, 18 Jun 2020, Frank Rowand wrote: > On 2020-06-15 04:26, Lee Jones wrote: > > On Sun, 14 Jun 2020, Frank Rowand wrote: > > > >> Hi Lee, > >> > >> I'm looking at 5.8-rc1. > >> > >> The only use of OF_MFD_CELL() where the same compatible is specified > >> for multiple elements of a struct

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-22 Thread Lee Jones
On Thu, 11 Jun 2020, Lee Jones wrote: > Currently, when a child platform device (sometimes referred to as a > sub-device) is registered via the Multi-Functional Device (MFD) API, > the framework attempts to match the newly registered platform device > with its associated Device Tree (OF) node.

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-18 Thread Frank Rowand
On 2020-06-15 04:26, Lee Jones wrote: > On Sun, 14 Jun 2020, Frank Rowand wrote: > >> Hi Lee, >> >> I'm looking at 5.8-rc1. >> >> The only use of OF_MFD_CELL() where the same compatible is specified >> for multiple elements of a struct mfd_cell array is for compatible >> "stericsson,ab8500-pwm"

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-15 Thread Lee Jones
On Sun, 14 Jun 2020, Frank Rowand wrote: > Hi Lee, > > I'm looking at 5.8-rc1. > > The only use of OF_MFD_CELL() where the same compatible is specified > for multiple elements of a struct mfd_cell array is for compatible > "stericsson,ab8500-pwm" in drivers/mfd/ab8500-core.c: > >

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-14 Thread Frank Rowand
Hi Lee, I'm looking at 5.8-rc1. The only use of OF_MFD_CELL() where the same compatible is specified for multiple elements of a struct mfd_cell array is for compatible "stericsson,ab8500-pwm" in drivers/mfd/ab8500-core.c: OF_MFD_CELL("ab8500-pwm", NULL, NULL, 0, 1,

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-12 Thread Frank Rowand
+ Frank (me) On 2020-06-11 14:10, Lee Jones wrote: > Currently, when a child platform device (sometimes referred to as a > sub-device) is registered via the Multi-Functional Device (MFD) API, > the framework attempts to match the newly registered platform device > with its associated Device Tree

[PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-11 Thread Lee Jones
Currently, when a child platform device (sometimes referred to as a sub-device) is registered via the Multi-Functional Device (MFD) API, the framework attempts to match the newly registered platform device with its associated Device Tree (OF) node. Until now, the device has been allocated the

[PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-11 Thread Lee Jones
Currently, when a child platform device (sometimes referred to as a sub-device) is registered via the Multi-Functional Device (MFD) API, the framework attempts to match the newly registered platform device with its associated Device Tree (OF) node. Until now, the device has been allocated the