Re: [PATCH v2 1/3] reset: hisilicon: Add media reset controller binding

[Xinliang Liu]

Hi,

On 16 June 2016 at 18:46, Philipp Zabel  wrote:
> Am Donnerstag, den 16.06.2016, 18:29 +0800 schrieb Xinliang Liu:
>> Add compatible for media reset controller.
>>
>> Signed-off-by: Xinliang Liu 
>> ---
>>  Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git 
>> a/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt 
>> b/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt
>> index e0b185a944ba..c25da39df707 100644
>> --- a/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt
>> +++ b/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt
>> @@ -8,7 +8,9 @@ The reset controller registers are part of the system-ctl 
>> block on
>>  hi6220 SoC.
>>
>>  Required properties:
>> -- compatible: may be "hisilicon,hi6220-sysctrl"
>> +- compatible: should be one of the following:
>> +  - "hisilicon,hi6220-sysctrl", "syscon" : For peripheral reset controller.
>> +  - "hisilicon,hi6220-mediactrl", "syscon" : For media reset controller.
>
> This does more than the commit message says. Why do you add syscon here?
> Do the sysctrl and mediactrl register ranges have bits other than reset
> controls that will be used by other drivers via the syscon mechanism?

yes, that's right. Actually, ahead of the Required properties part,
there is the sentence description "The reset controller registers are
part of the system-ctl block"
has said that reset bits are inside system controller.

Thanks,
-xinliang

>
> regards
> Philipp
>

Re: [PATCH v2 1/3] reset: hisilicon: Add media reset controller binding

[Xinliang Liu]

Hi,

On 16 June 2016 at 18:46, Philipp Zabel  wrote:
> Am Donnerstag, den 16.06.2016, 18:29 +0800 schrieb Xinliang Liu:
>> Add compatible for media reset controller.
>>
>> Signed-off-by: Xinliang Liu 
>> ---
>>  Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git 
>> a/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt 
>> b/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt
>> index e0b185a944ba..c25da39df707 100644
>> --- a/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt
>> +++ b/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt
>> @@ -8,7 +8,9 @@ The reset controller registers are part of the system-ctl 
>> block on
>>  hi6220 SoC.
>>
>>  Required properties:
>> -- compatible: may be "hisilicon,hi6220-sysctrl"
>> +- compatible: should be one of the following:
>> +  - "hisilicon,hi6220-sysctrl", "syscon" : For peripheral reset controller.
>> +  - "hisilicon,hi6220-mediactrl", "syscon" : For media reset controller.
>
> This does more than the commit message says. Why do you add syscon here?
> Do the sysctrl and mediactrl register ranges have bits other than reset
> controls that will be used by other drivers via the syscon mechanism?

yes, that's right. Actually, ahead of the Required properties part,
there is the sentence description "The reset controller registers are
part of the system-ctl block"
has said that reset bits are inside system controller.

Thanks,
-xinliang

>
> regards
> Philipp
>

Re: [PATCH v2 1/3] reset: hisilicon: Add media reset controller binding

[Philipp Zabel]

Am Donnerstag, den 16.06.2016, 18:29 +0800 schrieb Xinliang Liu:
> Add compatible for media reset controller.
> 
> Signed-off-by: Xinliang Liu 
> ---
>  Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git 
> a/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt 
> b/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt
> index e0b185a944ba..c25da39df707 100644
> --- a/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt
> +++ b/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt
> @@ -8,7 +8,9 @@ The reset controller registers are part of the system-ctl 
> block on
>  hi6220 SoC.
>  
>  Required properties:
> -- compatible: may be "hisilicon,hi6220-sysctrl"
> +- compatible: should be one of the following:
> +  - "hisilicon,hi6220-sysctrl", "syscon" : For peripheral reset controller.
> +  - "hisilicon,hi6220-mediactrl", "syscon" : For media reset controller.

This does more than the commit message says. Why do you add syscon here?
Do the sysctrl and mediactrl register ranges have bits other than reset
controls that will be used by other drivers via the syscon mechanism?

regards
Philipp

Re: [PATCH v2 1/3] reset: hisilicon: Add media reset controller binding

[Philipp Zabel]

Am Donnerstag, den 16.06.2016, 18:29 +0800 schrieb Xinliang Liu:
> Add compatible for media reset controller.
> 
> Signed-off-by: Xinliang Liu 
> ---
>  Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git 
> a/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt 
> b/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt
> index e0b185a944ba..c25da39df707 100644
> --- a/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt
> +++ b/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt
> @@ -8,7 +8,9 @@ The reset controller registers are part of the system-ctl 
> block on
>  hi6220 SoC.
>  
>  Required properties:
> -- compatible: may be "hisilicon,hi6220-sysctrl"
> +- compatible: should be one of the following:
> +  - "hisilicon,hi6220-sysctrl", "syscon" : For peripheral reset controller.
> +  - "hisilicon,hi6220-mediactrl", "syscon" : For media reset controller.

This does more than the commit message says. Why do you add syscon here?
Do the sysctrl and mediactrl register ranges have bits other than reset
controls that will be used by other drivers via the syscon mechanism?

regards
Philipp

[PATCH v2 1/3] reset: hisilicon: Add media reset controller binding

[Xinliang Liu]

Add compatible for media reset controller.

Signed-off-by: Xinliang Liu 
---
 Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt 
b/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt
index e0b185a944ba..c25da39df707 100644
--- a/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt
+++ b/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt
@@ -8,7 +8,9 @@ The reset controller registers are part of the system-ctl block 
on
 hi6220 SoC.
 
 Required properties:
-- compatible: may be "hisilicon,hi6220-sysctrl"
+- compatible: should be one of the following:
+  - "hisilicon,hi6220-sysctrl", "syscon" : For peripheral reset controller.
+  - "hisilicon,hi6220-mediactrl", "syscon" : For media reset controller.
 - reg: should be register base and length as documented in the
   datasheet
 - #reset-cells: 1, see below
-- 
2.8.3

[PATCH v2 1/3] reset: hisilicon: Add media reset controller binding

[Xinliang Liu]

Add compatible for media reset controller.

Signed-off-by: Xinliang Liu 
---
 Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt 
b/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt
index e0b185a944ba..c25da39df707 100644
--- a/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt
+++ b/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt
@@ -8,7 +8,9 @@ The reset controller registers are part of the system-ctl block 
on
 hi6220 SoC.
 
 Required properties:
-- compatible: may be "hisilicon,hi6220-sysctrl"
+- compatible: should be one of the following:
+  - "hisilicon,hi6220-sysctrl", "syscon" : For peripheral reset controller.
+  - "hisilicon,hi6220-mediactrl", "syscon" : For media reset controller.
 - reg: should be register base and length as documented in the
   datasheet
 - #reset-cells: 1, see below
-- 
2.8.3