Re: [PATCH v2 1/3] staging: rtl8188eu: Remove redundant parenthesis

[Greg KH]

On Tue, Jun 13, 2017 at 08:50:38AM +0300, Aviya Erenfeld wrote:
> Remove redundant parenthesis
> 
> Signed-off-by: Aviya Erenfeld 
> ---
>  drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 22 +++---
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c 
> b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> index 2ecfb11..c6a7df5 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> @@ -91,7 +91,7 @@ u32 _rtw_init_sta_priv(struct   sta_priv *pstapriv)
>   for (i = 0; i < NUM_STA; i++) {
>   _rtw_init_stainfo(psta);
>  
> - INIT_LIST_HEAD(&(pstapriv->sta_hash[i]));
> + INIT_LIST_HEAD(>sta_hash[i]);

What complaines about these?  Does checkpatch?  Or something else?

It makes sense why they were added, don't you think so?  It makes the
code easier to understand in some places.

thanks,

greg k-h

Re: [PATCH v2 1/3] staging: rtl8188eu: Remove redundant parenthesis

[Greg KH]

On Tue, Jun 13, 2017 at 08:50:38AM +0300, Aviya Erenfeld wrote:
> Remove redundant parenthesis
> 
> Signed-off-by: Aviya Erenfeld 
> ---
>  drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 22 +++---
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c 
> b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> index 2ecfb11..c6a7df5 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> @@ -91,7 +91,7 @@ u32 _rtw_init_sta_priv(struct   sta_priv *pstapriv)
>   for (i = 0; i < NUM_STA; i++) {
>   _rtw_init_stainfo(psta);
>  
> - INIT_LIST_HEAD(&(pstapriv->sta_hash[i]));
> + INIT_LIST_HEAD(>sta_hash[i]);

What complaines about these?  Does checkpatch?  Or something else?

It makes sense why they were added, don't you think so?  It makes the
code easier to understand in some places.

thanks,

greg k-h

[PATCH v2 1/3] staging: rtl8188eu: Remove redundant parenthesis

[Aviya Erenfeld]

Remove redundant parenthesis

Signed-off-by: Aviya Erenfeld 
---
 drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 22 +++---
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c 
b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
index 2ecfb11..c6a7df5 100644
--- a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
+++ b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
@@ -91,7 +91,7 @@ u32   _rtw_init_sta_priv(struct   sta_priv *pstapriv)
for (i = 0; i < NUM_STA; i++) {
_rtw_init_stainfo(psta);
 
-   INIT_LIST_HEAD(&(pstapriv->sta_hash[i]));
+   INIT_LIST_HEAD(>sta_hash[i]);
 
list_add_tail(>list, 
get_list_head(>free_sta_queue));
 
@@ -149,7 +149,7 @@ u32 _rtw_free_sta_priv(struct   sta_priv *pstapriv)
/*  delete all reordering_ctrl_timer*/
spin_lock_bh(>sta_hash_lock);
for (index = 0; index < NUM_STA; index++) {
-   phead = &(pstapriv->sta_hash[index]);
+   phead = >sta_hash[index];
plist = phead->next;
 
while (phead != plist) {
@@ -278,19 +278,19 @@ u32   rtw_free_stainfo(struct adapter *padapter, 
struct sta_info *psta)
 
rtw_free_xmitframe_queue(pxmitpriv, >vo_q.sta_pending);
 
-   list_del_init(&(pstaxmitpriv->vo_q.tx_pending));
+   list_del_init(>vo_q.tx_pending);
 
rtw_free_xmitframe_queue(pxmitpriv, >vi_q.sta_pending);
 
-   list_del_init(&(pstaxmitpriv->vi_q.tx_pending));
+   list_del_init(>vi_q.tx_pending);
 
rtw_free_xmitframe_queue(pxmitpriv, >bk_q.sta_pending);
 
-   list_del_init(&(pstaxmitpriv->bk_q.tx_pending));
+   list_del_init(>bk_q.tx_pending);
 
rtw_free_xmitframe_queue(pxmitpriv, >be_q.sta_pending);
 
-   list_del_init(&(pstaxmitpriv->be_q.tx_pending));
+   list_del_init(>be_q.tx_pending);
 
spin_unlock_bh(>lock);
 
@@ -331,7 +331,7 @@ u32 rtw_free_stainfo(struct adapter *padapter, struct 
sta_info *psta)
 
plist = plist->next;
 
-   list_del_init(&(prframe->list));
+   list_del_init(>list);
 
rtw_free_recvframe(prframe, pfree_recv_queue);
}
@@ -375,7 +375,7 @@ u32 rtw_free_stainfo(struct adapter *padapter, struct 
sta_info *psta)
 
 #endif /*  CONFIG_88EU_AP_MODE */
 
-   spin_lock_bh(&(pfree_sta_queue->lock));
+   spin_lock_bh(_sta_queue->lock);
list_add_tail(>list, get_list_head(pfree_sta_queue));
spin_unlock_bh(_sta_queue->lock);
 
@@ -401,7 +401,7 @@ void rtw_free_all_stainfo(struct adapter *padapter)
spin_lock_bh(>sta_hash_lock);
 
for (index = 0; index < NUM_STA; index++) {
-   phead = &(pstapriv->sta_hash[index]);
+   phead = >sta_hash[index];
plist = phead->next;
 
while (phead != plist) {
@@ -438,7 +438,7 @@ struct sta_info *rtw_get_stainfo(struct sta_priv *pstapriv, 
u8 *hwaddr)
 
spin_lock_bh(>sta_hash_lock);
 
-   phead = &(pstapriv->sta_hash[index]);
+   phead = >sta_hash[index];
plist = phead->next;
 
while (phead != plist) {
@@ -497,7 +497,7 @@ u8 rtw_access_ctrl(struct adapter *padapter, u8 *mac_addr)
struct wlan_acl_pool *pacl_list = >acl_list;
struct __queue *pacl_node_q = _list->acl_node_q;
 
-   spin_lock_bh(&(pacl_node_q->lock));
+   spin_lock_bh(_node_q->lock);
phead = get_list_head(pacl_node_q);
plist = phead->next;
while (phead != plist) {
-- 
2.7.4

[PATCH v2 1/3] staging: rtl8188eu: Remove redundant parenthesis

[Aviya Erenfeld]

Remove redundant parenthesis

Signed-off-by: Aviya Erenfeld 
---
 drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 22 +++---
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c 
b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
index 2ecfb11..c6a7df5 100644
--- a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
+++ b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
@@ -91,7 +91,7 @@ u32   _rtw_init_sta_priv(struct   sta_priv *pstapriv)
for (i = 0; i < NUM_STA; i++) {
_rtw_init_stainfo(psta);
 
-   INIT_LIST_HEAD(&(pstapriv->sta_hash[i]));
+   INIT_LIST_HEAD(>sta_hash[i]);
 
list_add_tail(>list, 
get_list_head(>free_sta_queue));
 
@@ -149,7 +149,7 @@ u32 _rtw_free_sta_priv(struct   sta_priv *pstapriv)
/*  delete all reordering_ctrl_timer*/
spin_lock_bh(>sta_hash_lock);
for (index = 0; index < NUM_STA; index++) {
-   phead = &(pstapriv->sta_hash[index]);
+   phead = >sta_hash[index];
plist = phead->next;
 
while (phead != plist) {
@@ -278,19 +278,19 @@ u32   rtw_free_stainfo(struct adapter *padapter, 
struct sta_info *psta)
 
rtw_free_xmitframe_queue(pxmitpriv, >vo_q.sta_pending);
 
-   list_del_init(&(pstaxmitpriv->vo_q.tx_pending));
+   list_del_init(>vo_q.tx_pending);
 
rtw_free_xmitframe_queue(pxmitpriv, >vi_q.sta_pending);
 
-   list_del_init(&(pstaxmitpriv->vi_q.tx_pending));
+   list_del_init(>vi_q.tx_pending);
 
rtw_free_xmitframe_queue(pxmitpriv, >bk_q.sta_pending);
 
-   list_del_init(&(pstaxmitpriv->bk_q.tx_pending));
+   list_del_init(>bk_q.tx_pending);
 
rtw_free_xmitframe_queue(pxmitpriv, >be_q.sta_pending);
 
-   list_del_init(&(pstaxmitpriv->be_q.tx_pending));
+   list_del_init(>be_q.tx_pending);
 
spin_unlock_bh(>lock);
 
@@ -331,7 +331,7 @@ u32 rtw_free_stainfo(struct adapter *padapter, struct 
sta_info *psta)
 
plist = plist->next;
 
-   list_del_init(&(prframe->list));
+   list_del_init(>list);
 
rtw_free_recvframe(prframe, pfree_recv_queue);
}
@@ -375,7 +375,7 @@ u32 rtw_free_stainfo(struct adapter *padapter, struct 
sta_info *psta)
 
 #endif /*  CONFIG_88EU_AP_MODE */
 
-   spin_lock_bh(&(pfree_sta_queue->lock));
+   spin_lock_bh(_sta_queue->lock);
list_add_tail(>list, get_list_head(pfree_sta_queue));
spin_unlock_bh(_sta_queue->lock);
 
@@ -401,7 +401,7 @@ void rtw_free_all_stainfo(struct adapter *padapter)
spin_lock_bh(>sta_hash_lock);
 
for (index = 0; index < NUM_STA; index++) {
-   phead = &(pstapriv->sta_hash[index]);
+   phead = >sta_hash[index];
plist = phead->next;
 
while (phead != plist) {
@@ -438,7 +438,7 @@ struct sta_info *rtw_get_stainfo(struct sta_priv *pstapriv, 
u8 *hwaddr)
 
spin_lock_bh(>sta_hash_lock);
 
-   phead = &(pstapriv->sta_hash[index]);
+   phead = >sta_hash[index];
plist = phead->next;
 
while (phead != plist) {
@@ -497,7 +497,7 @@ u8 rtw_access_ctrl(struct adapter *padapter, u8 *mac_addr)
struct wlan_acl_pool *pacl_list = >acl_list;
struct __queue *pacl_node_q = _list->acl_node_q;
 
-   spin_lock_bh(&(pacl_node_q->lock));
+   spin_lock_bh(_node_q->lock);
phead = get_list_head(pacl_node_q);
plist = phead->next;
while (phead != plist) {
-- 
2.7.4