Re: [PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc controller before programming it

2016-07-27 Thread Rob Herring
On Tue, Jul 26, 2016 at 08:13:12PM +0800, Caesar Wang wrote: > SARADC controller needs to be reset before programming it, otherwise > it will not function properly. > > Signed-off-by: Caesar Wang > Cc: Jonathan Cameron > Cc: Heiko Stuebner

Re: [PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc controller before programming it

2016-07-27 Thread Rob Herring
On Tue, Jul 26, 2016 at 08:13:12PM +0800, Caesar Wang wrote: > SARADC controller needs to be reset before programming it, otherwise > it will not function properly. > > Signed-off-by: Caesar Wang > Cc: Jonathan Cameron > Cc: Heiko Stuebner > Cc: Rob Herring > Cc: linux-...@vger.kernel.org >

Re: [PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc controller before programming it

2016-07-26 Thread Caesar Wang
On 2016年07月27日 10:00, Guenter Roeck wrote: On 07/26/2016 05:42 PM, Caesar Wang wrote: On 2016年07月27日 01:00, Guenter Roeck wrote: On Tue, Jul 26, 2016 at 10:47:16PM +0800, Caesar Wang wrote: On 2016年07月26日 21:39, Guenter Roeck wrote: static int rockchip_saradc_probe(struct platform_device

Re: [PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc controller before programming it

2016-07-26 Thread Caesar Wang
On 2016年07月27日 10:00, Guenter Roeck wrote: On 07/26/2016 05:42 PM, Caesar Wang wrote: On 2016年07月27日 01:00, Guenter Roeck wrote: On Tue, Jul 26, 2016 at 10:47:16PM +0800, Caesar Wang wrote: On 2016年07月26日 21:39, Guenter Roeck wrote: static int rockchip_saradc_probe(struct platform_device

Re: [PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc controller before programming it

2016-07-26 Thread Guenter Roeck
On 07/26/2016 05:42 PM, Caesar Wang wrote: On 2016年07月27日 01:00, Guenter Roeck wrote: On Tue, Jul 26, 2016 at 10:47:16PM +0800, Caesar Wang wrote: On 2016年07月26日 21:39, Guenter Roeck wrote: static int rockchip_saradc_probe(struct platform_device *pdev) { struct rockchip_saradc *info = NULL;

Re: [PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc controller before programming it

2016-07-26 Thread Guenter Roeck
On 07/26/2016 05:42 PM, Caesar Wang wrote: On 2016年07月27日 01:00, Guenter Roeck wrote: On Tue, Jul 26, 2016 at 10:47:16PM +0800, Caesar Wang wrote: On 2016年07月26日 21:39, Guenter Roeck wrote: static int rockchip_saradc_probe(struct platform_device *pdev) { struct rockchip_saradc *info = NULL;

Re: [PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc controller before programming it

2016-07-26 Thread Caesar Wang
On 2016年07月27日 01:00, Guenter Roeck wrote: On Tue, Jul 26, 2016 at 10:47:16PM +0800, Caesar Wang wrote: On 2016年07月26日 21:39, Guenter Roeck wrote: static int rockchip_saradc_probe(struct platform_device *pdev) { struct rockchip_saradc *info = NULL; @@ -218,6 +231,21 @@ static int

Re: [PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc controller before programming it

2016-07-26 Thread Caesar Wang
On 2016年07月27日 01:00, Guenter Roeck wrote: On Tue, Jul 26, 2016 at 10:47:16PM +0800, Caesar Wang wrote: On 2016年07月26日 21:39, Guenter Roeck wrote: static int rockchip_saradc_probe(struct platform_device *pdev) { struct rockchip_saradc *info = NULL; @@ -218,6 +231,21 @@ static int

Re: [PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc controller before programming it

2016-07-26 Thread Guenter Roeck
On Tue, Jul 26, 2016 at 08:13:12PM +0800, Caesar Wang wrote: > SARADC controller needs to be reset before programming it, otherwise > it will not function properly. > > Signed-off-by: Caesar Wang > Cc: Jonathan Cameron > Cc: Heiko Stuebner

Re: [PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc controller before programming it

2016-07-26 Thread Guenter Roeck
On Tue, Jul 26, 2016 at 08:13:12PM +0800, Caesar Wang wrote: > SARADC controller needs to be reset before programming it, otherwise > it will not function properly. > > Signed-off-by: Caesar Wang > Cc: Jonathan Cameron > Cc: Heiko Stuebner > Cc: Rob Herring > Cc: linux-...@vger.kernel.org >

Re: [PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc controller before programming it

2016-07-26 Thread Guenter Roeck
On Tue, Jul 26, 2016 at 10:47:16PM +0800, Caesar Wang wrote: > > On 2016年07月26日 21:39, Guenter Roeck wrote: > > > >>static int rockchip_saradc_probe(struct platform_device *pdev) > >>{ > >>struct rockchip_saradc *info = NULL; > >>@@ -218,6 +231,21 @@ static int rockchip_saradc_probe(struct >

Re: [PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc controller before programming it

2016-07-26 Thread Guenter Roeck
On Tue, Jul 26, 2016 at 10:47:16PM +0800, Caesar Wang wrote: > > On 2016年07月26日 21:39, Guenter Roeck wrote: > > > >>static int rockchip_saradc_probe(struct platform_device *pdev) > >>{ > >>struct rockchip_saradc *info = NULL; > >>@@ -218,6 +231,21 @@ static int rockchip_saradc_probe(struct >

Re: [PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc controller before programming it

2016-07-26 Thread Caesar Wang
On 2016年07月26日 21:39, Guenter Roeck wrote: static int rockchip_saradc_probe(struct platform_device *pdev) { struct rockchip_saradc *info = NULL; @@ -218,6 +231,21 @@ static int rockchip_saradc_probe(struct platform_device *pdev) if (IS_ERR(info->regs)) return PTR_ERR(info->regs); + /* + *

Re: [PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc controller before programming it

2016-07-26 Thread Caesar Wang
On 2016年07月26日 21:39, Guenter Roeck wrote: static int rockchip_saradc_probe(struct platform_device *pdev) { struct rockchip_saradc *info = NULL; @@ -218,6 +231,21 @@ static int rockchip_saradc_probe(struct platform_device *pdev) if (IS_ERR(info->regs)) return PTR_ERR(info->regs); + /* + *

Re: [PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc controller before programming it

2016-07-26 Thread Guenter Roeck
On 07/26/2016 05:13 AM, Caesar Wang wrote: SARADC controller needs to be reset before programming it, otherwise it will not function properly. Signed-off-by: Caesar Wang Cc: Jonathan Cameron Cc: Heiko Stuebner Cc: Rob Herring

Re: [PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc controller before programming it

2016-07-26 Thread Guenter Roeck
On 07/26/2016 05:13 AM, Caesar Wang wrote: SARADC controller needs to be reset before programming it, otherwise it will not function properly. Signed-off-by: Caesar Wang Cc: Jonathan Cameron Cc: Heiko Stuebner Cc: Rob Herring Cc: linux-...@vger.kernel.org Cc:

[PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc controller before programming it

2016-07-26 Thread Caesar Wang
SARADC controller needs to be reset before programming it, otherwise it will not function properly. Signed-off-by: Caesar Wang Cc: Jonathan Cameron Cc: Heiko Stuebner Cc: Rob Herring Cc: linux-...@vger.kernel.org Cc:

[PATCH v2 1/4] iio: adc: rockchip_saradc: reset saradc controller before programming it

2016-07-26 Thread Caesar Wang
SARADC controller needs to be reset before programming it, otherwise it will not function properly. Signed-off-by: Caesar Wang Cc: Jonathan Cameron Cc: Heiko Stuebner Cc: Rob Herring Cc: linux-...@vger.kernel.org Cc: linux-rockc...@lists.infradead.org --- Changes in v2: - Make the reset as