Re: [PATCH v2 1/4] pinctrl: qcom: Introduce readl/writel accessors

2018-09-28 Thread Linus Walleij
On Fri, Sep 28, 2018 at 9:10 AM Linus Walleij wrote: > This clashes with Stephen Boyds fix: > "pinctrl: msm: Really mask level interrupts to prevent latching" > > I've resolved it like this: Also this: static void msm_gpio_irq_unmask(struct irq_data *d) { struct gpio_chip *gc =

Re: [PATCH v2 1/4] pinctrl: qcom: Introduce readl/writel accessors

2018-09-28 Thread Linus Walleij
On Fri, Sep 28, 2018 at 9:10 AM Linus Walleij wrote: > This clashes with Stephen Boyds fix: > "pinctrl: msm: Really mask level interrupts to prevent latching" > > I've resolved it like this: Also this: static void msm_gpio_irq_unmask(struct irq_data *d) { struct gpio_chip *gc =

Re: [PATCH v2 1/4] pinctrl: qcom: Introduce readl/writel accessors

2018-09-28 Thread Linus Walleij
On Tue, Sep 25, 2018 at 12:15 AM Bjorn Andersson wrote: > In preparation for the support for dispersed tiles move all readl and > writel calls to helper functions. This will allow us to isolate the > added complexity of another indirection. > > Signed-off-by: Bjorn Andersson This clashes with

Re: [PATCH v2 1/4] pinctrl: qcom: Introduce readl/writel accessors

2018-09-28 Thread Linus Walleij
On Tue, Sep 25, 2018 at 12:15 AM Bjorn Andersson wrote: > In preparation for the support for dispersed tiles move all readl and > writel calls to helper functions. This will allow us to isolate the > added complexity of another indirection. > > Signed-off-by: Bjorn Andersson This clashes with

Re: [PATCH v2 1/4] pinctrl: qcom: Introduce readl/writel accessors

2018-09-26 Thread Linus Walleij
On Tue, Sep 25, 2018 at 12:15 AM Bjorn Andersson wrote: > In preparation for the support for dispersed tiles move all readl and > writel calls to helper functions. This will allow us to isolate the > added complexity of another indirection. > > Signed-off-by: Bjorn Andersson > --- > > Changes

Re: [PATCH v2 1/4] pinctrl: qcom: Introduce readl/writel accessors

2018-09-26 Thread Linus Walleij
On Tue, Sep 25, 2018 at 12:15 AM Bjorn Andersson wrote: > In preparation for the support for dispersed tiles move all readl and > writel calls to helper functions. This will allow us to isolate the > added complexity of another indirection. > > Signed-off-by: Bjorn Andersson > --- > > Changes

[PATCH v2 1/4] pinctrl: qcom: Introduce readl/writel accessors

2018-09-24 Thread Bjorn Andersson
In preparation for the support for dispersed tiles move all readl and writel calls to helper functions. This will allow us to isolate the added complexity of another indirection. Signed-off-by: Bjorn Andersson --- Changes since v1: - Rebased onto "devel" drivers/pinctrl/qcom/pinctrl-msm.c |

[PATCH v2 1/4] pinctrl: qcom: Introduce readl/writel accessors

2018-09-24 Thread Bjorn Andersson
In preparation for the support for dispersed tiles move all readl and writel calls to helper functions. This will allow us to isolate the added complexity of another indirection. Signed-off-by: Bjorn Andersson --- Changes since v1: - Rebased onto "devel" drivers/pinctrl/qcom/pinctrl-msm.c |