On Thu, 29 Nov 2018, Vitaly Kuznetsov wrote:
> Nadav Amit writes:
>
> >> On Nov 28, 2018, at 5:07 AM, Thomas Gleixner wrote:
> >>
> >> On Wed, 28 Nov 2018, Vitaly Kuznetsov wrote:
> >>
> >>> Nadav Amit writes:
> >>>
> On a different note: how come all of the hyper-v structs are not
On Thu, 29 Nov 2018, Vitaly Kuznetsov wrote:
> Nadav Amit writes:
>
> >> On Nov 28, 2018, at 5:07 AM, Thomas Gleixner wrote:
> >>
> >> On Wed, 28 Nov 2018, Vitaly Kuznetsov wrote:
> >>
> >>> Nadav Amit writes:
> >>>
> On a different note: how come all of the hyper-v structs are not
Nadav Amit writes:
>> On Nov 28, 2018, at 5:07 AM, Thomas Gleixner wrote:
>>
>> On Wed, 28 Nov 2018, Vitaly Kuznetsov wrote:
>>
>>> Nadav Amit writes:
>>>
On a different note: how come all of the hyper-v structs are not marked
with the “packed" attribute?
>>>
>>> "packed" should
Nadav Amit writes:
>> On Nov 28, 2018, at 5:07 AM, Thomas Gleixner wrote:
>>
>> On Wed, 28 Nov 2018, Vitaly Kuznetsov wrote:
>>
>>> Nadav Amit writes:
>>>
On a different note: how come all of the hyper-v structs are not marked
with the “packed" attribute?
>>>
>>> "packed" should
On Wed, Nov 28, 2018 at 02:07:42PM +0100, Thomas Gleixner wrote:
> On Wed, 28 Nov 2018, Vitaly Kuznetsov wrote:
>
> > Nadav Amit writes:
> >
> > >
> > > On a different note: how come all of the hyper-v structs are not marked
> > > with the “packed" attribute?
> >
> > "packed" should not be
On Wed, Nov 28, 2018 at 02:07:42PM +0100, Thomas Gleixner wrote:
> On Wed, 28 Nov 2018, Vitaly Kuznetsov wrote:
>
> > Nadav Amit writes:
> >
> > >
> > > On a different note: how come all of the hyper-v structs are not marked
> > > with the “packed" attribute?
> >
> > "packed" should not be
> On Nov 28, 2018, at 5:07 AM, Thomas Gleixner wrote:
>
> On Wed, 28 Nov 2018, Vitaly Kuznetsov wrote:
>
>> Nadav Amit writes:
>>
>>> On a different note: how come all of the hyper-v structs are not marked
>>> with the “packed" attribute?
>>
>> "packed" should not be needed with proper
> On Nov 28, 2018, at 5:07 AM, Thomas Gleixner wrote:
>
> On Wed, 28 Nov 2018, Vitaly Kuznetsov wrote:
>
>> Nadav Amit writes:
>>
>>> On a different note: how come all of the hyper-v structs are not marked
>>> with the “packed" attribute?
>>
>> "packed" should not be needed with proper
On Wed, 28 Nov 2018, Vitaly Kuznetsov wrote:
> Nadav Amit writes:
>
> >
> > On a different note: how come all of the hyper-v structs are not marked
> > with the “packed" attribute?
>
> "packed" should not be needed with proper padding; I vaguely remember
> someone (from x86@?) arguing
On Wed, 28 Nov 2018, Vitaly Kuznetsov wrote:
> Nadav Amit writes:
>
> >
> > On a different note: how come all of the hyper-v structs are not marked
> > with the “packed" attribute?
>
> "packed" should not be needed with proper padding; I vaguely remember
> someone (from x86@?) arguing
Nadav Amit writes:
>
> On a different note: how come all of the hyper-v structs are not marked
> with the “packed" attribute?
"packed" should not be needed with proper padding; I vaguely remember
someone (from x86@?) arguing _against_ "packed".
--
Vitaly
Nadav Amit writes:
>
> On a different note: how come all of the hyper-v structs are not marked
> with the “packed" attribute?
"packed" should not be needed with proper padding; I vaguely remember
someone (from x86@?) arguing _against_ "packed".
--
Vitaly
On 27/11/18 19:48, Roman Kagan wrote:
> On Tue, Nov 27, 2018 at 02:10:49PM +0100, Vitaly Kuznetsov wrote:
>> Roman Kagan writes:
>>> On Mon, Nov 26, 2018 at 04:47:29PM +0100, Vitaly Kuznetsov wrote:
>>> I personally tend to prefer masks over bitfields, so I'd rather do the
>>> consolidation in
On 27/11/18 19:48, Roman Kagan wrote:
> On Tue, Nov 27, 2018 at 02:10:49PM +0100, Vitaly Kuznetsov wrote:
>> Roman Kagan writes:
>>> On Mon, Nov 26, 2018 at 04:47:29PM +0100, Vitaly Kuznetsov wrote:
>>> I personally tend to prefer masks over bitfields, so I'd rather do the
>>> consolidation in
> On Nov 27, 2018, at 10:48 AM, Roman Kagan wrote:
>
> On Tue, Nov 27, 2018 at 02:10:49PM +0100, Vitaly Kuznetsov wrote:
>> Roman Kagan writes:
>>> On Mon, Nov 26, 2018 at 04:47:29PM +0100, Vitaly Kuznetsov wrote:
>>> I personally tend to prefer masks over bitfields, so I'd rather do the
>>>
> On Nov 27, 2018, at 10:48 AM, Roman Kagan wrote:
>
> On Tue, Nov 27, 2018 at 02:10:49PM +0100, Vitaly Kuznetsov wrote:
>> Roman Kagan writes:
>>> On Mon, Nov 26, 2018 at 04:47:29PM +0100, Vitaly Kuznetsov wrote:
>>> I personally tend to prefer masks over bitfields, so I'd rather do the
>>>
On Tue, Nov 27, 2018 at 02:10:49PM +0100, Vitaly Kuznetsov wrote:
> Roman Kagan writes:
> > On Mon, Nov 26, 2018 at 04:47:29PM +0100, Vitaly Kuznetsov wrote:
> > I personally tend to prefer masks over bitfields, so I'd rather do the
> > consolidation in the opposite direction: use the definitions
On Tue, Nov 27, 2018 at 02:10:49PM +0100, Vitaly Kuznetsov wrote:
> Roman Kagan writes:
> > On Mon, Nov 26, 2018 at 04:47:29PM +0100, Vitaly Kuznetsov wrote:
> > I personally tend to prefer masks over bitfields, so I'd rather do the
> > consolidation in the opposite direction: use the definitions
Out of pure curiosity I decided to check what 'gcc -O3' produces when we
use bitfields and masks. As of 'gcc version 8.2.1 20181105 (Red Hat 8.2.1-5)
(GCC)'
1) bitfields:
struct abc {
int enabled:1;
int _pad:7;
int vec:8;
};
int is_good(struct abc *s) {
if
Out of pure curiosity I decided to check what 'gcc -O3' produces when we
use bitfields and masks. As of 'gcc version 8.2.1 20181105 (Red Hat 8.2.1-5)
(GCC)'
1) bitfields:
struct abc {
int enabled:1;
int _pad:7;
int vec:8;
};
int is_good(struct abc *s) {
if
From: Vitaly Kuznetsov Tuesday, November 27, 2018 5:11 AM
> > I personally tend to prefer masks over bitfields, so I'd rather do the
> > consolidation in the opposite direction: use the definitions in
> > hyperv-tlfs.h and replace those unions/bitfields elsewhere. (I vaguely
> > remember
From: Vitaly Kuznetsov Tuesday, November 27, 2018 5:11 AM
> > I personally tend to prefer masks over bitfields, so I'd rather do the
> > consolidation in the opposite direction: use the definitions in
> > hyperv-tlfs.h and replace those unions/bitfields elsewhere. (I vaguely
> > remember
Roman Kagan writes:
> [ Sorry for having missed v1 ]
>
> On Mon, Nov 26, 2018 at 04:47:29PM +0100, Vitaly Kuznetsov wrote:
>> We implement Hyper-V SynIC and synthetic timers in KVM too so there's some
>> room for code sharing.
>>
>> Signed-off-by: Vitaly Kuznetsov
>> ---
>>
Roman Kagan writes:
> [ Sorry for having missed v1 ]
>
> On Mon, Nov 26, 2018 at 04:47:29PM +0100, Vitaly Kuznetsov wrote:
>> We implement Hyper-V SynIC and synthetic timers in KVM too so there's some
>> room for code sharing.
>>
>> Signed-off-by: Vitaly Kuznetsov
>> ---
>>
[ Sorry for having missed v1 ]
On Mon, Nov 26, 2018 at 04:47:29PM +0100, Vitaly Kuznetsov wrote:
> We implement Hyper-V SynIC and synthetic timers in KVM too so there's some
> room for code sharing.
>
> Signed-off-by: Vitaly Kuznetsov
> ---
> arch/x86/include/asm/hyperv-tlfs.h | 69
[ Sorry for having missed v1 ]
On Mon, Nov 26, 2018 at 04:47:29PM +0100, Vitaly Kuznetsov wrote:
> We implement Hyper-V SynIC and synthetic timers in KVM too so there's some
> room for code sharing.
>
> Signed-off-by: Vitaly Kuznetsov
> ---
> arch/x86/include/asm/hyperv-tlfs.h | 69
From: Vitaly Kuznetsov Sent: Monday, November 26, 2018
7:47 AM
>
> We implement Hyper-V SynIC and synthetic timers in KVM too so there's some
> room for code sharing.
>
> Signed-off-by: Vitaly Kuznetsov
> ---
> arch/x86/include/asm/hyperv-tlfs.h | 69 ++
>
From: Vitaly Kuznetsov Sent: Monday, November 26, 2018
7:47 AM
>
> We implement Hyper-V SynIC and synthetic timers in KVM too so there's some
> room for code sharing.
>
> Signed-off-by: Vitaly Kuznetsov
> ---
> arch/x86/include/asm/hyperv-tlfs.h | 69 ++
>
We implement Hyper-V SynIC and synthetic timers in KVM too so there's some
room for code sharing.
Signed-off-by: Vitaly Kuznetsov
---
arch/x86/include/asm/hyperv-tlfs.h | 69 ++
drivers/hv/hv.c| 2 +-
drivers/hv/hyperv_vmbus.h | 68
We implement Hyper-V SynIC and synthetic timers in KVM too so there's some
room for code sharing.
Signed-off-by: Vitaly Kuznetsov
---
arch/x86/include/asm/hyperv-tlfs.h | 69 ++
drivers/hv/hv.c| 2 +-
drivers/hv/hyperv_vmbus.h | 68
30 matches
Mail list logo
