Re: [PATCH v2 1/5] pinctrl: mediatek: Check gpio pin number and use binary search in mtk_hw_pin_field_lookup()

2019-09-13 Thread Linus Walleij
On Thu, Sep 12, 2019 at 3:43 PM Linus Walleij wrote: > On Thu, Sep 5, 2019 at 7:00 AM Light Hsieh wrote: > > > v2 is the same as v1 except that commit message is corrected according > > to Linus' comment for v1: > > > > 1. remove Change-Id lines > > 2. correct sysfs as debugfs > > Patches

Re: [PATCH v2 1/5] pinctrl: mediatek: Check gpio pin number and use binary search in mtk_hw_pin_field_lookup()

2019-09-12 Thread Linus Walleij
On Thu, Sep 5, 2019 at 7:00 AM Light Hsieh wrote: > v2 is the same as v1 except that commit message is corrected according > to Linus' comment for v1: > > 1. remove Change-Id lines > 2. correct sysfs as debugfs Patches applied with Sean's ACK. Yours, Linus Walleij

Re: [PATCH v2 1/5] pinctrl: mediatek: Check gpio pin number and use binary search in mtk_hw_pin_field_lookup()

2019-09-11 Thread Sean Wang
Hi Linus, That looks OK to me too Acked-by: Sean Wang On Wed, Sep 11, 2019 at 2:29 AM Linus Walleij wrote: > > On Thu, Sep 5, 2019 at 7:00 AM Light Hsieh wrote: > > > v2 is the same as v1 except that commit message is corrected according > > to Linus' comment for v1: > > > > 1. remove

Re: [PATCH v2 1/5] pinctrl: mediatek: Check gpio pin number and use binary search in mtk_hw_pin_field_lookup()

2019-09-11 Thread Linus Walleij
On Thu, Sep 5, 2019 at 7:00 AM Light Hsieh wrote: > v2 is the same as v1 except that commit message is corrected according > to Linus' comment for v1: > > 1. remove Change-Id lines > 2. correct sysfs as debugfs Looks OK to me, but i need Sean's review on this, Sean? Yours, Linus Walleij

Re: [PATCH v2 1/5] pinctrl: mediatek: Check gpio pin number and use binary search in mtk_hw_pin_field_lookup()

2019-09-05 Thread Light Hsieh
Dear reviewers, v2 is the same as v1 except that commit message is corrected according to Linus' comment for v1: 1. remove Change-Id lines 2. correct sysfs as debugfs On Thu, 2019-09-05 at 13:53 +0800, Light Hsieh wrote: > From: Light Hsieh > > 1. Check if gpio pin number is in valid range

[PATCH v2 1/5] pinctrl: mediatek: Check gpio pin number and use binary search in mtk_hw_pin_field_lookup()

2019-09-04 Thread Light Hsieh
From: Light Hsieh 1. Check if gpio pin number is in valid range to prevent from get invalid pointer 'desc' in the following code: desc = (const struct mtk_pin_desc *)>soc->pins[gpio]; 2. Use binary search in mtk_hw_pin_field_lookup() Modify mtk_hw_pin_field_lookup() to use binary