Re: [PATCH v2 1/6] net: dsa: Use delayed work instead of timer+work for polling

2015-10-30 Thread Andrew Lunn
On Fri, Oct 30, 2015 at 04:44:13PM +0100, Neil Armstrong wrote: > On 10/29/2015 04:28 PM, Andrew Lunn wrote: > >> Is 6060 supported by the 6352 family? It doesn't share any mv88e6xxx > >> code... > > > > It is a totally separate driver. Nothing shared at all.. It is an old > > device, and only do

Re: [PATCH v2 1/6] net: dsa: Use delayed work instead of timer+work for polling

2015-10-30 Thread Neil Armstrong
On 10/29/2015 04:28 PM, Andrew Lunn wrote: >> Is 6060 supported by the 6352 family? It doesn't share any mv88e6xxx >> code... > > It is a totally separate driver. Nothing shared at all.. It is an old > device, and only does 10/100. It could be it is just too different to > support via mv88e6xxx.

Re: [PATCH v2 1/6] net: dsa: Use delayed work instead of timer+work for polling

2015-10-29 Thread Andrew Lunn
> Is 6060 supported by the 6352 family? It doesn't share any mv88e6xxx > code... It is a totally separate driver. Nothing shared at all.. It is an old device, and only does 10/100. It could be it is just too different to support via mv88e6xxx. Andrew -- To unsubscribe from this list: send the

Re: [PATCH v2 1/6] net: dsa: Use delayed work instead of timer+work for polling

2015-10-29 Thread Vivien Didelot
On Oct. Thursday 29 (44) 03:40 PM, Andrew Lunn wrote: > > Thanks for the hint, I will test this, but while reviewing the datasheet, > > the port 5 has no PHY, so must only be used as cpu port. > > Not necessarily. All that is needed is an external phy. Linux does not > care what MDIO bus that phy

Re: [PATCH v2 1/6] net: dsa: Use delayed work instead of timer+work for polling

2015-10-29 Thread Andrew Lunn
> Thanks for the hint, I will test this, but while reviewing the datasheet, > the port 5 has no PHY, so must only be used as cpu port. Not necessarily. All that is needed is an external phy. Linux does not care what MDIO bus that phy hangs off. It could be the same MDIO bus as the switch, or some

Re: [PATCH v2 1/6] net: dsa: Use delayed work instead of timer+work for polling

2015-10-29 Thread Neil Armstrong
On 10/29/2015 02:51 PM, Andrew Lunn wrote: > On Thu, Oct 29, 2015 at 02:22:41PM +0100, Neil Armstrong wrote: > Hi Neil, Frode > > I assume you have see: > > http://permalink.gmane.org/gmane.linux.network/380777 > > which is now in net-next. > > The only driver making use of poll_link is mv88e60

Re: [PATCH v2 1/6] net: dsa: Use delayed work instead of timer+work for polling

2015-10-29 Thread Andrew Lunn
On Thu, Oct 29, 2015 at 02:22:41PM +0100, Neil Armstrong wrote: > Simplifies the code and avoids a crash when removing the > module: > dsa dsa ethmv2 (unregistering): Link is Down > device eth1 left promiscuous mode > Unable to handle kernel paging request at virtual address bacc5cf6 > ... > (

[PATCH v2 1/6] net: dsa: Use delayed work instead of timer+work for polling

2015-10-29 Thread Neil Armstrong
Simplifies the code and avoids a crash when removing the module: dsa dsa ethmv2 (unregistering): Link is Down device eth1 left promiscuous mode Unable to handle kernel paging request at virtual address bacc5cf6 ... (run_timer_softirq) from [] (__do_softirq+0xcc/0x320) (__do_softirq) from [] (