Re: [PATCH v2 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src

2017-03-15 Thread Madhavan Srinivasan
On Wednesday 15 March 2017 05:53 PM, Peter Zijlstra wrote: On Wed, Mar 15, 2017 at 05:20:15PM +1100, Michael Ellerman wrote: I see no implementation; so why are you poking at it. Maddy has posted an implementation of the kernel part for powerpc in patch 2 of this series, but maybe you're

Re: [PATCH v2 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src

2017-03-15 Thread Madhavan Srinivasan
On Wednesday 15 March 2017 05:53 PM, Peter Zijlstra wrote: On Wed, Mar 15, 2017 at 05:20:15PM +1100, Michael Ellerman wrote: I see no implementation; so why are you poking at it. Maddy has posted an implementation of the kernel part for powerpc in patch 2 of this series, but maybe you're

Re: [PATCH v2 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src

2017-03-15 Thread Madhavan Srinivasan
On Wednesday 15 March 2017 11:50 AM, Michael Ellerman wrote: Hi Peter, Peter Zijlstra writes: On Tue, Mar 14, 2017 at 02:31:51PM +0530, Madhavan Srinivasan wrote: Huh? PPC hasn't yet implemented this? Then why are you fixing it? yes, PPC hasn't implemented this

Re: [PATCH v2 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src

2017-03-15 Thread Madhavan Srinivasan
On Wednesday 15 March 2017 11:50 AM, Michael Ellerman wrote: Hi Peter, Peter Zijlstra writes: On Tue, Mar 14, 2017 at 02:31:51PM +0530, Madhavan Srinivasan wrote: Huh? PPC hasn't yet implemented this? Then why are you fixing it? yes, PPC hasn't implemented this (until now). until now

Re: [PATCH v2 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src

2017-03-15 Thread Peter Zijlstra
On Wed, Mar 15, 2017 at 05:20:15PM +1100, Michael Ellerman wrote: > > I see no implementation; so why are you poking at it. > > Maddy has posted an implementation of the kernel part for powerpc in > patch 2 of this series, but maybe you're not on Cc? I am not indeed. That and a completely

Re: [PATCH v2 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src

2017-03-15 Thread Peter Zijlstra
On Wed, Mar 15, 2017 at 05:20:15PM +1100, Michael Ellerman wrote: > > I see no implementation; so why are you poking at it. > > Maddy has posted an implementation of the kernel part for powerpc in > patch 2 of this series, but maybe you're not on Cc? I am not indeed. That and a completely

Re: [PATCH v2 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src

2017-03-15 Thread Michael Ellerman
Hi Peter, Peter Zijlstra writes: > On Tue, Mar 14, 2017 at 02:31:51PM +0530, Madhavan Srinivasan wrote: > >> >Huh? PPC hasn't yet implemented this? Then why are you fixing it? >> >> yes, PPC hasn't implemented this (until now). > > until now where? On powerpc there is

Re: [PATCH v2 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src

2017-03-15 Thread Michael Ellerman
Hi Peter, Peter Zijlstra writes: > On Tue, Mar 14, 2017 at 02:31:51PM +0530, Madhavan Srinivasan wrote: > >> >Huh? PPC hasn't yet implemented this? Then why are you fixing it? >> >> yes, PPC hasn't implemented this (until now). > > until now where? On powerpc there is currently no kernel

Re: [PATCH v2 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src

2017-03-14 Thread Peter Zijlstra
On Tue, Mar 14, 2017 at 02:31:51PM +0530, Madhavan Srinivasan wrote: > >Huh? PPC hasn't yet implemented this? Then why are you fixing it? > > yes, PPC hasn't implemented this (until now). until now where? > And did not understand "Then why are you fixing it?" I see no implementation; so why

Re: [PATCH v2 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src

2017-03-14 Thread Peter Zijlstra
On Tue, Mar 14, 2017 at 02:31:51PM +0530, Madhavan Srinivasan wrote: > >Huh? PPC hasn't yet implemented this? Then why are you fixing it? > > yes, PPC hasn't implemented this (until now). until now where? > And did not understand "Then why are you fixing it?" I see no implementation; so why

Re: [PATCH v2 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src

2017-03-14 Thread Madhavan Srinivasan
On Monday 13 March 2017 06:20 PM, Peter Zijlstra wrote: On Mon, Mar 13, 2017 at 04:45:51PM +0530, Madhavan Srinivasan wrote: - should you not have fixed this in the tool only? This patch effectively breaks ABI on big-endian architectures. IIUC, we are the first BE user for this feature

Re: [PATCH v2 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src

2017-03-14 Thread Madhavan Srinivasan
On Monday 13 March 2017 06:20 PM, Peter Zijlstra wrote: On Mon, Mar 13, 2017 at 04:45:51PM +0530, Madhavan Srinivasan wrote: - should you not have fixed this in the tool only? This patch effectively breaks ABI on big-endian architectures. IIUC, we are the first BE user for this feature

Re: [PATCH v2 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src

2017-03-13 Thread Peter Zijlstra
On Mon, Mar 13, 2017 at 04:45:51PM +0530, Madhavan Srinivasan wrote: > > - should you not have fixed this in the tool only? This patch > >effectively breaks ABI on big-endian architectures. > > IIUC, we are the first BE user for this feature > (Kindly correct me if I am wrong), so

Re: [PATCH v2 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src

2017-03-13 Thread Peter Zijlstra
On Mon, Mar 13, 2017 at 04:45:51PM +0530, Madhavan Srinivasan wrote: > > - should you not have fixed this in the tool only? This patch > >effectively breaks ABI on big-endian architectures. > > IIUC, we are the first BE user for this feature > (Kindly correct me if I am wrong), so

Re: [PATCH v2 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src

2017-03-13 Thread Madhavan Srinivasan
On Tuesday 07 March 2017 03:53 PM, Peter Zijlstra wrote: On Tue, Mar 07, 2017 at 03:28:17PM +0530, Madhavan Srinivasan wrote: On Monday 06 March 2017 04:52 PM, Peter Zijlstra wrote: On Mon, Mar 06, 2017 at 04:13:08PM +0530, Madhavan Srinivasan wrote: From: Sukadev Bhattiprolu

Re: [PATCH v2 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src

2017-03-13 Thread Madhavan Srinivasan
On Tuesday 07 March 2017 03:53 PM, Peter Zijlstra wrote: On Tue, Mar 07, 2017 at 03:28:17PM +0530, Madhavan Srinivasan wrote: On Monday 06 March 2017 04:52 PM, Peter Zijlstra wrote: On Mon, Mar 06, 2017 at 04:13:08PM +0530, Madhavan Srinivasan wrote: From: Sukadev Bhattiprolu

Re: [PATCH v2 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src

2017-03-07 Thread Madhavan Srinivasan
On Monday 06 March 2017 04:52 PM, Peter Zijlstra wrote: On Mon, Mar 06, 2017 at 04:13:08PM +0530, Madhavan Srinivasan wrote: From: Sukadev Bhattiprolu perf_mem_data_src is an union that is initialized via the ->val field and accessed via the bitmap fields. For

Re: [PATCH v2 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src

2017-03-07 Thread Madhavan Srinivasan
On Monday 06 March 2017 04:52 PM, Peter Zijlstra wrote: On Mon, Mar 06, 2017 at 04:13:08PM +0530, Madhavan Srinivasan wrote: From: Sukadev Bhattiprolu perf_mem_data_src is an union that is initialized via the ->val field and accessed via the bitmap fields. For this to work on big endian

Re: [PATCH v2 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src

2017-03-07 Thread Peter Zijlstra
On Tue, Mar 07, 2017 at 03:28:17PM +0530, Madhavan Srinivasan wrote: > > > On Monday 06 March 2017 04:52 PM, Peter Zijlstra wrote: > >On Mon, Mar 06, 2017 at 04:13:08PM +0530, Madhavan Srinivasan wrote: > >>From: Sukadev Bhattiprolu > >> > >>perf_mem_data_src is an

Re: [PATCH v2 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src

2017-03-07 Thread Peter Zijlstra
On Tue, Mar 07, 2017 at 03:28:17PM +0530, Madhavan Srinivasan wrote: > > > On Monday 06 March 2017 04:52 PM, Peter Zijlstra wrote: > >On Mon, Mar 06, 2017 at 04:13:08PM +0530, Madhavan Srinivasan wrote: > >>From: Sukadev Bhattiprolu > >> > >>perf_mem_data_src is an union that is initialized via

Re: [PATCH v2 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src

2017-03-06 Thread Peter Zijlstra
ov; Ingo Molnar; Stephane Eranian; Sukadev Bhattiprolu; > > linuxppc-...@lists.ozlabs.org > > Subject: Re: [PATCH v2 1/6] powerpc/perf: Define big-endian version of > > perf_mem_data_src > > > > On Mon, Mar 06, 2017 at 04:13:08PM +0530, Madhavan Srinivasan wro

Re: [PATCH v2 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src

2017-03-06 Thread Peter Zijlstra
ov; Ingo Molnar; Stephane Eranian; Sukadev Bhattiprolu; > > linuxppc-...@lists.ozlabs.org > > Subject: Re: [PATCH v2 1/6] powerpc/perf: Define big-endian version of > > perf_mem_data_src > > > > On Mon, Mar 06, 2017 at 04:13:08PM +0530, Madhavan Srinivasan wrote:

RE: [PATCH v2 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src

2017-03-06 Thread David Laight
; Subject: Re: [PATCH v2 1/6] powerpc/perf: Define big-endian version of > perf_mem_data_src > > On Mon, Mar 06, 2017 at 04:13:08PM +0530, Madhavan Srinivasan wrote: > > From: Sukadev Bhattiprolu <suka...@linux.vnet.ibm.com> > > > > perf_mem_data_src is an union th

RE: [PATCH v2 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src

2017-03-06 Thread David Laight
; Subject: Re: [PATCH v2 1/6] powerpc/perf: Define big-endian version of > perf_mem_data_src > > On Mon, Mar 06, 2017 at 04:13:08PM +0530, Madhavan Srinivasan wrote: > > From: Sukadev Bhattiprolu > > > > perf_mem_data_src is an union that is initialized via the -&

Re: [PATCH v2 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src

2017-03-06 Thread Peter Zijlstra
On Mon, Mar 06, 2017 at 04:13:08PM +0530, Madhavan Srinivasan wrote: > From: Sukadev Bhattiprolu > > perf_mem_data_src is an union that is initialized via the ->val field > and accessed via the bitmap fields. For this to work on big endian > platforms, we also need a

Re: [PATCH v2 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src

2017-03-06 Thread Peter Zijlstra
On Mon, Mar 06, 2017 at 04:13:08PM +0530, Madhavan Srinivasan wrote: > From: Sukadev Bhattiprolu > > perf_mem_data_src is an union that is initialized via the ->val field > and accessed via the bitmap fields. For this to work on big endian > platforms, we also need a big-endian represenation of

[PATCH v2 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src

2017-03-06 Thread Madhavan Srinivasan
From: Sukadev Bhattiprolu perf_mem_data_src is an union that is initialized via the ->val field and accessed via the bitmap fields. For this to work on big endian platforms, we also need a big-endian represenation of perf_mem_data_src. Cc: Peter Zijlstra

[PATCH v2 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src

2017-03-06 Thread Madhavan Srinivasan
From: Sukadev Bhattiprolu perf_mem_data_src is an union that is initialized via the ->val field and accessed via the bitmap fields. For this to work on big endian platforms, we also need a big-endian represenation of perf_mem_data_src. Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Arnaldo Carvalho