Re: [PATCH v2 10/10] arm64: dts: qcom: msm8916: add nodes for i2c1, i2c3, i2c5

2017-12-15 Thread Bjorn Andersson
On Thu 07 Dec 07:19 PST 2017, Damien Riegel wrote: > Signed-off-by: Damien Riegel Please move pinconf settings into the structure in apq8016-sbc-soc-pins.dtsi (didn't see this when commenting on the previous patch). Apart from this, the patch looks good.

Re: [PATCH v2 10/10] arm64: dts: qcom: msm8916: add nodes for i2c1, i2c3, i2c5

2017-12-15 Thread Bjorn Andersson
On Thu 07 Dec 07:19 PST 2017, Damien Riegel wrote: > Signed-off-by: Damien Riegel Please move pinconf settings into the structure in apq8016-sbc-soc-pins.dtsi (didn't see this when commenting on the previous patch). Apart from this, the patch looks good. Regards, Bjorn > --- > Changes in v2:

[PATCH v2 10/10] arm64: dts: qcom: msm8916: add nodes for i2c1, i2c3, i2c5

2017-12-07 Thread Damien Riegel
Signed-off-by: Damien Riegel --- Changes in v2: - Reworded commit title - Changed size to 0x500 arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 48 ++ arch/arm64/boot/dts/qcom/msm8916-pins.dtsi | 42 ++

[PATCH v2 10/10] arm64: dts: qcom: msm8916: add nodes for i2c1, i2c3, i2c5

2017-12-07 Thread Damien Riegel
Signed-off-by: Damien Riegel --- Changes in v2: - Reworded commit title - Changed size to 0x500 arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 48 ++ arch/arm64/boot/dts/qcom/msm8916-pins.dtsi | 42 ++ arch/arm64/boot/dts/qcom/msm8916.dtsi