Re: [PATCH v2 10/14] serial: pic32_uart: Add PIC32 UART driver

2016-01-06 Thread One Thousand Gnomes
On Wed, 6 Jan 2016 22:00:43 + wrote: > On 01/05/2016 03:50 PM, One Thousand Gnomes wrote: > > > >> +#define PIC32_SDEV_NAME "ttyS" > >> +#define PIC32_SDEV_MAJOR TTY_MAJOR > >> +#define PIC32_SDEV_MINOR 64 > > > > No. Same goes for you as every one of the forty other people a

Re: [PATCH v2 10/14] serial: pic32_uart: Add PIC32 UART driver

2016-01-06 Thread Paul.Thacker
On 01/05/2016 03:50 PM, One Thousand Gnomes wrote: > >> +#define PIC32_SDEV_NAME "ttyS" >> +#define PIC32_SDEV_MAJORTTY_MAJOR >> +#define PIC32_SDEV_MINOR64 > > No. Same goes for you as every one of the forty other people a year who > try and claim their console is ttyS. If

Re: [PATCH v2 10/14] serial: pic32_uart: Add PIC32 UART driver

2016-01-06 Thread Paul.Thacker
On 01/05/2016 03:50 PM, One Thousand Gnomes wrote: > >> +#define PIC32_SDEV_NAME "ttyS" >> +#define PIC32_SDEV_MAJORTTY_MAJOR >> +#define PIC32_SDEV_MINOR64 > > No. Same goes for you as every one of the forty other people a year who > try and claim their console is ttyS. If

Re: [PATCH v2 10/14] serial: pic32_uart: Add PIC32 UART driver

2016-01-06 Thread One Thousand Gnomes
On Wed, 6 Jan 2016 22:00:43 + wrote: > On 01/05/2016 03:50 PM, One Thousand Gnomes wrote: > > > >> +#define PIC32_SDEV_NAME "ttyS" > >> +#define PIC32_SDEV_MAJOR TTY_MAJOR > >> +#define PIC32_SDEV_MINOR 64 > > > > No. Same goes for you as every one of

Re: [PATCH v2 10/14] serial: pic32_uart: Add PIC32 UART driver

2016-01-05 Thread One Thousand Gnomes
> +#define PIC32_SDEV_NAME "ttyS" > +#define PIC32_SDEV_MAJOR TTY_MAJOR > +#define PIC32_SDEV_MINOR 64 No. Same goes for you as every one of the forty other people a year who try and claim their console is ttyS. If it's not an 8250 it isn't. ttyS is the 8250, use dynamic

Re: [PATCH v2 10/14] serial: pic32_uart: Add PIC32 UART driver

2016-01-05 Thread Paul.Thacker
On 12/20/2015 09:14 AM, Andy Shevchenko wrote: > On Tue, Dec 15, 2015 at 12:42 AM, Joshua Henderson > wrote: >> From: Andrei Pistirica >> >> This adds UART and a serial console driver for Microchip PIC32 class >> devices. >> >> Signed-off-by: Andrei Pistirica >> Signed-off-by: Joshua Henderson

Re: [PATCH v2 10/14] serial: pic32_uart: Add PIC32 UART driver

2016-01-05 Thread Paul.Thacker
On 12/20/2015 09:14 AM, Andy Shevchenko wrote: > On Tue, Dec 15, 2015 at 12:42 AM, Joshua Henderson > wrote: >> From: Andrei Pistirica >> >> This adds UART and a serial console driver for Microchip PIC32 class >> devices. >> >>

Re: [PATCH v2 10/14] serial: pic32_uart: Add PIC32 UART driver

2016-01-05 Thread One Thousand Gnomes
> +#define PIC32_SDEV_NAME "ttyS" > +#define PIC32_SDEV_MAJOR TTY_MAJOR > +#define PIC32_SDEV_MINOR 64 No. Same goes for you as every one of the forty other people a year who try and claim their console is ttyS. If it's not an 8250 it isn't. ttyS is the 8250, use dynamic

Re: [PATCH v2 10/14] serial: pic32_uart: Add PIC32 UART driver

2015-12-20 Thread Andy Shevchenko
On Tue, Dec 15, 2015 at 12:42 AM, Joshua Henderson wrote: > From: Andrei Pistirica > > This adds UART and a serial console driver for Microchip PIC32 class > devices. > > Signed-off-by: Andrei Pistirica > Signed-off-by: Joshua Henderson > Cc: Ralf Baechle > --- > drivers/tty/serial/Kconfig

Re: [PATCH v2 10/14] serial: pic32_uart: Add PIC32 UART driver

2015-12-20 Thread Andy Shevchenko
On Tue, Dec 15, 2015 at 12:42 AM, Joshua Henderson wrote: > From: Andrei Pistirica > > This adds UART and a serial console driver for Microchip PIC32 class > devices. > > Signed-off-by: Andrei Pistirica

[PATCH v2 10/14] serial: pic32_uart: Add PIC32 UART driver

2015-12-14 Thread Joshua Henderson
From: Andrei Pistirica This adds UART and a serial console driver for Microchip PIC32 class devices. Signed-off-by: Andrei Pistirica Signed-off-by: Joshua Henderson Cc: Ralf Baechle --- drivers/tty/serial/Kconfig | 21 + drivers/tty/serial/Makefile |1 +

[PATCH v2 10/14] serial: pic32_uart: Add PIC32 UART driver

2015-12-14 Thread Joshua Henderson
From: Andrei Pistirica This adds UART and a serial console driver for Microchip PIC32 class devices. Signed-off-by: Andrei Pistirica Signed-off-by: Joshua Henderson Cc: Ralf Baechle