Re: [PATCH v2 10/14] tracing: Document trace_marker triggers

2018-05-16 Thread Steven Rostedt
On Wed, 16 May 2018 10:22:27 -0500 Tom Zanussi wrote: > Sure, but noticed in the new version you just posted, that this line is > still in there for your second example: > > + # echo > '!hist:keys=common_pid:vals=hitcount:lat=common_timestamp.usecs-$ts0:sort=hitcount:size=2048:clock=global:onma

Re: [PATCH v2 10/14] tracing: Document trace_marker triggers

2018-05-16 Thread Tom Zanussi
Hi Steve, On Wed, 2018-05-16 at 09:55 -0400, Steven Rostedt wrote: > On Mon, 14 May 2018 16:47:07 -0500 > Tom Zanussi wrote: > > > Hi Steve, > > > > This is a nice new event feature - thanks for doing it! Some minor typo > > comments below.. > > Can I get an Acked-by from you? > > > > > >

Re: [PATCH v2 10/14] tracing: Document trace_marker triggers

2018-05-16 Thread Steven Rostedt
On Mon, 14 May 2018 16:47:07 -0500 Tom Zanussi wrote: > Hi Steve, > > This is a nice new event feature - thanks for doing it! Some minor typo > comments below.. Can I get an Acked-by from you? > > +3. User space creating a trigger > > + > > + > > +Writing int

Re: [PATCH v2 10/14] tracing: Document trace_marker triggers

2018-05-14 Thread Tom Zanussi
Hi Steve, This is a nice new event feature - thanks for doing it! Some minor typo comments below.. On Mon, 2018-05-14 at 16:58 -0400, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > Add documentation and an example on how to use trace_marker triggers. > > Signed-off-by: Steven Ros

[PATCH v2 10/14] tracing: Document trace_marker triggers

2018-05-14 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" Add documentation and an example on how to use trace_marker triggers. Signed-off-by: Steven Rostedt (VMware) --- Documentation/trace/events.rst| 6 +- Documentation/trace/ftrace.rst| 5 + Documentation/trace/histogram.txt | 546 ++