Re: [PATCH v2 11/11] HID: hid-multitouch: get rid of usbhid depedency for general path

2012-11-05 Thread Benjamin Tissoires
Hi Henrik, grrr damn new gmail interface, I clicked on the wrong button. sorry for the noise. On Mon, Nov 5, 2012 at 2:28 PM, Benjamin Tissoires wrote: > Hi Henrik, > > On Mon, Nov 5, 2012 at 1:57 PM, Henrik Rydberg wrote: >> Hi Benjamin, >> >>> >> This patch factorizes the hid

Re: [PATCH v2 11/11] HID: hid-multitouch: get rid of usbhid depedency for general path

2012-11-05 Thread Benjamin Tissoires
Hi Henrik, On Mon, Nov 5, 2012 at 1:57 PM, Henrik Rydberg wrote: > Hi Benjamin, > >> >> This patch factorizes the hid set_feature command by using >> >> hid_device->hid_output_raw_report instead of direclty relying on >> >> usbhid. This makes the driver usb independant. >> >> >> >> However I

Re: [PATCH v2 11/11] HID: hid-multitouch: get rid of usbhid depedency for general path

2012-11-05 Thread Henrik Rydberg
Hi Benjamin, > >> This patch factorizes the hid set_feature command by using > >> hid_device->hid_output_raw_report instead of direclty relying on > >> usbhid. This makes the driver usb independant. > >> > >> However I still can't remove the 2 usb related headers because the > >> function

Re: [PATCH v2 11/11] HID: hid-multitouch: get rid of usbhid depedency for general path

2012-11-05 Thread Henrik Rydberg
Hi Benjamin, This patch factorizes the hid set_feature command by using hid_device-hid_output_raw_report instead of direclty relying on usbhid. This makes the driver usb independant. However I still can't remove the 2 usb related headers because the function mt_resume has a specific

Re: [PATCH v2 11/11] HID: hid-multitouch: get rid of usbhid depedency for general path

2012-11-05 Thread Benjamin Tissoires
Hi Henrik, On Mon, Nov 5, 2012 at 1:57 PM, Henrik Rydberg rydb...@euromail.se wrote: Hi Benjamin, This patch factorizes the hid set_feature command by using hid_device-hid_output_raw_report instead of direclty relying on usbhid. This makes the driver usb independant. However I still

Re: [PATCH v2 11/11] HID: hid-multitouch: get rid of usbhid depedency for general path

2012-11-05 Thread Benjamin Tissoires
Hi Henrik, grrr damn new gmail interface, I clicked on the wrong button. sorry for the noise. On Mon, Nov 5, 2012 at 2:28 PM, Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: Hi Henrik, On Mon, Nov 5, 2012 at 1:57 PM, Henrik Rydberg rydb...@euromail.se wrote: Hi Benjamin, This

Re: [PATCH v2 11/11] HID: hid-multitouch: get rid of usbhid depedency for general path

2012-10-31 Thread Henrik Rydberg
> > In my drawer, I have a patchset that aims to remove all usbhid > > dependence, from all the drivers. Perhaps the attached patch is > > something to consider here? > > yep, removing usbhid dependencies is a good thing. > See my review below :) > > > From

Re: [PATCH v2 11/11] HID: hid-multitouch: get rid of usbhid depedency for general path

2012-10-31 Thread Henrik Rydberg
In my drawer, I have a patchset that aims to remove all usbhid dependence, from all the drivers. Perhaps the attached patch is something to consider here? yep, removing usbhid dependencies is a good thing. See my review below :) From 5d9a791e0a9e41bcea0fcb286e2849b403675f37 Mon Sep

Re: [PATCH v2 11/11] HID: hid-multitouch: get rid of usbhid depedency for general path

2012-10-30 Thread Benjamin Tissoires
Hi Henrik, On Mon, Oct 29, 2012 at 11:57 PM, Henrik Rydberg wrote: > Hi Benjamin, > >> This patch factorizes the hid set_feature command by using >> hid_device->hid_output_raw_report instead of direclty relying on >> usbhid. This makes the driver usb independant. >> >> However I still can't

Re: [PATCH v2 11/11] HID: hid-multitouch: get rid of usbhid depedency for general path

2012-10-30 Thread Benjamin Tissoires
Hi Henrik, On Mon, Oct 29, 2012 at 11:57 PM, Henrik Rydberg rydb...@euromail.se wrote: Hi Benjamin, This patch factorizes the hid set_feature command by using hid_device-hid_output_raw_report instead of direclty relying on usbhid. This makes the driver usb independant. However I still

Re: [PATCH v2 11/11] HID: hid-multitouch: get rid of usbhid depedency for general path

2012-10-29 Thread Henrik Rydberg
Hi Benjamin, > This patch factorizes the hid set_feature command by using > hid_device->hid_output_raw_report instead of direclty relying on > usbhid. This makes the driver usb independant. > > However I still can't remove the 2 usb related headers because the > function mt_resume has a specific

Re: [PATCH v2 11/11] HID: hid-multitouch: get rid of usbhid depedency for general path

2012-10-29 Thread Henrik Rydberg
Hi Benjamin, This patch factorizes the hid set_feature command by using hid_device-hid_output_raw_report instead of direclty relying on usbhid. This makes the driver usb independant. However I still can't remove the 2 usb related headers because the function mt_resume has a specific patch