Re: [PATCH v2 11/13] iommu/rockchip: Use OF_IOMMU to attach devices automatically

On 01/17/2018 03:30 PM, Tomasz Figa wrote: >but it's possible the probe failed after calling iommu_device_set_fwnode, so >i'll try to add some checks here, and maybe adjust probe() to prevent it >too. I think iommu_device_set_fwnode() is not enough for of_iommu_xlate() to find the IOMMU. The

Re: [PATCH v2 11/13] iommu/rockchip: Use OF_IOMMU to attach devices automatically

On 01/17/2018 03:30 PM, Tomasz Figa wrote: >but it's possible the probe failed after calling iommu_device_set_fwnode, so >i'll try to add some checks here, and maybe adjust probe() to prevent it >too. I think iommu_device_set_fwnode() is not enough for of_iommu_xlate() to find the IOMMU. The

Re: [PATCH v2 11/13] iommu/rockchip: Use OF_IOMMU to attach devices automatically

On Wed, Jan 17, 2018 at 4:20 PM, JeffyChen wrote: > Hi Tomasz, > > Thanks for your reply. > > > On 01/17/2018 01:44 PM, Tomasz Figa wrote: >> >> On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen >> wrote: >>> >>> Converts the rockchip-iommu driver

Re: [PATCH v2 11/13] iommu/rockchip: Use OF_IOMMU to attach devices automatically

On Wed, Jan 17, 2018 at 4:20 PM, JeffyChen wrote: > Hi Tomasz, > > Thanks for your reply. > > > On 01/17/2018 01:44 PM, Tomasz Figa wrote: >> >> On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen >> wrote: >>> >>> Converts the rockchip-iommu driver to use the OF_IOMMU infrastructure, >>> which allows

Re: [PATCH v2 11/13] iommu/rockchip: Use OF_IOMMU to attach devices automatically

On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen wrote: > Converts the rockchip-iommu driver to use the OF_IOMMU infrastructure, > which allows attaching master devices to their IOMMUs automatically > according to DT properties. > > Signed-off-by: Jeffy Chen

Re: [PATCH v2 11/13] iommu/rockchip: Use OF_IOMMU to attach devices automatically

On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen wrote: > Converts the rockchip-iommu driver to use the OF_IOMMU infrastructure, > which allows attaching master devices to their IOMMUs automatically > according to DT properties. > > Signed-off-by: Jeffy Chen > --- > > Changes in v2: None > >

[PATCH v2 11/13] iommu/rockchip: Use OF_IOMMU to attach devices automatically

Converts the rockchip-iommu driver to use the OF_IOMMU infrastructure, which allows attaching master devices to their IOMMUs automatically according to DT properties. Signed-off-by: Jeffy Chen --- Changes in v2: None drivers/iommu/rockchip-iommu.c | 116

[PATCH v2 11/13] iommu/rockchip: Use OF_IOMMU to attach devices automatically

Converts the rockchip-iommu driver to use the OF_IOMMU infrastructure, which allows attaching master devices to their IOMMUs automatically according to DT properties. Signed-off-by: Jeffy Chen --- Changes in v2: None drivers/iommu/rockchip-iommu.c | 116