Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-19 Thread Mark Brown
On Wed, Feb 19, 2014 at 03:19:00PM +0100, Krzysztof Kozlowski wrote: > As I understand the suspend mode (correct me if I'm wrong), the > regulator core during suspend to mem: > 1. Calls suspend_set_state(). > 2. rstate->disabled is true so the ops->set_suspend_disable() is called. > 3. The

Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-19 Thread Krzysztof Kozlowski
On Wed, 2014-02-19 at 13:08 +0900, Mark Brown wrote: > On Tue, Feb 18, 2014 at 09:12:09AM +0100, Krzysztof Kozlowski wrote: > > On Tue, 2014-02-18 at 09:35 +0900, Mark Brown wrote: > > > > I don't understand the above? Are you saying that suspend mode actually > > > turns off the regulator or

Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-19 Thread Mark Brown
On Wed, Feb 19, 2014 at 11:09:40AM +0100, Krzysztof Kozlowski wrote: > I can't only find a way to set this from DTS. There are no bindings for > regulation_constraints->state_{disk,mem,standby}. > Should the driver set manually after obtaining init_data from DTS? Someone should work out a

Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-19 Thread Krzysztof Kozlowski
On Wed, 2014-02-19 at 13:08 +0900, Mark Brown wrote: > On Tue, Feb 18, 2014 at 09:12:09AM +0100, Krzysztof Kozlowski wrote: > > On Tue, 2014-02-18 at 09:35 +0900, Mark Brown wrote: > > > > I don't understand the above? Are you saying that suspend mode actually > > > turns off the regulator or

Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-19 Thread Krzysztof Kozlowski
On Wed, 2014-02-19 at 13:08 +0900, Mark Brown wrote: On Tue, Feb 18, 2014 at 09:12:09AM +0100, Krzysztof Kozlowski wrote: On Tue, 2014-02-18 at 09:35 +0900, Mark Brown wrote: I don't understand the above? Are you saying that suspend mode actually turns off the regulator or something

Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-19 Thread Mark Brown
On Wed, Feb 19, 2014 at 11:09:40AM +0100, Krzysztof Kozlowski wrote: I can't only find a way to set this from DTS. There are no bindings for regulation_constraints-state_{disk,mem,standby}. Should the driver set manually after obtaining init_data from DTS? Someone should work out a suitably

Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-19 Thread Krzysztof Kozlowski
On Wed, 2014-02-19 at 13:08 +0900, Mark Brown wrote: On Tue, Feb 18, 2014 at 09:12:09AM +0100, Krzysztof Kozlowski wrote: On Tue, 2014-02-18 at 09:35 +0900, Mark Brown wrote: I don't understand the above? Are you saying that suspend mode actually turns off the regulator or something

Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-19 Thread Mark Brown
On Wed, Feb 19, 2014 at 03:19:00PM +0100, Krzysztof Kozlowski wrote: As I understand the suspend mode (correct me if I'm wrong), the regulator core during suspend to mem: 1. Calls suspend_set_state(). 2. rstate-disabled is true so the ops-set_suspend_disable() is called. 3. The

Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-18 Thread Mark Brown
On Tue, Feb 18, 2014 at 09:12:09AM +0100, Krzysztof Kozlowski wrote: > On Tue, 2014-02-18 at 09:35 +0900, Mark Brown wrote: > > I don't understand the above? Are you saying that suspend mode actually > > turns off the regulator or something else? If it's a separate setting > > for suspend mode

Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-18 Thread Krzysztof Kozlowski
On Tue, 2014-02-18 at 09:35 +0900, Mark Brown wrote: > On Mon, Feb 17, 2014 at 09:07:34AM +0100, Krzysztof Kozlowski wrote: > > > The low power maps to REGULATOR_MODE_IDLE or REGULATOR_MODE_STANDBY > > (depending on the understanding of "more efficient" and "most efficient" > > for light loads).

Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-18 Thread Krzysztof Kozlowski
On Tue, 2014-02-18 at 09:35 +0900, Mark Brown wrote: On Mon, Feb 17, 2014 at 09:07:34AM +0100, Krzysztof Kozlowski wrote: The low power maps to REGULATOR_MODE_IDLE or REGULATOR_MODE_STANDBY (depending on the understanding of more efficient and most efficient for light loads). However the

Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-18 Thread Mark Brown
On Tue, Feb 18, 2014 at 09:12:09AM +0100, Krzysztof Kozlowski wrote: On Tue, 2014-02-18 at 09:35 +0900, Mark Brown wrote: I don't understand the above? Are you saying that suspend mode actually turns off the regulator or something else? If it's a separate setting for suspend mode then it

Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-17 Thread Mark Brown
On Mon, Feb 17, 2014 at 09:07:34AM +0100, Krzysztof Kozlowski wrote: > The low power maps to REGULATOR_MODE_IDLE or REGULATOR_MODE_STANDBY > (depending on the understanding of "more efficient" and "most efficient" > for light loads). However the suspend mode of S5M8767/S2MPS14 is more > like

Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-17 Thread Krzysztof Kozlowski
On Fri, 2014-02-14 at 20:59 +, Mark Brown wrote: > On Fri, Feb 14, 2014 at 09:15:12AM +0100, Krzysztof Kozlowski wrote: > > > My initial idea was to do this similarly to the S5M8767 regulator (where > > there is also 4th mode: low power). The presence of GPIO in DTS can > > simplify the

Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-17 Thread Krzysztof Kozlowski
On Fri, 2014-02-14 at 21:05 +, Mark Brown wrote: > On Fri, Feb 14, 2014 at 02:05:56PM +0100, Krzysztof Kozlowski wrote: > > On Thu, 2014-02-13 at 17:46 +0530, Yadwinder Singh Brar wrote: > > > - low-power mode; > > - low-power mode controlled by PWREN; > > Although not all are present for

Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-17 Thread Krzysztof Kozlowski
On Fri, 2014-02-14 at 21:05 +, Mark Brown wrote: On Fri, Feb 14, 2014 at 02:05:56PM +0100, Krzysztof Kozlowski wrote: On Thu, 2014-02-13 at 17:46 +0530, Yadwinder Singh Brar wrote: - low-power mode; - low-power mode controlled by PWREN; Although not all are present for each

Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-17 Thread Krzysztof Kozlowski
On Fri, 2014-02-14 at 20:59 +, Mark Brown wrote: On Fri, Feb 14, 2014 at 09:15:12AM +0100, Krzysztof Kozlowski wrote: My initial idea was to do this similarly to the S5M8767 regulator (where there is also 4th mode: low power). The presence of GPIO in DTS can simplify the bindings but

Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-17 Thread Mark Brown
On Mon, Feb 17, 2014 at 09:07:34AM +0100, Krzysztof Kozlowski wrote: The low power maps to REGULATOR_MODE_IDLE or REGULATOR_MODE_STANDBY (depending on the understanding of more efficient and most efficient for light loads). However the suspend mode of S5M8767/S2MPS14 is more like automatic

Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-15 Thread Mark Brown
On Fri, Feb 14, 2014 at 02:05:56PM +0100, Krzysztof Kozlowski wrote: > On Thu, 2014-02-13 at 17:46 +0530, Yadwinder Singh Brar wrote: > - low-power mode; > - low-power mode controlled by PWREN; > Although not all are present for each regulator. What exactly is low power mode and how does it

Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-15 Thread Mark Brown
On Fri, Feb 14, 2014 at 09:15:12AM +0100, Krzysztof Kozlowski wrote: > My initial idea was to do this similarly to the S5M8767 regulator (where > there is also 4th mode: low power). The presence of GPIO in DTS can > simplify the bindings but on the other hand it wouldn't be compatible > with

Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-15 Thread Mark Brown
On Fri, Feb 14, 2014 at 09:15:12AM +0100, Krzysztof Kozlowski wrote: My initial idea was to do this similarly to the S5M8767 regulator (where there is also 4th mode: low power). The presence of GPIO in DTS can simplify the bindings but on the other hand it wouldn't be compatible with S5M8767

Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-15 Thread Mark Brown
On Fri, Feb 14, 2014 at 02:05:56PM +0100, Krzysztof Kozlowski wrote: On Thu, 2014-02-13 at 17:46 +0530, Yadwinder Singh Brar wrote: - low-power mode; - low-power mode controlled by PWREN; Although not all are present for each regulator. What exactly is low power mode and how does it

Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-14 Thread Krzysztof Kozlowski
On Thu, 2014-02-13 at 17:46 +0530, Yadwinder Singh Brar wrote: > Hi, > > On Thu, Feb 13, 2014 at 2:44 PM, Krzysztof Kozlowski > wrote: > > S2MPS11/S2MPS14 regulators support different modes of operation: > > - Always off; > > - On/Off controlled by pin/GPIO (PWREN/LDOEN/EMMCEN); > > -

Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-14 Thread Krzysztof Kozlowski
On Thu, 2014-02-13 at 19:28 +, Mark Brown wrote: > On Thu, Feb 13, 2014 at 10:14:04AM +0100, Krzysztof Kozlowski wrote: > > S2MPS11/S2MPS14 regulators support different modes of operation: > > - Always off; > > - On/Off controlled by pin/GPIO (PWREN/LDOEN/EMMCEN); > > - Always on; > > This

Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-14 Thread Krzysztof Kozlowski
On Thu, 2014-02-13 at 19:28 +, Mark Brown wrote: On Thu, Feb 13, 2014 at 10:14:04AM +0100, Krzysztof Kozlowski wrote: S2MPS11/S2MPS14 regulators support different modes of operation: - Always off; - On/Off controlled by pin/GPIO (PWREN/LDOEN/EMMCEN); - Always on; This is very

Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-14 Thread Krzysztof Kozlowski
On Thu, 2014-02-13 at 17:46 +0530, Yadwinder Singh Brar wrote: Hi, On Thu, Feb 13, 2014 at 2:44 PM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: S2MPS11/S2MPS14 regulators support different modes of operation: - Always off; - On/Off controlled by pin/GPIO (PWREN/LDOEN/EMMCEN);

Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-13 Thread Mark Brown
On Thu, Feb 13, 2014 at 10:14:04AM +0100, Krzysztof Kozlowski wrote: > S2MPS11/S2MPS14 regulators support different modes of operation: > - Always off; > - On/Off controlled by pin/GPIO (PWREN/LDOEN/EMMCEN); > - Always on; > This is very similar to S5M8767 regulator driver which also supports >

Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-13 Thread Krzysztof Kozlowski
On Thu, 2014-02-13 at 12:43 +, Lee Jones wrote: > > S2MPS11/S2MPS14 regulators support different modes of operation: > > - Always off; > > - On/Off controlled by pin/GPIO (PWREN/LDOEN/EMMCEN); > > - Always on; > > This is very similar to S5M8767 regulator driver which also supports > >

Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-13 Thread Lee Jones
> S2MPS11/S2MPS14 regulators support different modes of operation: > - Always off; > - On/Off controlled by pin/GPIO (PWREN/LDOEN/EMMCEN); > - Always on; > This is very similar to S5M8767 regulator driver which also supports > opmodes (although S5M8767 have also low-power mode). > > This patch

Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-13 Thread Yadwinder Singh Brar
Hi, On Thu, Feb 13, 2014 at 2:44 PM, Krzysztof Kozlowski wrote: > S2MPS11/S2MPS14 regulators support different modes of operation: > - Always off; > - On/Off controlled by pin/GPIO (PWREN/LDOEN/EMMCEN); > - Always on; > This is very similar to S5M8767 regulator driver which also supports >

[PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-13 Thread Krzysztof Kozlowski
S2MPS11/S2MPS14 regulators support different modes of operation: - Always off; - On/Off controlled by pin/GPIO (PWREN/LDOEN/EMMCEN); - Always on; This is very similar to S5M8767 regulator driver which also supports opmodes (although S5M8767 have also low-power mode). This patch adds parsing

[PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-13 Thread Krzysztof Kozlowski
S2MPS11/S2MPS14 regulators support different modes of operation: - Always off; - On/Off controlled by pin/GPIO (PWREN/LDOEN/EMMCEN); - Always on; This is very similar to S5M8767 regulator driver which also supports opmodes (although S5M8767 have also low-power mode). This patch adds parsing

Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-13 Thread Yadwinder Singh Brar
Hi, On Thu, Feb 13, 2014 at 2:44 PM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: S2MPS11/S2MPS14 regulators support different modes of operation: - Always off; - On/Off controlled by pin/GPIO (PWREN/LDOEN/EMMCEN); - Always on; This is very similar to S5M8767 regulator driver which

Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-13 Thread Lee Jones
S2MPS11/S2MPS14 regulators support different modes of operation: - Always off; - On/Off controlled by pin/GPIO (PWREN/LDOEN/EMMCEN); - Always on; This is very similar to S5M8767 regulator driver which also supports opmodes (although S5M8767 have also low-power mode). This patch adds

Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-13 Thread Krzysztof Kozlowski
On Thu, 2014-02-13 at 12:43 +, Lee Jones wrote: S2MPS11/S2MPS14 regulators support different modes of operation: - Always off; - On/Off controlled by pin/GPIO (PWREN/LDOEN/EMMCEN); - Always on; This is very similar to S5M8767 regulator driver which also supports opmodes

Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-13 Thread Mark Brown
On Thu, Feb 13, 2014 at 10:14:04AM +0100, Krzysztof Kozlowski wrote: S2MPS11/S2MPS14 regulators support different modes of operation: - Always off; - On/Off controlled by pin/GPIO (PWREN/LDOEN/EMMCEN); - Always on; This is very similar to S5M8767 regulator driver which also supports