RE: [PATCH v2 12/14] mmc: sdhci-pic32: Add PIC32 SDHCI host controller driver

On 12/16/2015 3:48 AM, Ulf Hansson wrote: > > [...] > > > +static int pic32_sdhci_probe(struct platform_device *pdev) { > > + struct device *dev = >dev; > > + struct sdhci_host *host; > > + struct resource *iomem; > > + struct pic32_sdhci_pdata *sdhci_pdata; > > +

RE: [PATCH v2 12/14] mmc: sdhci-pic32: Add PIC32 SDHCI host controller driver

On 12/16/2015 3:48 AM, Ulf Hansson wrote: > > [...] > > > +static int pic32_sdhci_probe(struct platform_device *pdev) { > > + struct device *dev = >dev; > > + struct sdhci_host *host; > > + struct resource *iomem; > > + struct pic32_sdhci_pdata *sdhci_pdata; > > +

RE: [PATCH v2 12/14] mmc: sdhci-pic32: Add PIC32 SDHCI host controller driver

On 12/14/2015 5:33 PM, Andy Green wrote: > Hi... looks good, just some small general comments. > > On 15 December 2015 at 06:42, Joshua Henderson > wrote: > > From: Andrei Pistirica > > > > This driver supports the SDHCI host controller found on a PIC32. > > > > Signed-off-by: Andrei Pistirica

Re: [PATCH v2 12/14] mmc: sdhci-pic32: Add PIC32 SDHCI host controller driver

[...] > +static int pic32_sdhci_probe(struct platform_device *pdev) > +{ > + struct device *dev = >dev; > + struct sdhci_host *host; > + struct resource *iomem; > + struct pic32_sdhci_pdata *sdhci_pdata; > + struct pic32_sdhci_platform_data *plat_data; > +

RE: [PATCH v2 12/14] mmc: sdhci-pic32: Add PIC32 SDHCI host controller driver

On 12/14/2015 5:33 PM, Andy Green wrote: > Hi... looks good, just some small general comments. > > On 15 December 2015 at 06:42, Joshua Henderson > wrote: > > From: Andrei Pistirica > > > > This driver supports the SDHCI host

Re: [PATCH v2 12/14] mmc: sdhci-pic32: Add PIC32 SDHCI host controller driver

[...] > +static int pic32_sdhci_probe(struct platform_device *pdev) > +{ > + struct device *dev = >dev; > + struct sdhci_host *host; > + struct resource *iomem; > + struct pic32_sdhci_pdata *sdhci_pdata; > + struct pic32_sdhci_platform_data *plat_data; > +

Re: [PATCH v2 12/14] mmc: sdhci-pic32: Add PIC32 SDHCI host controller driver

Hi... looks good, just some small general comments. On 15 December 2015 at 06:42, Joshua Henderson wrote: > From: Andrei Pistirica > > This driver supports the SDHCI host controller found on a PIC32. > > Signed-off-by: Andrei Pistirica > Signed-off-by: Joshua Henderson > Cc: Ralf Baechle >

[PATCH v2 12/14] mmc: sdhci-pic32: Add PIC32 SDHCI host controller driver

From: Andrei Pistirica This driver supports the SDHCI host controller found on a PIC32. Signed-off-by: Andrei Pistirica Signed-off-by: Joshua Henderson Cc: Ralf Baechle --- drivers/mmc/host/Kconfig | 11 ++ drivers/mmc/host/Makefile |1 + drivers/mmc/host/sdhci-pic32.c |

Re: [PATCH v2 12/14] mmc: sdhci-pic32: Add PIC32 SDHCI host controller driver

Hi... looks good, just some small general comments. On 15 December 2015 at 06:42, Joshua Henderson wrote: > From: Andrei Pistirica > > This driver supports the SDHCI host controller found on a PIC32. > > Signed-off-by: Andrei

[PATCH v2 12/14] mmc: sdhci-pic32: Add PIC32 SDHCI host controller driver

From: Andrei Pistirica This driver supports the SDHCI host controller found on a PIC32. Signed-off-by: Andrei Pistirica Signed-off-by: Joshua Henderson Cc: Ralf Baechle ---