Re: [alsa-devel] [PATCH v2 2/2] ASoC: rockchip: i2s: add support for grabbing output clock to codec

2014-12-03 Thread Sonny Rao
On Wed, Dec 3, 2014 at 3:22 PM, Dylan Reid wrote: > On Wed, Dec 3, 2014 at 3:03 PM, Sonny Rao wrote: >> On Wed, Dec 3, 2014 at 12:03 PM, Mark Brown wrote: >>> On Wed, Dec 03, 2014 at 11:38:13AM -0800, Sonny Rao wrote: On Wed, Dec 3, 2014 at 11:20 AM, Mark Brown wrote: >>> > I would

Re: [alsa-devel] [PATCH v2 2/2] ASoC: rockchip: i2s: add support for grabbing output clock to codec

2014-12-03 Thread Dylan Reid
On Wed, Dec 3, 2014 at 3:03 PM, Sonny Rao wrote: > On Wed, Dec 3, 2014 at 12:03 PM, Mark Brown wrote: >> On Wed, Dec 03, 2014 at 11:38:13AM -0800, Sonny Rao wrote: >>> On Wed, Dec 3, 2014 at 11:20 AM, Mark Brown wrote: >> >>> > I would expect that the clock for the CODEC should be managed by

Re: [PATCH v2 2/2] ASoC: rockchip: i2s: add support for grabbing output clock to codec

2014-12-03 Thread Sonny Rao
On Wed, Dec 3, 2014 at 12:03 PM, Mark Brown wrote: > On Wed, Dec 03, 2014 at 11:38:13AM -0800, Sonny Rao wrote: >> On Wed, Dec 3, 2014 at 11:20 AM, Mark Brown wrote: > >> > I would expect that the clock for the CODEC should be managed by the >> > CODEC if at all possible - that seems more

Re: [PATCH v2 2/2] ASoC: rockchip: i2s: add support for grabbing output clock to codec

2014-12-03 Thread Mark Brown
On Wed, Dec 03, 2014 at 11:38:13AM -0800, Sonny Rao wrote: > On Wed, Dec 3, 2014 at 11:20 AM, Mark Brown wrote: > > I would expect that the clock for the CODEC should be managed by the > > CODEC if at all possible - that seems more logical than having the CPU > > I2S controller request and

Re: [PATCH v2 2/2] ASoC: rockchip: i2s: add support for grabbing output clock to codec

2014-12-03 Thread Sonny Rao
On Wed, Dec 3, 2014 at 11:20 AM, Mark Brown wrote: > On Wed, Dec 03, 2014 at 03:18:38PM +0800, Jianqun Xu wrote: >> From: Sonny Rao >> >> We need to claim the clock which is driving the codec so that when we enable >> clock gating, we continue to clock the codec when needed. I make this an >>

Re: [PATCH v2 2/2] ASoC: rockchip: i2s: add support for grabbing output clock to codec

2014-12-03 Thread Mark Brown
On Wed, Dec 03, 2014 at 03:18:38PM +0800, Jianqun Xu wrote: > From: Sonny Rao > > We need to claim the clock which is driving the codec so that when we enable > clock gating, we continue to clock the codec when needed. I make this an > optional clock since there might be some applications where

Re: [PATCH v2 2/2] ASoC: rockchip: i2s: add support for grabbing output clock to codec

2014-12-03 Thread Mark Brown
On Wed, Dec 03, 2014 at 03:18:38PM +0800, Jianqun Xu wrote: From: Sonny Rao sonny...@chromium.org We need to claim the clock which is driving the codec so that when we enable clock gating, we continue to clock the codec when needed. I make this an optional clock since there might be some

Re: [PATCH v2 2/2] ASoC: rockchip: i2s: add support for grabbing output clock to codec

2014-12-03 Thread Sonny Rao
On Wed, Dec 3, 2014 at 11:20 AM, Mark Brown broo...@kernel.org wrote: On Wed, Dec 03, 2014 at 03:18:38PM +0800, Jianqun Xu wrote: From: Sonny Rao sonny...@chromium.org We need to claim the clock which is driving the codec so that when we enable clock gating, we continue to clock the codec

Re: [PATCH v2 2/2] ASoC: rockchip: i2s: add support for grabbing output clock to codec

2014-12-03 Thread Mark Brown
On Wed, Dec 03, 2014 at 11:38:13AM -0800, Sonny Rao wrote: On Wed, Dec 3, 2014 at 11:20 AM, Mark Brown broo...@kernel.org wrote: I would expect that the clock for the CODEC should be managed by the CODEC if at all possible - that seems more logical than having the CPU I2S controller

Re: [PATCH v2 2/2] ASoC: rockchip: i2s: add support for grabbing output clock to codec

2014-12-03 Thread Sonny Rao
On Wed, Dec 3, 2014 at 12:03 PM, Mark Brown broo...@kernel.org wrote: On Wed, Dec 03, 2014 at 11:38:13AM -0800, Sonny Rao wrote: On Wed, Dec 3, 2014 at 11:20 AM, Mark Brown broo...@kernel.org wrote: I would expect that the clock for the CODEC should be managed by the CODEC if at all

Re: [alsa-devel] [PATCH v2 2/2] ASoC: rockchip: i2s: add support for grabbing output clock to codec

2014-12-03 Thread Dylan Reid
On Wed, Dec 3, 2014 at 3:03 PM, Sonny Rao sonny...@chromium.org wrote: On Wed, Dec 3, 2014 at 12:03 PM, Mark Brown broo...@kernel.org wrote: On Wed, Dec 03, 2014 at 11:38:13AM -0800, Sonny Rao wrote: On Wed, Dec 3, 2014 at 11:20 AM, Mark Brown broo...@kernel.org wrote: I would expect that

Re: [alsa-devel] [PATCH v2 2/2] ASoC: rockchip: i2s: add support for grabbing output clock to codec

2014-12-03 Thread Sonny Rao
On Wed, Dec 3, 2014 at 3:22 PM, Dylan Reid dgr...@chromium.org wrote: On Wed, Dec 3, 2014 at 3:03 PM, Sonny Rao sonny...@chromium.org wrote: On Wed, Dec 3, 2014 at 12:03 PM, Mark Brown broo...@kernel.org wrote: On Wed, Dec 03, 2014 at 11:38:13AM -0800, Sonny Rao wrote: On Wed, Dec 3, 2014 at

[PATCH v2 2/2] ASoC: rockchip: i2s: add support for grabbing output clock to codec

2014-12-02 Thread Jianqun Xu
From: Sonny Rao We need to claim the clock which is driving the codec so that when we enable clock gating, we continue to clock the codec when needed. I make this an optional clock since there might be some applications where we don't need it but can still use the I2S block. Signed-off-by:

[PATCH v2 2/2] ASoC: rockchip: i2s: add support for grabbing output clock to codec

2014-12-02 Thread Jianqun Xu
From: Sonny Rao sonny...@chromium.org We need to claim the clock which is driving the codec so that when we enable clock gating, we continue to clock the codec when needed. I make this an optional clock since there might be some applications where we don't need it but can still use the I2S

Re: [PATCH v2 2/2] ASoC: rockchip: i2s: add support for grabbing output clock to codec

2014-11-19 Thread Kever Yang
Hi Jay, On 11/19/2014 04:09 PM, Jianqun Xu wrote: Patch is from Sonny Rao Here should be, From: Sonny Rao - Kever -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH v2 2/2] ASoC: rockchip: i2s: add support for grabbing output clock to codec

2014-11-19 Thread Heiko Stübner
Hi Jianqun, Am Mittwoch, 19. November 2014, 16:09:27 schrieb Jianqun Xu: > Patch is from Sonny Rao that line above should read exactly: From: Sonny Rao that way git will also set the author correctly when importing the patch mbox. > > We need to claim the clock which is driving the codec so

[PATCH v2 2/2] ASoC: rockchip: i2s: add support for grabbing output clock to codec

2014-11-19 Thread Jianqun Xu
Patch is from Sonny Rao We need to claim the clock which is driving the codec so that when we enable clock gating, we continue to clock the codec when needed. I make this an optional clock since there might be some applications where we don't need it but can still use the I2S block.

[PATCH v2 2/2] ASoC: rockchip: i2s: add support for grabbing output clock to codec

2014-11-19 Thread Jianqun Xu
Patch is from Sonny Rao sonny...@chromium.org We need to claim the clock which is driving the codec so that when we enable clock gating, we continue to clock the codec when needed. I make this an optional clock since there might be some applications where we don't need it but can still use the

Re: [PATCH v2 2/2] ASoC: rockchip: i2s: add support for grabbing output clock to codec

2014-11-19 Thread Heiko Stübner
Hi Jianqun, Am Mittwoch, 19. November 2014, 16:09:27 schrieb Jianqun Xu: Patch is from Sonny Rao sonny...@chromium.org that line above should read exactly: From: Sonny Rao sonny...@chromium.org that way git will also set the author correctly when importing the patch mbox. We need to claim

Re: [PATCH v2 2/2] ASoC: rockchip: i2s: add support for grabbing output clock to codec

2014-11-19 Thread Kever Yang
Hi Jay, On 11/19/2014 04:09 PM, Jianqun Xu wrote: Patch is from Sonny Rao sonny...@chromium.org Here should be, From: Sonny Rao sonny...@chromium.org - Kever -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More