Re: [PATCH v2 2/2] arm64/build: Warn on orphan section placement

2020-06-23 Thread Kees Cook
On Tue, Jun 23, 2020 at 11:21:16PM +0200, Ard Biesheuvel wrote: > On Tue, 23 Jun 2020 at 23:06, Kees Cook wrote: > > > > On Tue, Jun 23, 2020 at 04:59:39PM +0200, Ard Biesheuvel wrote: > > > On Tue, 23 Jun 2020 at 16:52, Will Deacon wrote: > > > > > > > > On Mon, Jun 22, 2020 at 01:58:15PM

Re: [PATCH v2 2/2] arm64/build: Warn on orphan section placement

2020-06-23 Thread Ard Biesheuvel
On Tue, 23 Jun 2020 at 23:06, Kees Cook wrote: > > On Tue, Jun 23, 2020 at 04:59:39PM +0200, Ard Biesheuvel wrote: > > On Tue, 23 Jun 2020 at 16:52, Will Deacon wrote: > > > > > > On Mon, Jun 22, 2020 at 01:58:15PM -0700, Kees Cook wrote: > > > > We don't want to depend on the linker's orphan

Re: [PATCH v2 2/2] arm64/build: Warn on orphan section placement

2020-06-23 Thread Kees Cook
On Tue, Jun 23, 2020 at 04:59:39PM +0200, Ard Biesheuvel wrote: > On Tue, 23 Jun 2020 at 16:52, Will Deacon wrote: > > > > On Mon, Jun 22, 2020 at 01:58:15PM -0700, Kees Cook wrote: > > > We don't want to depend on the linker's orphan section placement > > > heuristics as these can vary between

Re: [PATCH v2 2/2] arm64/build: Warn on orphan section placement

2020-06-23 Thread Nick Desaulniers
On Tue, Jun 23, 2020 at 7:59 AM Ard Biesheuvel wrote: > > On Tue, 23 Jun 2020 at 16:52, Will Deacon wrote: > > > > On Mon, Jun 22, 2020 at 01:58:15PM -0700, Kees Cook wrote: > > > We don't want to depend on the linker's orphan section placement > > > heuristics as these can vary between linkers,

Re: [PATCH v2 2/2] arm64/build: Warn on orphan section placement

2020-06-23 Thread Ard Biesheuvel
On Tue, 23 Jun 2020 at 16:52, Will Deacon wrote: > > On Mon, Jun 22, 2020 at 01:58:15PM -0700, Kees Cook wrote: > > We don't want to depend on the linker's orphan section placement > > heuristics as these can vary between linkers, and may change between > > versions. All sections need to be

Re: [PATCH v2 2/2] arm64/build: Warn on orphan section placement

2020-06-23 Thread Will Deacon
On Mon, Jun 22, 2020 at 01:58:15PM -0700, Kees Cook wrote: > We don't want to depend on the linker's orphan section placement > heuristics as these can vary between linkers, and may change between > versions. All sections need to be explicitly named in the linker > script. > > Explicitly include

[PATCH v2 2/2] arm64/build: Warn on orphan section placement

2020-06-22 Thread Kees Cook
We don't want to depend on the linker's orphan section placement heuristics as these can vary between linkers, and may change between versions. All sections need to be explicitly named in the linker script. Explicitly include debug sections when they're present. Add .eh_frame* to discard as it