Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hello Akshay, Am 17.03.2017 um 19:28 schrieb Akshay Bhat: Hi Wolfgang, On 03/17/2017 01:04 PM, Wolfgang Grandegger wrote: Hm, that's unusual. Cable disconnected and then send a message: $ grep /proc/interrupts; sleep 10; /proc/interrupts should make things clear. But maybe it's a clever

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hello Akshay, Am 17.03.2017 um 19:28 schrieb Akshay Bhat: Hi Wolfgang, On 03/17/2017 01:04 PM, Wolfgang Grandegger wrote: Hm, that's unusual. Cable disconnected and then send a message: $ grep /proc/interrupts; sleep 10; /proc/interrupts should make things clear. But maybe it's a clever

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hi Wolfgang, On 03/17/2017 01:04 PM, Wolfgang Grandegger wrote: > > Hm, that's unusual. Cable disconnected and then send a message: > > $ grep /proc/interrupts; sleep 10; /proc/interrupts > > should make things clear. But maybe it's a clever chip and it does stop > sending error messages if

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hi Wolfgang, On 03/17/2017 01:04 PM, Wolfgang Grandegger wrote: > > Hm, that's unusual. Cable disconnected and then send a message: > > $ grep /proc/interrupts; sleep 10; /proc/interrupts > > should make things clear. But maybe it's a clever chip and it does stop > sending error messages if

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hi Akshay, Am 17.03.2017 um 17:00 schrieb Akshay Bhat: Hi Wolfgang, On 03/17/2017 03:39 AM, Wolfgang Grandegger wrote: Hello Akshay, Am 16.03.2017 um 23:29 schrieb Akshay Bhat: Hi Wolfgang, On 03/16/2017 04:02 PM, Wolfgang Grandegger wrote: Looks much better now! There are message for

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hi Akshay, Am 17.03.2017 um 17:00 schrieb Akshay Bhat: Hi Wolfgang, On 03/17/2017 03:39 AM, Wolfgang Grandegger wrote: Hello Akshay, Am 16.03.2017 um 23:29 schrieb Akshay Bhat: Hi Wolfgang, On 03/16/2017 04:02 PM, Wolfgang Grandegger wrote: Looks much better now! There are message for

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hi Wolfgang, On 03/17/2017 03:39 AM, Wolfgang Grandegger wrote: > Hello Akshay, > > Am 16.03.2017 um 23:29 schrieb Akshay Bhat: >> Hi Wolfgang, >> >> On 03/16/2017 04:02 PM, Wolfgang Grandegger wrote: >>> >>> Looks much better now! There are message for state changes to error >>> warning and

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hi Wolfgang, On 03/17/2017 03:39 AM, Wolfgang Grandegger wrote: > Hello Akshay, > > Am 16.03.2017 um 23:29 schrieb Akshay Bhat: >> Hi Wolfgang, >> >> On 03/16/2017 04:02 PM, Wolfgang Grandegger wrote: >>> >>> Looks much better now! There are message for state changes to error >>> warning and

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hello Akshay, Am 17.03.2017 um 08:39 schrieb Wolfgang Grandegger: Hello Akshay, Am 16.03.2017 um 23:29 schrieb Akshay Bhat: Hi Wolfgang, On 03/16/2017 04:02 PM, Wolfgang Grandegger wrote: Looks much better now! There are message for state changes to error warning and passive. Just the

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hello Akshay, Am 17.03.2017 um 08:39 schrieb Wolfgang Grandegger: Hello Akshay, Am 16.03.2017 um 23:29 schrieb Akshay Bhat: Hi Wolfgang, On 03/16/2017 04:02 PM, Wolfgang Grandegger wrote: Looks much better now! There are message for state changes to error warning and passive. Just the

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hello Akshay, Am 16.03.2017 um 23:29 schrieb Akshay Bhat: Hi Wolfgang, On 03/16/2017 04:02 PM, Wolfgang Grandegger wrote: Looks much better now! There are message for state changes to error warning and passive. Just the following message is not correct: (000.200824) can0 2004 [8]

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hello Akshay, Am 16.03.2017 um 23:29 schrieb Akshay Bhat: Hi Wolfgang, On 03/16/2017 04:02 PM, Wolfgang Grandegger wrote: Looks much better now! There are message for state changes to error warning and passive. Just the following message is not correct: (000.200824) can0 2004 [8]

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hi Wolfgang, On 03/16/2017 04:02 PM, Wolfgang Grandegger wrote: > > Looks much better now! There are message for state changes to error > warning and passive. Just the following message is not correct: > > (000.200824) can0 2004 [8] 00 40 00 00 00 00 5F 19 ERRORFRAME >

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hi Wolfgang, On 03/16/2017 04:02 PM, Wolfgang Grandegger wrote: > > Looks much better now! There are message for state changes to error > warning and passive. Just the following message is not correct: > > (000.200824) can0 2004 [8] 00 40 00 00 00 00 5F 19 ERRORFRAME >

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hello Akshay, Am 16.03.2017 um 18:06 schrieb Akshay Bhat: > Hi Wolfgang, > > On 03/15/2017 05:42 AM, Wolfgang Grandegger wrote: >> Hello Akshay, >> > ..snip.. >>> >>> So here is my plan: >>> - Have the bus error interrupt always enabled >>> - If berr-reporting off, then have the isr

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hello Akshay, Am 16.03.2017 um 18:06 schrieb Akshay Bhat: > Hi Wolfgang, > > On 03/15/2017 05:42 AM, Wolfgang Grandegger wrote: >> Hello Akshay, >> > ..snip.. >>> >>> So here is my plan: >>> - Have the bus error interrupt always enabled >>> - If berr-reporting off, then have the isr

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hi Wolfgang, On 03/15/2017 05:42 AM, Wolfgang Grandegger wrote: > Hello Akshay, > ..snip.. >> >> So here is my plan: >> - Have the bus error interrupt always enabled >> - If berr-reporting off, then have the isr checks/reports state changes > > Error state change messages should always be

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hi Wolfgang, On 03/15/2017 05:42 AM, Wolfgang Grandegger wrote: > Hello Akshay, > ..snip.. >> >> So here is my plan: >> - Have the bus error interrupt always enabled >> - If berr-reporting off, then have the isr checks/reports state changes > > Error state change messages should always be

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hello Akshay, Am 15.03.2017 um 05:44 schrieb Akshay Bhat: Hi Wolfgang, On Tue, Mar 14, 2017 at 2:08 PM, Wolfgang Grandegger wrote: ...snip /disconnect cable can0 2088 [8] 00 00 00 19 00 00 28 00 ERRORFRAME

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hello Akshay, Am 15.03.2017 um 05:44 schrieb Akshay Bhat: Hi Wolfgang, On Tue, Mar 14, 2017 at 2:08 PM, Wolfgang Grandegger wrote: ...snip /disconnect cable can0 2088 [8] 00 00 00 19 00 00 28 00 ERRORFRAME protocol-violation{{}{acknowledge-slot}}

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hello Akshay, Am 15.03.2017 um 05:44 schrieb Akshay Bhat: Hi Wolfgang, On Tue, Mar 14, 2017 at 2:08 PM, Wolfgang Grandegger wrote: ...snip /disconnect cable can0 2088 [8] 00 00 00 19 00 00 28 00 ERRORFRAME

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hello Akshay, Am 15.03.2017 um 05:44 schrieb Akshay Bhat: Hi Wolfgang, On Tue, Mar 14, 2017 at 2:08 PM, Wolfgang Grandegger wrote: ...snip /disconnect cable can0 2088 [8] 00 00 00 19 00 00 28 00 ERRORFRAME protocol-violation{{}{acknowledge-slot}}

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hi Wolfgang, On Tue, Mar 14, 2017 at 2:08 PM, Wolfgang Grandegger wrote: ...snip >> /disconnect cable >> can0 2088 [8] 00 00 00 19 00 00 28 00 ERRORFRAME >> protocol-violation{{}{acknowledge-slot}} >> bus-error >>

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hi Wolfgang, On Tue, Mar 14, 2017 at 2:08 PM, Wolfgang Grandegger wrote: ...snip >> /disconnect cable >> can0 2088 [8] 00 00 00 19 00 00 28 00 ERRORFRAME >> protocol-violation{{}{acknowledge-slot}} >> bus-error >> error-counter-tx-rx{{40}{0}} >>

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Am 14.03.2017 um 19:08 schrieb Wolfgang Grandegger: Hello Akshay, Am 14.03.2017 um 17:20 schrieb Akshay Bhat: Hi Wolfgang, On 03/14/2017 08:11 AM, Wolfgang Grandegger wrote: ... snip ... A few other things to check: Run "cangen" and monitor the message with "candump -e any,0:0,#FFF".

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Am 14.03.2017 um 19:08 schrieb Wolfgang Grandegger: Hello Akshay, Am 14.03.2017 um 17:20 schrieb Akshay Bhat: Hi Wolfgang, On 03/14/2017 08:11 AM, Wolfgang Grandegger wrote: ... snip ... A few other things to check: Run "cangen" and monitor the message with "candump -e any,0:0,#FFF".

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hello Akshay, Am 14.03.2017 um 17:20 schrieb Akshay Bhat: Hi Wolfgang, On 03/14/2017 08:11 AM, Wolfgang Grandegger wrote: ... snip ... A few other things to check: Run "cangen" and monitor the message with "candump -e any,0:0,#FFF". Then 1) disconnect the cable or 2) short-circuit CAN

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hello Akshay, Am 14.03.2017 um 17:20 schrieb Akshay Bhat: Hi Wolfgang, On 03/14/2017 08:11 AM, Wolfgang Grandegger wrote: ... snip ... A few other things to check: Run "cangen" and monitor the message with "candump -e any,0:0,#FFF". Then 1) disconnect the cable or 2) short-circuit CAN

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hi Wolfgang, On 03/14/2017 08:11 AM, Wolfgang Grandegger wrote: > ... snip ... >>> A few other things to check: >>> >>> Run "cangen" and monitor the message with "candump -e any,0:0,#FFF". >>> Then 1) disconnect the cable or 2) short-circuit CAN low and high at the >>> connector. You should

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hi Wolfgang, On 03/14/2017 08:11 AM, Wolfgang Grandegger wrote: > ... snip ... >>> A few other things to check: >>> >>> Run "cangen" and monitor the message with "candump -e any,0:0,#FFF". >>> Then 1) disconnect the cable or 2) short-circuit CAN low and high at the >>> connector. You should

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hallo Akshay, Am 13.03.2017 um 16:38 schrieb Akshay Bhat: Hi Wolfgang, On 03/09/2017 12:36 PM, Wolfgang Grandegger wrote: Hello, doing a quick review... I realized a few issues... Am 17.01.2017 um 20:22 schrieb Akshay Bhat: ... snip ... A few other things to check: Run "cangen" and

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hallo Akshay, Am 13.03.2017 um 16:38 schrieb Akshay Bhat: Hi Wolfgang, On 03/09/2017 12:36 PM, Wolfgang Grandegger wrote: Hello, doing a quick review... I realized a few issues... Am 17.01.2017 um 20:22 schrieb Akshay Bhat: ... snip ... A few other things to check: Run "cangen" and

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hi Wolfgang, On 03/09/2017 12:36 PM, Wolfgang Grandegger wrote: > Hello, > > doing a quick review... I realized a few issues... > > Am 17.01.2017 um 20:22 schrieb Akshay Bhat: >> +static u8 hi3110_read(struct spi_device *spi, u8 command) >> +{ >> +struct hi3110_priv *priv =

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hi Wolfgang, On 03/09/2017 12:36 PM, Wolfgang Grandegger wrote: > Hello, > > doing a quick review... I realized a few issues... > > Am 17.01.2017 um 20:22 schrieb Akshay Bhat: >> +static u8 hi3110_read(struct spi_device *spi, u8 command) >> +{ >> +struct hi3110_priv *priv =

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hello, doing a quick review... I realized a few issues... Am 17.01.2017 um 20:22 schrieb Akshay Bhat: This patch adds support for the Holt HI-311x CAN controller. The HI311x CAN controller is capable of transmitting and receiving standard data frames, extended data frames and remote frames.

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hello, doing a quick review... I realized a few issues... Am 17.01.2017 um 20:22 schrieb Akshay Bhat: This patch adds support for the Holt HI-311x CAN controller. The HI311x CAN controller is capable of transmitting and receiving standard data frames, extended data frames and remote frames.

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hi Wolfgang, On 03/09/2017 09:45 AM, Wolfgang Grandegger wrote: > Hello Akshay, > > Am 09.03.2017 um 13:34 schrieb Akshay Bhat: >> >> Hi Wolfgang, >> >> Good question. I have not worked with MPC251x but the HI-311x performs >> much better because HI-3110 features: >> 8 message FIFO (as opposed

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hi Wolfgang, On 03/09/2017 09:45 AM, Wolfgang Grandegger wrote: > Hello Akshay, > > Am 09.03.2017 um 13:34 schrieb Akshay Bhat: >> >> Hi Wolfgang, >> >> Good question. I have not worked with MPC251x but the HI-311x performs >> much better because HI-3110 features: >> 8 message FIFO (as opposed

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hello Akshay, Am 09.03.2017 um 13:34 schrieb Akshay Bhat: On 03/09/2017 04:59 AM, Wolfgang Grandegger wrote: Hello Akshay, unfortunately there are not many CAN controllers for the SPI bus. I just know the MPC251x, which behaves badly (message losses) under Linux, especially at hight

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hello Akshay, Am 09.03.2017 um 13:34 schrieb Akshay Bhat: On 03/09/2017 04:59 AM, Wolfgang Grandegger wrote: Hello Akshay, unfortunately there are not many CAN controllers for the SPI bus. I just know the MPC251x, which behaves badly (message losses) under Linux, especially at hight

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

On 03/09/2017 04:59 AM, Wolfgang Grandegger wrote: > Hello Akshay, > > unfortunately there are not many CAN controllers for the SPI bus. I just > know the MPC251x, which behaves badly (message losses) under Linux, > especially at hight bit-rates due to insufficient RX buffering. What is > your

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

On 03/09/2017 04:59 AM, Wolfgang Grandegger wrote: > Hello Akshay, > > unfortunately there are not many CAN controllers for the SPI bus. I just > know the MPC251x, which behaves badly (message losses) under Linux, > especially at hight bit-rates due to insufficient RX buffering. What is > your

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hello Akshay, unfortunately there are not many CAN controllers for the SPI bus. I just know the MPC251x, which behaves badly (message losses) under Linux, especially at hight bit-rates due to insufficient RX buffering. What is your experience with that driver for the HI-311x? Thanks,

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

Hello Akshay, unfortunately there are not many CAN controllers for the SPI bus. I just know the MPC251x, which behaves badly (message losses) under Linux, especially at hight bit-rates due to insufficient RX buffering. What is your experience with that driver for the HI-311x? Thanks,

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

On 01/17/2017 02:22 PM, Akshay Bhat wrote: > This patch adds support for the Holt HI-311x CAN controller. The HI311x > CAN controller is capable of transmitting and receiving standard data > frames, extended data frames and remote frames. The HI311x interfaces > with the host over SPI. > >

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

On 01/17/2017 02:22 PM, Akshay Bhat wrote: > This patch adds support for the Holt HI-311x CAN controller. The HI311x > CAN controller is capable of transmitting and receiving standard data > frames, extended data frames and remote frames. The HI311x interfaces > with the host over SPI. > >

[PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

This patch adds support for the Holt HI-311x CAN controller. The HI311x CAN controller is capable of transmitting and receiving standard data frames, extended data frames and remote frames. The HI311x interfaces with the host over SPI. Datasheet: www.holtic.com/documents/371-hi-3110_v-rev-jpdf.do

[PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

This patch adds support for the Holt HI-311x CAN controller. The HI311x CAN controller is capable of transmitting and receiving standard data frames, extended data frames and remote frames. The HI311x interfaces with the host over SPI. Datasheet: www.holtic.com/documents/371-hi-3110_v-rev-jpdf.do