Re: [PATCH v2 2/2] dmaengine: tegra210-adma: Add memcpy support

2016-09-06 Thread Nicolin Chen
On Tue, Sep 06, 2016 at 12:52:03PM +0100, Jon Hunter wrote: > > + /* TODO: ADMA should support up to 8 chunks or periods */ > > + desc->num_periods = 1; > > + desc->buf_len = buf_len; > > + desc->period_len = buf_len; > What would be the benefit of using 8 periods here? My understanding

Re: [PATCH v2 2/2] dmaengine: tegra210-adma: Add memcpy support

2016-09-06 Thread Nicolin Chen
On Tue, Sep 06, 2016 at 12:52:03PM +0100, Jon Hunter wrote: > > + /* TODO: ADMA should support up to 8 chunks or periods */ > > + desc->num_periods = 1; > > + desc->buf_len = buf_len; > > + desc->period_len = buf_len; > What would be the benefit of using 8 periods here? My understanding

Re: [PATCH v2 2/2] dmaengine: tegra210-adma: Add memcpy support

2016-09-06 Thread Jon Hunter
On 03/09/16 01:32, Nicolin Chen wrote: > ADMA supports non-flow controlled Memory-to-Memory direction > transactions. So this patch just adds an initial support for > that. It passed a simple dmatest: > echo dma1chan0 > /sys/module/dmatest/parameters/channel > echo 1024 >

Re: [PATCH v2 2/2] dmaengine: tegra210-adma: Add memcpy support

2016-09-06 Thread Jon Hunter
On 03/09/16 01:32, Nicolin Chen wrote: > ADMA supports non-flow controlled Memory-to-Memory direction > transactions. So this patch just adds an initial support for > that. It passed a simple dmatest: > echo dma1chan0 > /sys/module/dmatest/parameters/channel > echo 1024 >

[PATCH v2 2/2] dmaengine: tegra210-adma: Add memcpy support

2016-09-02 Thread Nicolin Chen
ADMA supports non-flow controlled Memory-to-Memory direction transactions. So this patch just adds an initial support for that. It passed a simple dmatest: echo dma1chan0 > /sys/module/dmatest/parameters/channel echo 1024 > /sys/module/dmatest/parameters/iterations echo 0 >

[PATCH v2 2/2] dmaengine: tegra210-adma: Add memcpy support

2016-09-02 Thread Nicolin Chen
ADMA supports non-flow controlled Memory-to-Memory direction transactions. So this patch just adds an initial support for that. It passed a simple dmatest: echo dma1chan0 > /sys/module/dmatest/parameters/channel echo 1024 > /sys/module/dmatest/parameters/iterations echo 0 >