On 16/07/2019 12:50, Daniel Thompson wrote:
On Mon, Jul 15, 2019 at 05:56:57PM +0200, Jean-Jacques Hiblot wrote:
A LED is usually powered by a voltage/current regulator. Let the LED core
This is almost certainly nitpicking but since there's enough other
review comments that you will have to
Hi Jacek,
On 15/07/2019 22:42, Jacek Anaszewski wrote:
@@ -80,6 +107,7 @@ static void led_timer_function(struct timer_list *t)
}
led_set_brightness_nosleep(led_cdev, brightness);
+ __led_handle_regulator(led_cdev, brightness);
This cannot be called from atomic context since
Hi Dan,
On 15/07/2019 20:59, Dan Murphy wrote:
JJ
On 7/15/19 10:56 AM, Jean-Jacques Hiblot wrote:
A LED is usually powered by a voltage/current regulator. Let the LED
core
know about it. This allows the LED core to turn on or off the power
supply
as needed.
This allows the LED core to
On Mon, Jul 15, 2019 at 05:56:57PM +0200, Jean-Jacques Hiblot wrote:
> A LED is usually powered by a voltage/current regulator. Let the LED core
This is almost certainly nitpicking but since there's enough other
review comments that you will have to respin anyway ;-)
Is an LED really "usually
Hi Jean,
Thank you for the patch.
I have one issue. Please refer below.
On 7/15/19 5:56 PM, Jean-Jacques Hiblot wrote:
> A LED is usually powered by a voltage/current regulator. Let the LED core
> know about it. This allows the LED core to turn on or off the power supply
> as needed.
>
>
JJ
On 7/15/19 10:56 AM, Jean-Jacques Hiblot wrote:
A LED is usually powered by a voltage/current regulator. Let the LED core
know about it. This allows the LED core to turn on or off the power supply
as needed.
This allows the LED core to turn on or off managed power supplies.
A LED is usually powered by a voltage/current regulator. Let the LED core
know about it. This allows the LED core to turn on or off the power supply
as needed.
Signed-off-by: Jean-Jacques Hiblot
---
drivers/leds/led-class.c | 15
drivers/leds/led-core.c | 50
7 matches
Mail list logo
