Re: [PATCH v2 2/2] livepatch/module: Correctly handle going modules

2015-03-10 Thread Petr Mladek
On Tue 2015-03-10 12:53:21, Rusty Russell wrote: Petr Mladek pmla...@suse.cz writes: On Sat 2015-03-07 11:34:36, Rusty Russell wrote: I don't think you should handle going modules at all. Rarely happens, and it should happen fast. I would like to handle it correctly. It would be pity

Re: [PATCH v2 2/2] livepatch/module: Correctly handle going modules

2015-03-09 Thread Rusty Russell
Petr Mladek pmla...@suse.cz writes: On Sat 2015-03-07 11:34:36, Rusty Russell wrote: I don't think you should handle going modules at all. Rarely happens, and it should happen fast. I would like to handle it correctly. It would be pity to break a system just because of a module removal.

Re: [PATCH v2 2/2] livepatch/module: Correctly handle going modules

2015-03-09 Thread Petr Mladek
On Sat 2015-03-07 11:34:36, Rusty Russell wrote: Petr Mladek pmla...@suse.cz writes: Existing live patches are removed from going modules using a notify handler. There are two problems with the current implementation. First, new patch could still see the module in the GOING state even

Re: [PATCH v2 2/2] livepatch/module: Correctly handle going modules

2015-03-08 Thread Rusty Russell
Petr Mladek pmla...@suse.cz writes: Existing live patches are removed from going modules using a notify handler. There are two problems with the current implementation. First, new patch could still see the module in the GOING state even after the notifier has been called. It will try to

Re: [PATCH v2 2/2] livepatch/module: Correctly handle going modules

2015-03-05 Thread Josh Poimboeuf
On Thu, Mar 05, 2015 at 04:45:14PM +0100, Petr Mladek wrote: Existing live patches are removed from going modules using a notify handler. There are two problems with the current implementation. First, new patch could still see the module in the GOING state even after the notifier has been

[PATCH v2 2/2] livepatch/module: Correctly handle going modules

2015-03-05 Thread Petr Mladek
Existing live patches are removed from going modules using a notify handler. There are two problems with the current implementation. First, new patch could still see the module in the GOING state even after the notifier has been called. It will try to initialize the related object structures but