Re: [PATCH v2 2/2] mm/sparse: start using sparse_init_nid(), and remove old code

2018-07-01 Thread Pavel Tatashin
> > Yes, if they are equal at 501, 'continue' to for loop. If nid is not > equal to nid_begin, we execute sparse_init_nid(), here should it be that > nid_begin is the current node, nid is next node? Nevermind, I forgot about the continue, I will fix it. Thank you again! Pavel

Re: [PATCH v2 2/2] mm/sparse: start using sparse_init_nid(), and remove old code

2018-07-01 Thread Pavel Tatashin
> > Yes, if they are equal at 501, 'continue' to for loop. If nid is not > equal to nid_begin, we execute sparse_init_nid(), here should it be that > nid_begin is the current node, nid is next node? Nevermind, I forgot about the continue, I will fix it. Thank you again! Pavel

Re: [PATCH v2 2/2] mm/sparse: start using sparse_init_nid(), and remove old code

2018-07-01 Thread Baoquan He
On 07/01/18 at 09:46pm, Pavel Tatashin wrote: > ~~~ > > Here, node id passed to sparse_init_nid() should be 'nid_begin', but not > > 'nid'. When you found out the current section's 'nid' is diferent than > > 'nid_begin', handle node 'nid_begin', then start to next node

Re: [PATCH v2 2/2] mm/sparse: start using sparse_init_nid(), and remove old code

2018-07-01 Thread Baoquan He
On 07/01/18 at 09:46pm, Pavel Tatashin wrote: > ~~~ > > Here, node id passed to sparse_init_nid() should be 'nid_begin', but not > > 'nid'. When you found out the current section's 'nid' is diferent than > > 'nid_begin', handle node 'nid_begin', then start to next node

Re: [PATCH v2 2/2] mm/sparse: start using sparse_init_nid(), and remove old code

2018-07-01 Thread Pavel Tatashin
~~~ > Here, node id passed to sparse_init_nid() should be 'nid_begin', but not > 'nid'. When you found out the current section's 'nid' is diferent than > 'nid_begin', handle node 'nid_begin', then start to next node 'nid'. Thank you for reviewing this work. Here nid

Re: [PATCH v2 2/2] mm/sparse: start using sparse_init_nid(), and remove old code

2018-07-01 Thread Pavel Tatashin
~~~ > Here, node id passed to sparse_init_nid() should be 'nid_begin', but not > 'nid'. When you found out the current section's 'nid' is diferent than > 'nid_begin', handle node 'nid_begin', then start to next node 'nid'. Thank you for reviewing this work. Here nid

Re: [PATCH v2 2/2] mm/sparse: start using sparse_init_nid(), and remove old code

2018-07-01 Thread Pavel Tatashin
On Sun, Jul 1, 2018 at 9:34 PM Baoquan He wrote: > > Hi Pavel, > > On 06/29/18 at 11:09pm, Pavel Tatashin wrote: > > Change sprase_init() to only find the pnum ranges that belong to a specific > > node and call sprase_init_nid() for that range from sparse_init(). > > > > Delete all the code that

Re: [PATCH v2 2/2] mm/sparse: start using sparse_init_nid(), and remove old code

2018-07-01 Thread Pavel Tatashin
On Sun, Jul 1, 2018 at 9:34 PM Baoquan He wrote: > > Hi Pavel, > > On 06/29/18 at 11:09pm, Pavel Tatashin wrote: > > Change sprase_init() to only find the pnum ranges that belong to a specific > > node and call sprase_init_nid() for that range from sparse_init(). > > > > Delete all the code that

Re: [PATCH v2 2/2] mm/sparse: start using sparse_init_nid(), and remove old code

2018-07-01 Thread Baoquan He
On 06/29/18 at 11:09pm, Pavel Tatashin wrote: > Change sprase_init() to only find the pnum ranges that belong to a specific > node and call sprase_init_nid() for that range from sparse_init(). > > Delete all the code that became obsolete with this change. > void __init sparse_init(void) > { > -

Re: [PATCH v2 2/2] mm/sparse: start using sparse_init_nid(), and remove old code

2018-07-01 Thread Baoquan He
On 06/29/18 at 11:09pm, Pavel Tatashin wrote: > Change sprase_init() to only find the pnum ranges that belong to a specific > node and call sprase_init_nid() for that range from sparse_init(). > > Delete all the code that became obsolete with this change. > void __init sparse_init(void) > { > -

Re: [PATCH v2 2/2] mm/sparse: start using sparse_init_nid(), and remove old code

2018-07-01 Thread Baoquan He
Hi Pavel, On 06/29/18 at 11:09pm, Pavel Tatashin wrote: > Change sprase_init() to only find the pnum ranges that belong to a specific > node and call sprase_init_nid() for that range from sparse_init(). > > Delete all the code that became obsolete with this change. > @@ -617,87 +491,24 @@ void

Re: [PATCH v2 2/2] mm/sparse: start using sparse_init_nid(), and remove old code

2018-07-01 Thread Baoquan He
Hi Pavel, On 06/29/18 at 11:09pm, Pavel Tatashin wrote: > Change sprase_init() to only find the pnum ranges that belong to a specific > node and call sprase_init_nid() for that range from sparse_init(). > > Delete all the code that became obsolete with this change. > @@ -617,87 +491,24 @@ void

[PATCH v2 2/2] mm/sparse: start using sparse_init_nid(), and remove old code

2018-06-29 Thread Pavel Tatashin
Change sprase_init() to only find the pnum ranges that belong to a specific node and call sprase_init_nid() for that range from sparse_init(). Delete all the code that became obsolete with this change. Signed-off-by: Pavel Tatashin --- include/linux/mm.h | 5 - mm/sparse-vmemmap.c | 39

[PATCH v2 2/2] mm/sparse: start using sparse_init_nid(), and remove old code

2018-06-29 Thread Pavel Tatashin
Change sprase_init() to only find the pnum ranges that belong to a specific node and call sprase_init_nid() for that range from sparse_init(). Delete all the code that became obsolete with this change. Signed-off-by: Pavel Tatashin --- include/linux/mm.h | 5 - mm/sparse-vmemmap.c | 39