Re: [PATCH v2 2/2] mmc: Add support for the ASPEED SD controller

2019-07-26 Thread Andrew Jeffery
On Fri, 26 Jul 2019, at 15:27, Adrian Hunter wrote: > On 26/07/19 3:52 AM, Andrew Jeffery wrote: > > On Thu, 25 Jul 2019, at 22:49, Adrian Hunter wrote: > >> On 12/07/19 6:32 AM, Andrew Jeffery wrote: > >>> +static int aspeed_sdhci_probe(struct platform_device *pdev) > >>> +{ > >>> + struct

Re: [PATCH v2 2/2] mmc: Add support for the ASPEED SD controller

2019-07-25 Thread Adrian Hunter
On 26/07/19 3:52 AM, Andrew Jeffery wrote: > On Thu, 25 Jul 2019, at 22:49, Adrian Hunter wrote: >> On 12/07/19 6:32 AM, Andrew Jeffery wrote: >>> +static int aspeed_sdhci_probe(struct platform_device *pdev) >>> +{ >>> + struct sdhci_pltfm_host *pltfm_host; >>> + struct aspeed_sdhci *dev; >>>

Re: [PATCH v2 2/2] mmc: Add support for the ASPEED SD controller

2019-07-25 Thread Andrew Jeffery
On Thu, 25 Jul 2019, at 22:49, Adrian Hunter wrote: > On 12/07/19 6:32 AM, Andrew Jeffery wrote: > > Add a minimal driver for ASPEED's SD controller, which exposes two > > SDHCIs. > > > > The ASPEED design implements a common register set for the SDHCIs, and > > moves some of the standard

Re: [PATCH v2 2/2] mmc: Add support for the ASPEED SD controller

2019-07-25 Thread Adrian Hunter
On 12/07/19 6:32 AM, Andrew Jeffery wrote: > Add a minimal driver for ASPEED's SD controller, which exposes two > SDHCIs. > > The ASPEED design implements a common register set for the SDHCIs, and > moves some of the standard configuration elements out to this common > area (e.g. 8-bit mode, and

[PATCH v2 2/2] mmc: Add support for the ASPEED SD controller

2019-07-11 Thread Andrew Jeffery
Add a minimal driver for ASPEED's SD controller, which exposes two SDHCIs. The ASPEED design implements a common register set for the SDHCIs, and moves some of the standard configuration elements out to this common area (e.g. 8-bit mode, and card detect configuration which is not currently