Re: [PATCH v2 2/2] perf cs-etm: Add support sample flags

2018-12-04 Thread leo . yan
On Tue, Nov 20, 2018 at 09:53:41AM -0700, Mathieu Poirier wrote: [...] > > > +static void cs_etm__fixup_flags(struct cs_etm_queue *etmq) > > > +{ > > > + /* > > > + * Decoding stream might insert one TRACE_OFF packet in the > > > + * middle of instruction packets, this means it

Re: [PATCH v2 2/2] perf cs-etm: Add support sample flags

2018-12-04 Thread leo . yan
On Tue, Nov 20, 2018 at 09:53:41AM -0700, Mathieu Poirier wrote: [...] > > > +static void cs_etm__fixup_flags(struct cs_etm_queue *etmq) > > > +{ > > > + /* > > > + * Decoding stream might insert one TRACE_OFF packet in the > > > + * middle of instruction packets, this means it

Re: [PATCH v2 2/2] perf cs-etm: Add support sample flags

2018-11-20 Thread Mathieu Poirier
On Mon, 19 Nov 2018 at 16:22, Mathieu Poirier wrote: > > On Sun, Nov 11, 2018 at 01:07:56PM +0800, Leo Yan wrote: > > We have prepared the flags in the packet structure, so need to copy > > the related value into sample structure thus perf tool can facilitate > > sample flags. > > > > The

Re: [PATCH v2 2/2] perf cs-etm: Add support sample flags

2018-11-20 Thread Mathieu Poirier
On Mon, 19 Nov 2018 at 16:22, Mathieu Poirier wrote: > > On Sun, Nov 11, 2018 at 01:07:56PM +0800, Leo Yan wrote: > > We have prepared the flags in the packet structure, so need to copy > > the related value into sample structure thus perf tool can facilitate > > sample flags. > > > > The

Re: [PATCH v2 2/2] perf cs-etm: Add support sample flags

2018-11-19 Thread Mathieu Poirier
On Sun, Nov 11, 2018 at 01:07:56PM +0800, Leo Yan wrote: > We have prepared the flags in the packet structure, so need to copy > the related value into sample structure thus perf tool can facilitate > sample flags. > > The PREV_PACKET contains the branch instruction flags and PACKET > actually

Re: [PATCH v2 2/2] perf cs-etm: Add support sample flags

2018-11-19 Thread Mathieu Poirier
On Sun, Nov 11, 2018 at 01:07:56PM +0800, Leo Yan wrote: > We have prepared the flags in the packet structure, so need to copy > the related value into sample structure thus perf tool can facilitate > sample flags. > > The PREV_PACKET contains the branch instruction flags and PACKET > actually

[PATCH v2 2/2] perf cs-etm: Add support sample flags

2018-11-10 Thread Leo Yan
We have prepared the flags in the packet structure, so need to copy the related value into sample structure thus perf tool can facilitate sample flags. The PREV_PACKET contains the branch instruction flags and PACKET actually contains the flags for next branch instruction. So this patch is to

[PATCH v2 2/2] perf cs-etm: Add support sample flags

2018-11-10 Thread Leo Yan
We have prepared the flags in the packet structure, so need to copy the related value into sample structure thus perf tool can facilitate sample flags. The PREV_PACKET contains the branch instruction flags and PACKET actually contains the flags for next branch instruction. So this patch is to