Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization

On Saturday 27 August 2016 01:24 AM, Arnaldo Carvalho de Melo wrote: > Em Fri, Aug 26, 2016 at 04:30:27PM -0300, Arnaldo Carvalho de Melo escreveu: >> Em Wed, Aug 03, 2016 at 02:28:45PM +0530, Ravi Bangoria escreveu: >>> +++ b/tools/perf/util/probe-finder.c >>> @@ -892,6 +892,169 @@ static int

Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization

On Saturday 27 August 2016 01:24 AM, Arnaldo Carvalho de Melo wrote: > Em Fri, Aug 26, 2016 at 04:30:27PM -0300, Arnaldo Carvalho de Melo escreveu: >> Em Wed, Aug 03, 2016 at 02:28:45PM +0530, Ravi Bangoria escreveu: >>> +++ b/tools/perf/util/probe-finder.c >>> @@ -892,6 +892,169 @@ static int

Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization

On Saturday 27 August 2016 01:00 AM, Arnaldo Carvalho de Melo wrote: > Em Wed, Aug 03, 2016 at 02:28:45PM +0530, Ravi Bangoria escreveu: >> +++ b/tools/perf/util/probe-finder.c >> @@ -892,6 +892,169 @@ static int find_probe_point_lazy(Dwarf_Die *sp_die, >> struct probe_finder *pf) >>

Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization

On Saturday 27 August 2016 01:00 AM, Arnaldo Carvalho de Melo wrote: > Em Wed, Aug 03, 2016 at 02:28:45PM +0530, Ravi Bangoria escreveu: >> +++ b/tools/perf/util/probe-finder.c >> @@ -892,6 +892,169 @@ static int find_probe_point_lazy(Dwarf_Die *sp_die, >> struct probe_finder *pf) >>

Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization

On Fri, 26 Aug 2016 16:54:52 -0300 Arnaldo Carvalho de Melo wrote: > Em Fri, Aug 26, 2016 at 04:30:27PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Wed, Aug 03, 2016 at 02:28:45PM +0530, Ravi Bangoria escreveu: > > > +++ b/tools/perf/util/probe-finder.c > > > @@ -892,6

Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization

On Fri, 26 Aug 2016 16:54:52 -0300 Arnaldo Carvalho de Melo wrote: > Em Fri, Aug 26, 2016 at 04:30:27PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Wed, Aug 03, 2016 at 02:28:45PM +0530, Ravi Bangoria escreveu: > > > +++ b/tools/perf/util/probe-finder.c > > > @@ -892,6 +892,169 @@ static

Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization

Em Fri, Aug 26, 2016 at 04:30:27PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Aug 03, 2016 at 02:28:45PM +0530, Ravi Bangoria escreveu: > > +++ b/tools/perf/util/probe-finder.c > > @@ -892,6 +892,169 @@ static int find_probe_point_lazy(Dwarf_Die *sp_die, > > struct probe_finder *pf) > >

Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization

Em Fri, Aug 26, 2016 at 04:30:27PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Aug 03, 2016 at 02:28:45PM +0530, Ravi Bangoria escreveu: > > +++ b/tools/perf/util/probe-finder.c > > @@ -892,6 +892,169 @@ static int find_probe_point_lazy(Dwarf_Die *sp_die, > > struct probe_finder *pf) > >

Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization

Em Wed, Aug 03, 2016 at 02:28:45PM +0530, Ravi Bangoria escreveu: > +++ b/tools/perf/util/probe-finder.c > @@ -892,6 +892,169 @@ static int find_probe_point_lazy(Dwarf_Die *sp_die, > struct probe_finder *pf) > return die_walk_lines(sp_die, probe_point_lazy_walker, pf); > } > +static

Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization

Em Wed, Aug 03, 2016 at 02:28:45PM +0530, Ravi Bangoria escreveu: > +++ b/tools/perf/util/probe-finder.c > @@ -892,6 +892,169 @@ static int find_probe_point_lazy(Dwarf_Die *sp_die, > struct probe_finder *pf) > return die_walk_lines(sp_die, probe_point_lazy_walker, pf); > } > +static

Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization

On Thu, Aug 25, 2016 at 12:17:53PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Aug 25, 2016 at 03:59:43PM +0200, Jiri Olsa escreveu: > > On Thu, Aug 25, 2016 at 09:50:04PM +0900, Masami Hiramatsu wrote: > > > > SNIP > > > > > > After applying patch: > > > > > > > > $ ./perf probe -x

Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization

On Thu, Aug 25, 2016 at 12:17:53PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Aug 25, 2016 at 03:59:43PM +0200, Jiri Olsa escreveu: > > On Thu, Aug 25, 2016 at 09:50:04PM +0900, Masami Hiramatsu wrote: > > > > SNIP > > > > > > After applying patch: > > > > > > > > $ ./perf probe -x

Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization

Em Thu, Aug 25, 2016 at 03:59:43PM +0200, Jiri Olsa escreveu: > On Thu, Aug 25, 2016 at 09:50:04PM +0900, Masami Hiramatsu wrote: > > SNIP > > > > After applying patch: > > > > > > $ ./perf probe -x ./test 'foo i' > > > $ cat /sys/kernel/debug/tracing/uprobe_events > > >

Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization

Em Thu, Aug 25, 2016 at 03:59:43PM +0200, Jiri Olsa escreveu: > On Thu, Aug 25, 2016 at 09:50:04PM +0900, Masami Hiramatsu wrote: > > SNIP > > > > After applying patch: > > > > > > $ ./perf probe -x ./test 'foo i' > > > $ cat /sys/kernel/debug/tracing/uprobe_events > > >

Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization

On Thu, Aug 25, 2016 at 09:50:04PM +0900, Masami Hiramatsu wrote: SNIP > > After applying patch: > > > > $ ./perf probe -x ./test 'foo i' > > $ cat /sys/kernel/debug/tracing/uprobe_events > > p:probe_test/foo /home/ravi/test:0x0541 i=-4(%bp):s32 > > > > $ ./perf record -e

Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization

On Thu, Aug 25, 2016 at 09:50:04PM +0900, Masami Hiramatsu wrote: SNIP > > After applying patch: > > > > $ ./perf probe -x ./test 'foo i' > > $ cat /sys/kernel/debug/tracing/uprobe_events > > p:probe_test/foo /home/ravi/test:0x0541 i=-4(%bp):s32 > > > > $ ./perf record -e

Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization

On Wed, 3 Aug 2016 14:28:45 +0530 Ravi Bangoria wrote: > Function prologue prepares stack and registers before executing function > logic. When target program is compiled without optimization, function > parameter information is only valid after prologue. When

Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization

On Wed, 3 Aug 2016 14:28:45 +0530 Ravi Bangoria wrote: > Function prologue prepares stack and registers before executing function > logic. When target program is compiled without optimization, function > parameter information is only valid after prologue. When we probe entrypc > of the

Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization

Hi Ravi, On Sat, 13 Aug 2016 19:15:53 +0530 Ravi Bangoria wrote: > Hi Masami, Arnaldo, > > Any updates on this? Oops, sorry I missed this mail, I was on vacation... > > Thanks, > Ravi > > On Wednesday 03 August 2016 02:28 PM, Ravi Bangoria wrote: > >

Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization

Hi Ravi, On Sat, 13 Aug 2016 19:15:53 +0530 Ravi Bangoria wrote: > Hi Masami, Arnaldo, > > Any updates on this? Oops, sorry I missed this mail, I was on vacation... > > Thanks, > Ravi > > On Wednesday 03 August 2016 02:28 PM, Ravi Bangoria wrote: > > Function prologue prepares stack and

Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization

On 2016/08/03 02:28PM, Ravi Bangoria wrote: > Function prologue prepares stack and registers before executing function > logic. When target program is compiled without optimization, function > parameter information is only valid after prologue. When we probe entrypc > of the function, and try to

Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization

On 2016/08/03 02:28PM, Ravi Bangoria wrote: > Function prologue prepares stack and registers before executing function > logic. When target program is compiled without optimization, function > parameter information is only valid after prologue. When we probe entrypc > of the function, and try to

Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization

Hi Masami, Arnaldo, Any updates on this? Thanks, Ravi On Wednesday 03 August 2016 02:28 PM, Ravi Bangoria wrote: > Function prologue prepares stack and registers before executing function > logic. When target program is compiled without optimization, function > parameter information is only

Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization

Hi Masami, Arnaldo, Any updates on this? Thanks, Ravi On Wednesday 03 August 2016 02:28 PM, Ravi Bangoria wrote: > Function prologue prepares stack and registers before executing function > logic. When target program is compiled without optimization, function > parameter information is only

[PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization

Function prologue prepares stack and registers before executing function logic. When target program is compiled without optimization, function parameter information is only valid after prologue. When we probe entrypc of the function, and try to record function parameter, it contains garbage value.

[PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization

Function prologue prepares stack and registers before executing function logic. When target program is compiled without optimization, function parameter information is only valid after prologue. When we probe entrypc of the function, and try to record function parameter, it contains garbage value.