Re: [PATCH v2 2/3] clk: sprd: Check error only for devm_regmap_init_mmio()

[Stephen Boyd]

Quoting Chunyan Zhang (2019-05-21 18:15:02)
> The function devm_regmap_init_mmio() wouldn't return NULL pointer for
> now, so only need to ensure the return value is not an error code.
> 
> Signed-off-by: Chunyan Zhang 
> ---

Applied to clk-next

Re: [PATCH v2 2/3] clk: sprd: Check error only for devm_regmap_init_mmio()

[Baolin Wang]

On Wed, 22 May 2019 at 09:15, Chunyan Zhang  wrote:
>
> The function devm_regmap_init_mmio() wouldn't return NULL pointer for
> now, so only need to ensure the return value is not an error code.
>
> Signed-off-by: Chunyan Zhang 

Reviewed-by: Baolin Wang 

> ---
>  drivers/clk/sprd/common.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/sprd/common.c b/drivers/clk/sprd/common.c
> index 9ce690999eaa..a5bdca1de5d0 100644
> --- a/drivers/clk/sprd/common.c
> +++ b/drivers/clk/sprd/common.c
> @@ -58,7 +58,7 @@ int sprd_clk_regmap_init(struct platform_device *pdev,
>
> regmap = devm_regmap_init_mmio(>dev, base,
>_regmap_config);
> -   if (IS_ERR_OR_NULL(regmap)) {
> +   if (IS_ERR(regmap)) {
> pr_err("failed to init regmap\n");
> return PTR_ERR(regmap);
> }
> --
> 2.17.1
>


-- 
Baolin Wang
Best Regards

[PATCH v2 2/3] clk: sprd: Check error only for devm_regmap_init_mmio()

[Chunyan Zhang]

The function devm_regmap_init_mmio() wouldn't return NULL pointer for
now, so only need to ensure the return value is not an error code.

Signed-off-by: Chunyan Zhang 
---
 drivers/clk/sprd/common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/sprd/common.c b/drivers/clk/sprd/common.c
index 9ce690999eaa..a5bdca1de5d0 100644
--- a/drivers/clk/sprd/common.c
+++ b/drivers/clk/sprd/common.c
@@ -58,7 +58,7 @@ int sprd_clk_regmap_init(struct platform_device *pdev,
 
regmap = devm_regmap_init_mmio(>dev, base,
   _regmap_config);
-   if (IS_ERR_OR_NULL(regmap)) {
+   if (IS_ERR(regmap)) {
pr_err("failed to init regmap\n");
return PTR_ERR(regmap);
}
-- 
2.17.1