Re: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()
On Thu, Jun 2, 2016 at 12:26 AM, Geliang Tangwrote: > On Wed, Nov 11, 2015 at 03:24:33PM -0800, Kees Cook wrote: >> On Wed, Nov 11, 2015 at 3:23 PM, Luck, Tony wrote: >> module_init(efivars_pstore_init); >> >>> >> >>> Looks OK to me. Kees, are you picking this up? >> >> >> >> I can, though usually it goes through Tony. >> > >> > Can I count that as "Acked-by" from both of you? >> >> Yup, sorry. I thought I'd acked them already. :) My bad! >> >> Acked-by: Kees Cook >> > > Hi Kees, > > Could you please apply these three pending patches for me? > I think they are still valid. Thank you very much. Yes, added to my for-next tree now. Thanks! -Kees -- Kees Cook Chrome OS & Brillo Security
Re: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()
On Thu, Jun 2, 2016 at 12:26 AM, Geliang Tang wrote: > On Wed, Nov 11, 2015 at 03:24:33PM -0800, Kees Cook wrote: >> On Wed, Nov 11, 2015 at 3:23 PM, Luck, Tony wrote: >> module_init(efivars_pstore_init); >> >>> >> >>> Looks OK to me. Kees, are you picking this up? >> >> >> >> I can, though usually it goes through Tony. >> > >> > Can I count that as "Acked-by" from both of you? >> >> Yup, sorry. I thought I'd acked them already. :) My bad! >> >> Acked-by: Kees Cook >> > > Hi Kees, > > Could you please apply these three pending patches for me? > I think they are still valid. Thank you very much. Yes, added to my for-next tree now. Thanks! -Kees -- Kees Cook Chrome OS & Brillo Security
Re: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()
On Wed, Nov 11, 2015 at 03:24:33PM -0800, Kees Cook wrote: > On Wed, Nov 11, 2015 at 3:23 PM, Luck, Tonywrote: > module_init(efivars_pstore_init); > >>> > >>> Looks OK to me. Kees, are you picking this up? > >> > >> I can, though usually it goes through Tony. > > > > Can I count that as "Acked-by" from both of you? > > Yup, sorry. I thought I'd acked them already. :) My bad! > > Acked-by: Kees Cook > Hi Kees, Could you please apply these three pending patches for me? I think they are still valid. Thank you very much. -Geliang > -Kees > > -- > Kees Cook > Chrome OS Security
Re: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()
On Wed, Nov 11, 2015 at 03:24:33PM -0800, Kees Cook wrote: > On Wed, Nov 11, 2015 at 3:23 PM, Luck, Tony wrote: > module_init(efivars_pstore_init); > >>> > >>> Looks OK to me. Kees, are you picking this up? > >> > >> I can, though usually it goes through Tony. > > > > Can I count that as "Acked-by" from both of you? > > Yup, sorry. I thought I'd acked them already. :) My bad! > > Acked-by: Kees Cook > Hi Kees, Could you please apply these three pending patches for me? I think they are still valid. Thank you very much. -Geliang > -Kees > > -- > Kees Cook > Chrome OS Security
Re: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()
On Wed, 11 Nov, at 11:23:15PM, Luck, Tony wrote: > >>> module_init(efivars_pstore_init); > >> > >> Looks OK to me. Kees, are you picking this up? > > > > I can, though usually it goes through Tony. > > Can I count that as "Acked-by" from both of you? Yep, Acked-by: Matt Fleming -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()
On Wed, 11 Nov, at 11:23:15PM, Luck, Tony wrote: > >>> module_init(efivars_pstore_init); > >> > >> Looks OK to me. Kees, are you picking this up? > > > > I can, though usually it goes through Tony. > > Can I count that as "Acked-by" from both of you? Yep, Acked-by: Matt Fleming-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()
On Wed, Nov 11, 2015 at 3:23 PM, Luck, Tony wrote: module_init(efivars_pstore_init); >>> >>> Looks OK to me. Kees, are you picking this up? >> >> I can, though usually it goes through Tony. > > Can I count that as "Acked-by" from both of you? Yup, sorry. I thought I'd acked them already. :) My bad! Acked-by: Kees Cook -Kees -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()
>>> module_init(efivars_pstore_init); >> >> Looks OK to me. Kees, are you picking this up? > > I can, though usually it goes through Tony. Can I count that as "Acked-by" from both of you? -Tony
Re: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()
On Wed, Nov 11, 2015 at 8:59 AM, Matt Fleming wrote: > On Sat, 07 Nov, at 12:43:48PM, Geliang Tang wrote: >> The original efivars_pstore_exit() is empty. I >> 1) add a bufsize check statement. >> 2) call pstore_unregister as it is defined now. >> 3) free the memory and set bufsize to 0. >> >> Signed-off-by: Geliang Tang >> --- >> drivers/firmware/efi/efi-pstore.c | 7 +++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/drivers/firmware/efi/efi-pstore.c >> b/drivers/firmware/efi/efi-pstore.c >> index eac76a7..62d57d8 100644 >> --- a/drivers/firmware/efi/efi-pstore.c >> +++ b/drivers/firmware/efi/efi-pstore.c >> @@ -393,6 +393,13 @@ static __init int efivars_pstore_init(void) >> >> static __exit void efivars_pstore_exit(void) >> { >> + if (!efi_pstore_info.bufsize) >> + return; >> + >> + pstore_unregister(_pstore_info); >> + kfree(efi_pstore_info.buf); >> + efi_pstore_info.buf = NULL; >> + efi_pstore_info.bufsize = 0; >> } >> >> module_init(efivars_pstore_init); > > Looks OK to me. Kees, are you picking this up? I can, though usually it goes through Tony. -Kees -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()
On Sat, 07 Nov, at 12:43:48PM, Geliang Tang wrote: > The original efivars_pstore_exit() is empty. I > 1) add a bufsize check statement. > 2) call pstore_unregister as it is defined now. > 3) free the memory and set bufsize to 0. > > Signed-off-by: Geliang Tang > --- > drivers/firmware/efi/efi-pstore.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/firmware/efi/efi-pstore.c > b/drivers/firmware/efi/efi-pstore.c > index eac76a7..62d57d8 100644 > --- a/drivers/firmware/efi/efi-pstore.c > +++ b/drivers/firmware/efi/efi-pstore.c > @@ -393,6 +393,13 @@ static __init int efivars_pstore_init(void) > > static __exit void efivars_pstore_exit(void) > { > + if (!efi_pstore_info.bufsize) > + return; > + > + pstore_unregister(_pstore_info); > + kfree(efi_pstore_info.buf); > + efi_pstore_info.buf = NULL; > + efi_pstore_info.bufsize = 0; > } > > module_init(efivars_pstore_init); Looks OK to me. Kees, are you picking this up? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()
On Sat, 07 Nov, at 12:43:48PM, Geliang Tang wrote: > The original efivars_pstore_exit() is empty. I > 1) add a bufsize check statement. > 2) call pstore_unregister as it is defined now. > 3) free the memory and set bufsize to 0. > > Signed-off-by: Geliang Tang> --- > drivers/firmware/efi/efi-pstore.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/firmware/efi/efi-pstore.c > b/drivers/firmware/efi/efi-pstore.c > index eac76a7..62d57d8 100644 > --- a/drivers/firmware/efi/efi-pstore.c > +++ b/drivers/firmware/efi/efi-pstore.c > @@ -393,6 +393,13 @@ static __init int efivars_pstore_init(void) > > static __exit void efivars_pstore_exit(void) > { > + if (!efi_pstore_info.bufsize) > + return; > + > + pstore_unregister(_pstore_info); > + kfree(efi_pstore_info.buf); > + efi_pstore_info.buf = NULL; > + efi_pstore_info.bufsize = 0; > } > > module_init(efivars_pstore_init); Looks OK to me. Kees, are you picking this up? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()
>>> module_init(efivars_pstore_init); >> >> Looks OK to me. Kees, are you picking this up? > > I can, though usually it goes through Tony. Can I count that as "Acked-by" from both of you? -Tony
Re: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()
On Wed, Nov 11, 2015 at 8:59 AM, Matt Flemingwrote: > On Sat, 07 Nov, at 12:43:48PM, Geliang Tang wrote: >> The original efivars_pstore_exit() is empty. I >> 1) add a bufsize check statement. >> 2) call pstore_unregister as it is defined now. >> 3) free the memory and set bufsize to 0. >> >> Signed-off-by: Geliang Tang >> --- >> drivers/firmware/efi/efi-pstore.c | 7 +++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/drivers/firmware/efi/efi-pstore.c >> b/drivers/firmware/efi/efi-pstore.c >> index eac76a7..62d57d8 100644 >> --- a/drivers/firmware/efi/efi-pstore.c >> +++ b/drivers/firmware/efi/efi-pstore.c >> @@ -393,6 +393,13 @@ static __init int efivars_pstore_init(void) >> >> static __exit void efivars_pstore_exit(void) >> { >> + if (!efi_pstore_info.bufsize) >> + return; >> + >> + pstore_unregister(_pstore_info); >> + kfree(efi_pstore_info.buf); >> + efi_pstore_info.buf = NULL; >> + efi_pstore_info.bufsize = 0; >> } >> >> module_init(efivars_pstore_init); > > Looks OK to me. Kees, are you picking this up? I can, though usually it goes through Tony. -Kees -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()
On Wed, Nov 11, 2015 at 3:23 PM, Luck, Tonywrote: module_init(efivars_pstore_init); >>> >>> Looks OK to me. Kees, are you picking this up? >> >> I can, though usually it goes through Tony. > > Can I count that as "Acked-by" from both of you? Yup, sorry. I thought I'd acked them already. :) My bad! Acked-by: Kees Cook -Kees -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()
The original efivars_pstore_exit() is empty. I 1) add a bufsize check statement. 2) call pstore_unregister as it is defined now. 3) free the memory and set bufsize to 0. Signed-off-by: Geliang Tang --- drivers/firmware/efi/efi-pstore.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/firmware/efi/efi-pstore.c b/drivers/firmware/efi/efi-pstore.c index eac76a7..62d57d8 100644 --- a/drivers/firmware/efi/efi-pstore.c +++ b/drivers/firmware/efi/efi-pstore.c @@ -393,6 +393,13 @@ static __init int efivars_pstore_init(void) static __exit void efivars_pstore_exit(void) { + if (!efi_pstore_info.bufsize) + return; + + pstore_unregister(_pstore_info); + kfree(efi_pstore_info.buf); + efi_pstore_info.buf = NULL; + efi_pstore_info.bufsize = 0; } module_init(efivars_pstore_init); -- 2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()
The original efivars_pstore_exit() is empty. I 1) add a bufsize check statement. 2) call pstore_unregister as it is defined now. 3) free the memory and set bufsize to 0. Signed-off-by: Geliang Tang--- drivers/firmware/efi/efi-pstore.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/firmware/efi/efi-pstore.c b/drivers/firmware/efi/efi-pstore.c index eac76a7..62d57d8 100644 --- a/drivers/firmware/efi/efi-pstore.c +++ b/drivers/firmware/efi/efi-pstore.c @@ -393,6 +393,13 @@ static __init int efivars_pstore_init(void) static __exit void efivars_pstore_exit(void) { + if (!efi_pstore_info.bufsize) + return; + + pstore_unregister(_pstore_info); + kfree(efi_pstore_info.buf); + efi_pstore_info.buf = NULL; + efi_pstore_info.bufsize = 0; } module_init(efivars_pstore_init); -- 2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/