Re: [PATCH v2 2/3] kvm, vmx: move register clearing out of assembly path

On Mon, 2018-10-29 at 10:26 -0700, Sean Christopherson wrote: > I think it's a good idea to explicitly call out that clearing the > GPRs > is done to prevent speculative use.  Simply stating that we don't > want > to let guest register values survive doesn't explain *why*. > > What about: > >    

Re: [PATCH v2 2/3] kvm, vmx: move register clearing out of assembly path

On Mon, 2018-10-29 at 10:26 -0700, Sean Christopherson wrote: > I think it's a good idea to explicitly call out that clearing the > GPRs > is done to prevent speculative use.  Simply stating that we don't > want > to let guest register values survive doesn't explain *why*. > > What about: > >    

Re: [PATCH v2 2/3] kvm, vmx: move register clearing out of assembly path

On Mon, Oct 29, 2018 at 04:40:43PM +0100, Julian Stecklina wrote: > Split the security related register clearing out of the large inline > assembly VM entry path. This results in two slightly less complicated > inline assembly statements, where it is clearer what each one does. > > Signed-off-by:

Re: [PATCH v2 2/3] kvm, vmx: move register clearing out of assembly path

On Mon, Oct 29, 2018 at 04:40:43PM +0100, Julian Stecklina wrote: > Split the security related register clearing out of the large inline > assembly VM entry path. This results in two slightly less complicated > inline assembly statements, where it is clearer what each one does. > > Signed-off-by:

[PATCH v2 2/3] kvm, vmx: move register clearing out of assembly path

Split the security related register clearing out of the large inline assembly VM entry path. This results in two slightly less complicated inline assembly statements, where it is clearer what each one does. Signed-off-by: Julian Stecklina Reviewed-by: Jan H. Schönherr Reviewed-by: Konrad Jan

[PATCH v2 2/3] kvm, vmx: move register clearing out of assembly path

Split the security related register clearing out of the large inline assembly VM entry path. This results in two slightly less complicated inline assembly statements, where it is clearer what each one does. Signed-off-by: Julian Stecklina Reviewed-by: Jan H. Schönherr Reviewed-by: Konrad Jan