Re: [PATCH v2 2/3] nvme-pci: Add support for variable IO SQ element size

2019-07-17 Thread Benjamin Herrenschmidt
On Wed, 2019-07-17 at 20:51 +0900, Minwoo Im wrote: > - struct nvme_command *sq_cmds; > > + void *sq_cmds; > > It would be great if it can remain the existing data type for the > SQEs... But I'm fine with this also. > > It looks good to me. I changed it on purpose so we aren't tempted to

Re: [PATCH v2 2/3] nvme-pci: Add support for variable IO SQ element size

2019-07-17 Thread Minwoo Im
On 19-07-17 10:45:26, Benjamin Herrenschmidt wrote: > The size of a submission queue element should always be 6 (64 bytes) > by spec. > > However some controllers such as Apple's are not properly implementing > the standard and require a different size. > > This provides the ground work for the

[PATCH v2 2/3] nvme-pci: Add support for variable IO SQ element size

2019-07-16 Thread Benjamin Herrenschmidt
The size of a submission queue element should always be 6 (64 bytes) by spec. However some controllers such as Apple's are not properly implementing the standard and require a different size. This provides the ground work for the subsequent quirks for these controllers. Signed-off-by: Benjamin