Re: [PATCH v2 2/3] soundwire: SDCA: add helper macro to access controls

2020-09-16 Thread Vinod Koul
On 14-09-20, 09:44, Pierre-Louis Bossart wrote: > > For LSB bits, I dont think this is an issue. I expect it to work, for > > example: > > #define CONTROL_LSB_MASK GENMASK(2, 0) > > foo |= u32_encode_bits(control, CONTROL_LSB_MASK); > > > > would mask the control value and program that

Re: [PATCH v2 2/3] soundwire: SDCA: add helper macro to access controls

2020-09-16 Thread Pierre-Louis Bossart
On 9/16/20 7:35 AM, Vinod Koul wrote: On 14-09-20, 09:44, Pierre-Louis Bossart wrote: For LSB bits, I dont think this is an issue. I expect it to work, for example: #define CONTROL_LSB_MASK GENMASK(2, 0) foo |= u32_encode_bits(control, CONTROL_LSB_MASK); would mask the control

Re: [PATCH v2 2/3] soundwire: SDCA: add helper macro to access controls

2020-09-14 Thread Pierre-Louis Bossart
For LSB bits, I dont think this is an issue. I expect it to work, for example: #define CONTROL_LSB_MASK GENMASK(2, 0) foo |= u32_encode_bits(control, CONTROL_LSB_MASK); would mask the control value and program that in specific bitfeild. But for MSB bits, I am not sure above will

Re: [PATCH v2 2/3] soundwire: SDCA: add helper macro to access controls

2020-09-13 Thread Vinod Koul
Hi Pierre, On 11-09-20, 09:50, Pierre-Louis Bossart wrote: > > > > > > > > > + * 25 0 (Reserved) > > > > > > > > > + * 24:22 Function Number [2:0] > > > > > > > > > + * 21 Entity[6] > > > > > > > > > + * 20:19 Control Selector[5:4] > > > > > >

Re: [PATCH v2 2/3] soundwire: SDCA: add helper macro to access controls

2020-09-11 Thread Pierre-Louis Bossart
Hi Vinod, + * 25 0 (Reserved) + * 24:22 Function Number [2:0] + * 21 Entity[6] + * 20:19 Control Selector[5:4] + * 18 0 (Reserved) + * 17:15 Control Number[5:3] + * 14 Next + * 13

Re: [PATCH v2 2/3] soundwire: SDCA: add helper macro to access controls

2020-09-11 Thread Vinod Koul
On 10-09-20, 08:53, Pierre-Louis Bossart wrote: > > > On 9/10/20 1:22 AM, Vinod Koul wrote: > > On 09-09-20, 08:48, Pierre-Louis Bossart wrote: > > > > > > > > > > + * 25 0 (Reserved) > > > > > > > + * 24:22 Function Number [2:0] > > > > > > > + * 21

Re: [PATCH v2 2/3] soundwire: SDCA: add helper macro to access controls

2020-09-10 Thread Vinod Koul
On 09-09-20, 08:48, Pierre-Louis Bossart wrote: > > > > > > + * 25 0 (Reserved) > > > > > + * 24:22 Function Number [2:0] > > > > > + * 21 Entity[6] > > > > > + * 20:19 Control Selector[5:4] > > > > > + * 18 0 (Reserved) > > > >

Re: [PATCH v2 2/3] soundwire: SDCA: add helper macro to access controls

2020-09-09 Thread Vinod Koul
On 08-09-20, 08:33, Pierre-Louis Bossart wrote: > Thanks for the review Vinod, > > > This is good, thanks for adding it in changelog. Can you also add this > > description to Documentation (that can come as an individual patch), > > ok > > > > +/* > > > + * v1.2 device - SDCA address mapping >

Re: [PATCH v2 2/3] soundwire: SDCA: add helper macro to access controls

2020-09-08 Thread Pierre-Louis Bossart
Thanks for the review Vinod, This is good, thanks for adding it in changelog. Can you also add this description to Documentation (that can come as an individual patch), ok +/* + * v1.2 device - SDCA address mapping + * + * Spec definition + * BitsContents + * 31

Re: [PATCH v2 2/3] soundwire: SDCA: add helper macro to access controls

2020-09-03 Thread Vinod Koul
On 01-09-20, 11:22, Pierre-Louis Bossart wrote: > The upcoming SDCA (SoundWire Device Class Audio) specification defines > a hierarchical encoding to interface with Class-defined capabilities. > > The specification is not yet accessible to the general public but this > information is released

[PATCH v2 2/3] soundwire: SDCA: add helper macro to access controls

2020-09-01 Thread Pierre-Louis Bossart
The upcoming SDCA (SoundWire Device Class Audio) specification defines a hierarchical encoding to interface with Class-defined capabilities. The specification is not yet accessible to the general public but this information is released with explicit permission from the MIPI Board to avoid delays