Re: [PATCH v2 2/4] Staging: rts5208: Replace custom macro with print_hex_dump_bytes

2014-07-08 Thread Joe Perches
On Tue, 2014-07-08 at 11:45 +0300, Dan Carpenter wrote: > On Tue, Jul 08, 2014 at 08:23:02AM +0200, Fabio Falzoi wrote: > I'm gonna fix it, thanks. > And leave out the semi-colon as well. another way to do this is: static void rtsx_hex_dump(void *buf, size_t len) { #if DEBUG

Re: [PATCH v2 2/4] Staging: rts5208: Replace custom macro with print_hex_dump_bytes

2014-07-08 Thread Dan Carpenter
On Tue, Jul 08, 2014 at 08:23:02AM +0200, Fabio Falzoi wrote: > > > > Hi, > > here exist some checkpatch errors. > > > > Best Regards. > > micky. > > Yes, you'are right, I'm gonna fix it, thanks. And leave out the semi-colon as well. regards, dan carpenter -- To unsubscribe from this list:

Re: [PATCH v2 2/4] Staging: rts5208: Replace custom macro with print_hex_dump_bytes

2014-07-08 Thread Fabio Falzoi
> > Hi, > here exist some checkpatch errors. > > Best Regards. > micky. Yes, you'are right, I'm gonna fix it, thanks. On Tue, Jul 8, 2014 at 4:12 AM, micky wrote: > On 07/07/2014 03:10 PM, Fabio Falzoi wrote: >> >> Use print_hex_dump_bytes to have memory properly dumped only when >> DEBUG is

Re: [PATCH v2 2/4] Staging: rts5208: Replace custom macro with print_hex_dump_bytes

2014-07-08 Thread Fabio Falzoi
Hi, here exist some checkpatch errors. Best Regards. micky. Yes, you'are right, I'm gonna fix it, thanks. On Tue, Jul 8, 2014 at 4:12 AM, micky micky_ch...@realsil.com.cn wrote: On 07/07/2014 03:10 PM, Fabio Falzoi wrote: Use print_hex_dump_bytes to have memory properly dumped only when

Re: [PATCH v2 2/4] Staging: rts5208: Replace custom macro with print_hex_dump_bytes

2014-07-08 Thread Dan Carpenter
On Tue, Jul 08, 2014 at 08:23:02AM +0200, Fabio Falzoi wrote: Hi, here exist some checkpatch errors. Best Regards. micky. Yes, you'are right, I'm gonna fix it, thanks. And leave out the semi-colon as well. regards, dan carpenter -- To unsubscribe from this list: send the line

Re: [PATCH v2 2/4] Staging: rts5208: Replace custom macro with print_hex_dump_bytes

2014-07-08 Thread Joe Perches
On Tue, 2014-07-08 at 11:45 +0300, Dan Carpenter wrote: On Tue, Jul 08, 2014 at 08:23:02AM +0200, Fabio Falzoi wrote: I'm gonna fix it, thanks. And leave out the semi-colon as well. another way to do this is: static void rtsx_hex_dump(void *buf, size_t len) { #if DEBUG

Re: [PATCH v2 2/4] Staging: rts5208: Replace custom macro with print_hex_dump_bytes

2014-07-07 Thread micky
On 07/07/2014 03:10 PM, Fabio Falzoi wrote: Use print_hex_dump_bytes to have memory properly dumped only when DEBUG is defined. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/ms.c| 4 ++-- drivers/staging/rts5208/rtsx_chip.c | 4 ++-- drivers/staging/rts5208/rtsx_scsi.c

[PATCH v2 2/4] Staging: rts5208: Replace custom macro with print_hex_dump_bytes

2014-07-07 Thread Fabio Falzoi
Use print_hex_dump_bytes to have memory properly dumped only when DEBUG is defined. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/ms.c| 4 ++-- drivers/staging/rts5208/rtsx_chip.c | 4 ++-- drivers/staging/rts5208/rtsx_scsi.c | 9 - drivers/staging/rts5208/sd.c

[PATCH v2 2/4] Staging: rts5208: Replace custom macro with print_hex_dump_bytes

2014-07-07 Thread Fabio Falzoi
Use print_hex_dump_bytes to have memory properly dumped only when DEBUG is defined. Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com --- drivers/staging/rts5208/ms.c| 4 ++-- drivers/staging/rts5208/rtsx_chip.c | 4 ++-- drivers/staging/rts5208/rtsx_scsi.c | 9 -

Re: [PATCH v2 2/4] Staging: rts5208: Replace custom macro with print_hex_dump_bytes

2014-07-07 Thread micky
On 07/07/2014 03:10 PM, Fabio Falzoi wrote: Use print_hex_dump_bytes to have memory properly dumped only when DEBUG is defined. Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com --- drivers/staging/rts5208/ms.c| 4 ++-- drivers/staging/rts5208/rtsx_chip.c | 4 ++--