Re: [PATCH v2 2/5] x86/uprobes: implement x86 specific arch_uprobe_*_step

2012-08-14 Thread Oleg Nesterov
On 08/14, Sebastian Andrzej Siewior wrote: > > On 08/13/2012 03:24 PM, Oleg Nesterov wrote: >> >> this patch still adds restore_flags into arch_uprobe_task. > > Yes, but OOPS. Yes, we need a new member in ->utask now to record the state of TIF_SINGLESTEP (X86_EFLAGS_TF actually). I meant that,

Re: [PATCH v2 2/5] x86/uprobes: implement x86 specific arch_uprobe_*_step

2012-08-14 Thread Sebastian Andrzej Siewior
On 08/13/2012 03:24 PM, Oleg Nesterov wrote: On 08/09, Sebastian Andrzej Siewior wrote: v1..v2: re-use auprobe->fixups for fixups Yes, but @@ -46,6 +46,8 @@ struct arch_uprobe_task { #ifdef CONFIG_X86_64 unsigned long saved_scratch_register; #endif +#define

Re: [PATCH v2 2/5] x86/uprobes: implement x86 specific arch_uprobe_*_step

2012-08-14 Thread Sebastian Andrzej Siewior
On 08/13/2012 03:24 PM, Oleg Nesterov wrote: On 08/09, Sebastian Andrzej Siewior wrote: v1..v2: re-use auprobe-fixups for fixups Yes, but @@ -46,6 +46,8 @@ struct arch_uprobe_task { #ifdef CONFIG_X86_64 unsigned long saved_scratch_register; #endif +#define

Re: [PATCH v2 2/5] x86/uprobes: implement x86 specific arch_uprobe_*_step

2012-08-14 Thread Oleg Nesterov
On 08/14, Sebastian Andrzej Siewior wrote: On 08/13/2012 03:24 PM, Oleg Nesterov wrote: this patch still adds restore_flags into arch_uprobe_task. Yes, but OOPS. Yes, we need a new member in -utask now to record the state of TIF_SINGLESTEP (X86_EFLAGS_TF actually). I meant that, since the

Re: [PATCH v2 2/5] x86/uprobes: implement x86 specific arch_uprobe_*_step

2012-08-13 Thread Oleg Nesterov
On 08/09, Sebastian Andrzej Siewior wrote: > > v1..v2: re-use auprobe->fixups for fixups Yes, but > @@ -46,6 +46,8 @@ struct arch_uprobe_task { > #ifdef CONFIG_X86_64 > unsigned long saved_scratch_register; > #endif > +#define UPROBE_CLEAR_TF (1 <<

Re: [PATCH v2 2/5] x86/uprobes: implement x86 specific arch_uprobe_*_step

2012-08-13 Thread Oleg Nesterov
On 08/09, Sebastian Andrzej Siewior wrote: v1..v2: re-use auprobe-fixups for fixups Yes, but @@ -46,6 +46,8 @@ struct arch_uprobe_task { #ifdef CONFIG_X86_64 unsigned long saved_scratch_register; #endif +#define UPROBE_CLEAR_TF (1 0) +

[PATCH v2 2/5] x86/uprobes: implement x86 specific arch_uprobe_*_step

2012-08-09 Thread Sebastian Andrzej Siewior
The arch specific implementation behaves like user_enable_single_step() except that it does not disable single stepping if it was already enabled. This allows the debugger to single step over an uprobe. The state of block stepping is not restored. It makes only sense together with TF and if that

[PATCH v2 2/5] x86/uprobes: implement x86 specific arch_uprobe_*_step

2012-08-09 Thread Sebastian Andrzej Siewior
The arch specific implementation behaves like user_enable_single_step() except that it does not disable single stepping if it was already enabled. This allows the debugger to single step over an uprobe. The state of block stepping is not restored. It makes only sense together with TF and if that