Re: [PATCH v2 2/6] drm/virtio: use struct to pass params to virtio_gpu_object_create()

2019-02-01 Thread Gerd Hoffmann
> > - ret = virtio_gpu_gem_create(file_priv, dev, args->size, , > > + params.pinned = false, > > You have a comma here, but assigning to false isn't really necessary > since the struct is zeroed. Same goes for the same assignment further down. Hmm, yes, but it likewise isn't used, so I think

Re: [PATCH v2 2/6] drm/virtio: use struct to pass params to virtio_gpu_object_create()

2019-01-31 Thread Noralf Trønnes
Den 30.01.2019 10.43, skrev Gerd Hoffmann: > Create virtio_gpu_object_params, use that to pass object parameters to > virtio_gpu_object_create. This is just the first step, followup patches > will add more parameters to the struct. The plan is to use the struct > for all object parameters. >

[PATCH v2 2/6] drm/virtio: use struct to pass params to virtio_gpu_object_create()

2019-01-30 Thread Gerd Hoffmann
Create virtio_gpu_object_params, use that to pass object parameters to virtio_gpu_object_create. This is just the first step, followup patches will add more parameters to the struct. The plan is to use the struct for all object parameters. Also drop unused "kernel" parameter for