Re: [PATCH v2 2/6] perf report: Caculate and return the branch counting in callchain

2016-10-25 Thread Arnaldo Carvalho de Melo
Em Fri, Oct 21, 2016 at 08:23:41AM +0800, Jin, Yao escreveu: > Hi Andi, Hi Nilay, > > Thanks so much for your comments! > > I will upgrade the patch to just display the count for abort. Ok, waiting for that then, - Arnaldo > Thanks > > Jin Yao > > On 10/21/2016 2:20 AM, Andi Kleen wrote: >

Re: [PATCH v2 2/6] perf report: Caculate and return the branch counting in callchain

2016-10-25 Thread Arnaldo Carvalho de Melo
Em Fri, Oct 21, 2016 at 08:23:41AM +0800, Jin, Yao escreveu: > Hi Andi, Hi Nilay, > > Thanks so much for your comments! > > I will upgrade the patch to just display the count for abort. Ok, waiting for that then, - Arnaldo > Thanks > > Jin Yao > > On 10/21/2016 2:20 AM, Andi Kleen wrote: >

Re: [PATCH v2 2/6] perf report: Caculate and return the branch counting in callchain

2016-10-20 Thread Jin, Yao
Hi Andi, Hi Nilay, Thanks so much for your comments! I will upgrade the patch to just display the count for abort. Thanks Jin Yao On 10/21/2016 2:20 AM, Andi Kleen wrote: OK, I am more confused now. Are you predicting some quantity related to transactions? Why would you divide abort count

Re: [PATCH v2 2/6] perf report: Caculate and return the branch counting in callchain

2016-10-20 Thread Jin, Yao
Hi Andi, Hi Nilay, Thanks so much for your comments! I will upgrade the patch to just display the count for abort. Thanks Jin Yao On 10/21/2016 2:20 AM, Andi Kleen wrote: OK, I am more confused now. Are you predicting some quantity related to transactions? Why would you divide abort count

Re: [PATCH v2 2/6] perf report: Caculate and return the branch counting in callchain

2016-10-20 Thread Andi Kleen
> OK, I am more confused now. Are you predicting some quantity related > to transactions? Why would you divide abort count by branch count? > Further, I just looked at patch 6/6. It has the following text: > > + Also show with some branch flags that can be: > + - Predicted: display the average

Re: [PATCH v2 2/6] perf report: Caculate and return the branch counting in callchain

2016-10-20 Thread Andi Kleen
> OK, I am more confused now. Are you predicting some quantity related > to transactions? Why would you divide abort count by branch count? > Further, I just looked at patch 6/6. It has the following text: > > + Also show with some branch flags that can be: > + - Predicted: display the average

Re: [PATCH v2 2/6] perf report: Caculate and return the branch counting in callchain

2016-10-20 Thread Nilay Vaish
On 20 October 2016 at 11:48, Andi Kleen wrote: > On Thu, Oct 20, 2016 at 11:41:11AM -0500, Nilay Vaish wrote: >> On 19 October 2016 at 17:01, Jin Yao wrote: >> > diff --git a/tools/perf/util/callchain.h b/tools/perf/util/callchain.h >> > index

Re: [PATCH v2 2/6] perf report: Caculate and return the branch counting in callchain

2016-10-20 Thread Nilay Vaish
On 20 October 2016 at 11:48, Andi Kleen wrote: > On Thu, Oct 20, 2016 at 11:41:11AM -0500, Nilay Vaish wrote: >> On 19 October 2016 at 17:01, Jin Yao wrote: >> > diff --git a/tools/perf/util/callchain.h b/tools/perf/util/callchain.h >> > index 40ecf25..4f6bf6c 100644 >> > ---

Re: [PATCH v2 2/6] perf report: Caculate and return the branch counting in callchain

2016-10-20 Thread Andi Kleen
On Thu, Oct 20, 2016 at 11:41:11AM -0500, Nilay Vaish wrote: > On 19 October 2016 at 17:01, Jin Yao wrote: > > diff --git a/tools/perf/util/callchain.h b/tools/perf/util/callchain.h > > index 40ecf25..4f6bf6c 100644 > > --- a/tools/perf/util/callchain.h > > +++

Re: [PATCH v2 2/6] perf report: Caculate and return the branch counting in callchain

2016-10-20 Thread Andi Kleen
On Thu, Oct 20, 2016 at 11:41:11AM -0500, Nilay Vaish wrote: > On 19 October 2016 at 17:01, Jin Yao wrote: > > diff --git a/tools/perf/util/callchain.h b/tools/perf/util/callchain.h > > index 40ecf25..4f6bf6c 100644 > > --- a/tools/perf/util/callchain.h > > +++ b/tools/perf/util/callchain.h > >

Re: [PATCH v2 2/6] perf report: Caculate and return the branch counting in callchain

2016-10-20 Thread Nilay Vaish
On 19 October 2016 at 17:01, Jin Yao wrote: > diff --git a/tools/perf/util/callchain.h b/tools/perf/util/callchain.h > index 40ecf25..4f6bf6c 100644 > --- a/tools/perf/util/callchain.h > +++ b/tools/perf/util/callchain.h > @@ -115,6 +115,10 @@ struct callchain_list { >

Re: [PATCH v2 2/6] perf report: Caculate and return the branch counting in callchain

2016-10-20 Thread Nilay Vaish
On 19 October 2016 at 17:01, Jin Yao wrote: > diff --git a/tools/perf/util/callchain.h b/tools/perf/util/callchain.h > index 40ecf25..4f6bf6c 100644 > --- a/tools/perf/util/callchain.h > +++ b/tools/perf/util/callchain.h > @@ -115,6 +115,10 @@ struct callchain_list { > bool

[PATCH v2 2/6] perf report: Caculate and return the branch counting in callchain

2016-10-19 Thread Jin Yao
Create some branch counters in per callchain list entry. Each counter is for a branch flag. For example, predicted_count counts all the *predicted* branches. The counters get updated by processing the callchain cursor nodes. It also provides functions to retrieve or print the values of counters

[PATCH v2 2/6] perf report: Caculate and return the branch counting in callchain

2016-10-19 Thread Jin Yao
Create some branch counters in per callchain list entry. Each counter is for a branch flag. For example, predicted_count counts all the *predicted* branches. The counters get updated by processing the callchain cursor nodes. It also provides functions to retrieve or print the values of counters