Re: [PATCH v2 2/6] reset: qcom: PDC Global (Power Domain Controller) reset controller

2018-08-28 Thread Matthias Kaehlcke
On Mon, Aug 27, 2018 at 08:02:53PM -0700, Bjorn Andersson wrote: > On Mon 27 Aug 17:22 PDT 2018, Matthias Kaehlcke wrote: > > On Fri, Aug 24, 2018 at 06:48:56PM +0530, Sibi Sankar wrote: > > > diff --git a/drivers/reset/reset-qcom-pdc.c > > > b/drivers/reset/reset-qcom-pdc.c > [..] > > > +struct

Re: [PATCH v2 2/6] reset: qcom: PDC Global (Power Domain Controller) reset controller

2018-08-28 Thread Matthias Kaehlcke
On Mon, Aug 27, 2018 at 08:02:53PM -0700, Bjorn Andersson wrote: > On Mon 27 Aug 17:22 PDT 2018, Matthias Kaehlcke wrote: > > On Fri, Aug 24, 2018 at 06:48:56PM +0530, Sibi Sankar wrote: > > > diff --git a/drivers/reset/reset-qcom-pdc.c > > > b/drivers/reset/reset-qcom-pdc.c > [..] > > > +struct

Re: [PATCH v2 2/6] reset: qcom: PDC Global (Power Domain Controller) reset controller

2018-08-28 Thread Sibi Sankar
Hi Bjorn/Matthias, Thanks for the review, will fix them in the next-respin. On 2018-08-28 08:32, Bjorn Andersson wrote: On Mon 27 Aug 17:22 PDT 2018, Matthias Kaehlcke wrote: On Fri, Aug 24, 2018 at 06:48:56PM +0530, Sibi Sankar wrote: > diff --git a/drivers/reset/reset-qcom-pdc.c

Re: [PATCH v2 2/6] reset: qcom: PDC Global (Power Domain Controller) reset controller

2018-08-28 Thread Sibi Sankar
Hi Bjorn/Matthias, Thanks for the review, will fix them in the next-respin. On 2018-08-28 08:32, Bjorn Andersson wrote: On Mon 27 Aug 17:22 PDT 2018, Matthias Kaehlcke wrote: On Fri, Aug 24, 2018 at 06:48:56PM +0530, Sibi Sankar wrote: > diff --git a/drivers/reset/reset-qcom-pdc.c

Re: [PATCH v2 2/6] reset: qcom: PDC Global (Power Domain Controller) reset controller

2018-08-27 Thread Bjorn Andersson
On Mon 27 Aug 17:22 PDT 2018, Matthias Kaehlcke wrote: > On Fri, Aug 24, 2018 at 06:48:56PM +0530, Sibi Sankar wrote: > > diff --git a/drivers/reset/reset-qcom-pdc.c b/drivers/reset/reset-qcom-pdc.c [..] > > +struct qcom_pdc_desc { > > + const struct regmap_config *config; > > + const struct

Re: [PATCH v2 2/6] reset: qcom: PDC Global (Power Domain Controller) reset controller

2018-08-27 Thread Bjorn Andersson
On Mon 27 Aug 17:22 PDT 2018, Matthias Kaehlcke wrote: > On Fri, Aug 24, 2018 at 06:48:56PM +0530, Sibi Sankar wrote: > > diff --git a/drivers/reset/reset-qcom-pdc.c b/drivers/reset/reset-qcom-pdc.c [..] > > +struct qcom_pdc_desc { > > + const struct regmap_config *config; > > + const struct

Re: [PATCH v2 2/6] reset: qcom: PDC Global (Power Domain Controller) reset controller

2018-08-27 Thread Matthias Kaehlcke
Hi Sibi, On Fri, Aug 24, 2018 at 06:48:56PM +0530, Sibi Sankar wrote: > Add reset controller for SDM845 SoCs to control reset signals provided > by PDC Global for Modem, Compute, Display, GPU, Debug, AOP, Sensors, > Audio, SP and APPS > > Signed-off-by: Sibi Sankar > --- >

Re: [PATCH v2 2/6] reset: qcom: PDC Global (Power Domain Controller) reset controller

2018-08-27 Thread Matthias Kaehlcke
Hi Sibi, On Fri, Aug 24, 2018 at 06:48:56PM +0530, Sibi Sankar wrote: > Add reset controller for SDM845 SoCs to control reset signals provided > by PDC Global for Modem, Compute, Display, GPU, Debug, AOP, Sensors, > Audio, SP and APPS > > Signed-off-by: Sibi Sankar > --- >

[PATCH v2 2/6] reset: qcom: PDC Global (Power Domain Controller) reset controller

2018-08-24 Thread Sibi Sankar
Add reset controller for SDM845 SoCs to control reset signals provided by PDC Global for Modem, Compute, Display, GPU, Debug, AOP, Sensors, Audio, SP and APPS Signed-off-by: Sibi Sankar --- drivers/reset/Kconfig | 9 +++ drivers/reset/Makefile | 1 +

[PATCH v2 2/6] reset: qcom: PDC Global (Power Domain Controller) reset controller

2018-08-24 Thread Sibi Sankar
Add reset controller for SDM845 SoCs to control reset signals provided by PDC Global for Modem, Compute, Display, GPU, Debug, AOP, Sensors, Audio, SP and APPS Signed-off-by: Sibi Sankar --- drivers/reset/Kconfig | 9 +++ drivers/reset/Makefile | 1 +