Re: [PATCH v2 2/7] sched: rework of sched_domain topology definition

2014-03-19 Thread Vincent Guittot
On 19 March 2014 16:22, Dietmar Eggemann wrote: > On 19/03/14 13:33, Vincent Guittot wrote: > [...] > Is there a way to check that MC and GMC have to have SD_SHARE_PKG_RESOURCES set so that this can't happen unnoticed? >>> >>> So from the core codes perspective those names mean less

Re: [PATCH v2 2/7] sched: rework of sched_domain topology definition

2014-03-19 Thread Dietmar Eggemann
On 19/03/14 13:33, Vincent Guittot wrote: [...] >>> Is there a way to check that MC and GMC have to have >>> SD_SHARE_PKG_RESOURCES set so that this can't happen unnoticed? >> >> So from the core codes perspective those names mean less than nothing. >> Its just a string to carry along for us

Re: [PATCH v2 2/7] sched: rework of sched_domain topology definition

2014-03-19 Thread Dietmar Eggemann
On 19/03/14 12:41, Peter Zijlstra wrote: > > The keyboard deity gave us delete, please apply graciously when replying > to large emails. Sorry about that, will do next time. > > On Wed, Mar 19, 2014 at 11:27:12AM +, Dietmar Eggemann wrote: >> On 18/03/14 17:56, Vincent Guittot wrote: >>> +

Re: [PATCH v2 2/7] sched: rework of sched_domain topology definition

2014-03-19 Thread Vincent Guittot
On 19 March 2014 13:41, Peter Zijlstra wrote: > > The keyboard deity gave us delete, please apply graciously when replying > to large emails. > > On Wed, Mar 19, 2014 at 11:27:12AM +, Dietmar Eggemann wrote: >> On 18/03/14 17:56, Vincent Guittot wrote: >> > + if (sd->flags &

Re: [PATCH v2 2/7] sched: rework of sched_domain topology definition

2014-03-19 Thread Peter Zijlstra
The keyboard deity gave us delete, please apply graciously when replying to large emails. On Wed, Mar 19, 2014 at 11:27:12AM +, Dietmar Eggemann wrote: > On 18/03/14 17:56, Vincent Guittot wrote: > > + if (sd->flags & SD_SHARE_CPUPOWER) { > > + sd->imbalance_pct = 110; >

Re: [PATCH v2 2/7] sched: rework of sched_domain topology definition

2014-03-19 Thread Dietmar Eggemann
On 18/03/14 17:56, Vincent Guittot wrote: > We replace the old way to configure the scheduler topology with a new method > which enables a platform to declare additionnal level (if needed). > > We still have a default topology table definition that can be used by platform > that don't want more

Re: [PATCH v2 2/7] sched: rework of sched_domain topology definition

2014-03-19 Thread Preeti U Murthy
On 03/18/2014 11:26 PM, Vincent Guittot wrote: > We replace the old way to configure the scheduler topology with a new method > which enables a platform to declare additionnal level (if needed). > > We still have a default topology table definition that can be used by platform > that don't want

Re: [PATCH v2 2/7] sched: rework of sched_domain topology definition

2014-03-19 Thread Preeti U Murthy
On 03/18/2014 11:26 PM, Vincent Guittot wrote: We replace the old way to configure the scheduler topology with a new method which enables a platform to declare additionnal level (if needed). We still have a default topology table definition that can be used by platform that don't want more

Re: [PATCH v2 2/7] sched: rework of sched_domain topology definition

2014-03-19 Thread Dietmar Eggemann
On 18/03/14 17:56, Vincent Guittot wrote: We replace the old way to configure the scheduler topology with a new method which enables a platform to declare additionnal level (if needed). We still have a default topology table definition that can be used by platform that don't want more level

Re: [PATCH v2 2/7] sched: rework of sched_domain topology definition

2014-03-19 Thread Peter Zijlstra
The keyboard deity gave us delete, please apply graciously when replying to large emails. On Wed, Mar 19, 2014 at 11:27:12AM +, Dietmar Eggemann wrote: On 18/03/14 17:56, Vincent Guittot wrote: + if (sd-flags SD_SHARE_CPUPOWER) { + sd-imbalance_pct = 110; +

Re: [PATCH v2 2/7] sched: rework of sched_domain topology definition

2014-03-19 Thread Vincent Guittot
On 19 March 2014 13:41, Peter Zijlstra pet...@infradead.org wrote: The keyboard deity gave us delete, please apply graciously when replying to large emails. On Wed, Mar 19, 2014 at 11:27:12AM +, Dietmar Eggemann wrote: On 18/03/14 17:56, Vincent Guittot wrote: + if (sd-flags

Re: [PATCH v2 2/7] sched: rework of sched_domain topology definition

2014-03-19 Thread Dietmar Eggemann
On 19/03/14 12:41, Peter Zijlstra wrote: The keyboard deity gave us delete, please apply graciously when replying to large emails. Sorry about that, will do next time. On Wed, Mar 19, 2014 at 11:27:12AM +, Dietmar Eggemann wrote: On 18/03/14 17:56, Vincent Guittot wrote: + if

Re: [PATCH v2 2/7] sched: rework of sched_domain topology definition

2014-03-19 Thread Dietmar Eggemann
On 19/03/14 13:33, Vincent Guittot wrote: [...] Is there a way to check that MC and GMC have to have SD_SHARE_PKG_RESOURCES set so that this can't happen unnoticed? So from the core codes perspective those names mean less than nothing. Its just a string to carry along for us meat-bags. The

Re: [PATCH v2 2/7] sched: rework of sched_domain topology definition

2014-03-19 Thread Vincent Guittot
On 19 March 2014 16:22, Dietmar Eggemann dietmar.eggem...@arm.com wrote: On 19/03/14 13:33, Vincent Guittot wrote: [...] Is there a way to check that MC and GMC have to have SD_SHARE_PKG_RESOURCES set so that this can't happen unnoticed? So from the core codes perspective those names mean

[PATCH v2 2/7] sched: rework of sched_domain topology definition

2014-03-18 Thread Vincent Guittot
We replace the old way to configure the scheduler topology with a new method which enables a platform to declare additionnal level (if needed). We still have a default topology table definition that can be used by platform that don't want more level than the SMT, MC, CPU and NUMA ones. This table

[PATCH v2 2/7] sched: rework of sched_domain topology definition

2014-03-18 Thread Vincent Guittot
We replace the old way to configure the scheduler topology with a new method which enables a platform to declare additionnal level (if needed). We still have a default topology table definition that can be used by platform that don't want more level than the SMT, MC, CPU and NUMA ones. This table