Re: [PATCH v2 2/9] x86: objtool: use asm macro for better compiler decisions
Hi Nadav, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.17 next-20180604] [cannot apply to tip/x86/core] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Nadav-Amit/x86-macrofying-inline-asm-for-better-compilation/20180605-124313 config: c6x-evmc6678_defconfig (attached as .config) compiler: c6x-elf-gcc (GCC) 8.1.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=c6x All errors (new ones prefixed by >>): include/linux/compiler.h: Assembler messages: >> include/linux/compiler.h:308: Error: Macro `annotate_unreachable' was >> already defined vim +308 include/linux/compiler.h 307 > 308 .macro ANNOTATE_UNREACHABLE counter:req 309 .endm 310 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH v2 2/9] x86: objtool: use asm macro for better compiler decisions
Hi Nadav, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.17 next-20180604] [cannot apply to tip/x86/core] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Nadav-Amit/x86-macrofying-inline-asm-for-better-compilation/20180605-124313 config: c6x-evmc6678_defconfig (attached as .config) compiler: c6x-elf-gcc (GCC) 8.1.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=c6x All errors (new ones prefixed by >>): include/linux/compiler.h: Assembler messages: >> include/linux/compiler.h:308: Error: Macro `annotate_unreachable' was >> already defined vim +308 include/linux/compiler.h 307 > 308 .macro ANNOTATE_UNREACHABLE counter:req 309 .endm 310 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH v2 2/9] x86: objtool: use asm macro for better compiler decisions
On Mon, Jun 04, 2018 at 04:21:24AM -0700, Nadav Amit wrote: > +#ifdef CONFIG_STACK_VALIDATION > +.macro ANNOTATE_UNREACHABLE counter:req > +\counter: > + .pushsection .discard.unreachable > + .long \counter\()b -. > + .popsection > +.endm > + > +.macro ANNOTATE_REACHABLE counter:req > +\counter: > + .pushsection .discard.reachable > + .long \counter\()b -. > + .popsection > +.endm > + > +.macro ASM_UNREACHABLE > +999: > + .pushsection .discard.unreachable > + .long 999b - . > + .popsection > +.endm > +#else /* CONFIG_STACK_VALIDATION */ > +.macro ANNOTATE_UNREACHABLE counter:req > +.endm > + > +.macro ANNOTATE_UNREACHABLE counter:req > +.endm > + > +.macro ASM_UNREACHABLE > +.endm /* CONFIG_STACK_VALIDATION */ > +#endif The '/* CONFIG_STACK_VALIDATION */' comment is on the wrong line. Otherwise: Reviewed-by: Josh Poimboeuf -- Josh
Re: [PATCH v2 2/9] x86: objtool: use asm macro for better compiler decisions
On Mon, Jun 04, 2018 at 04:21:24AM -0700, Nadav Amit wrote: > +#ifdef CONFIG_STACK_VALIDATION > +.macro ANNOTATE_UNREACHABLE counter:req > +\counter: > + .pushsection .discard.unreachable > + .long \counter\()b -. > + .popsection > +.endm > + > +.macro ANNOTATE_REACHABLE counter:req > +\counter: > + .pushsection .discard.reachable > + .long \counter\()b -. > + .popsection > +.endm > + > +.macro ASM_UNREACHABLE > +999: > + .pushsection .discard.unreachable > + .long 999b - . > + .popsection > +.endm > +#else /* CONFIG_STACK_VALIDATION */ > +.macro ANNOTATE_UNREACHABLE counter:req > +.endm > + > +.macro ANNOTATE_UNREACHABLE counter:req > +.endm > + > +.macro ASM_UNREACHABLE > +.endm /* CONFIG_STACK_VALIDATION */ > +#endif The '/* CONFIG_STACK_VALIDATION */' comment is on the wrong line. Otherwise: Reviewed-by: Josh Poimboeuf -- Josh
[PATCH v2 2/9] x86: objtool: use asm macro for better compiler decisions
GCC considers the number of statements in inlined assembly blocks,
according to new-lines and semicolons, as an indication to the cost of
the block in time and space. This data is distorted by the kernel code,
which puts information in alternative sections. As a result, the
compiler may perform incorrect inlining and branch optimizations.
In the case of objtool, this distortion is extreme, since anyhow the
annotations of objtool are discarded during linkage.
The solution is to set an assembly macro and call it from the inline
assembly block. As a result GCC considers the inline assembly block as
a single instruction.
This patch slightly increases the kernel size.
textdata bss dec hex filename
18140829 10224724 2957312 31322865 1ddf2f1 ./vmlinux before
18140970 10225412 2957312 31323694 1ddf62e ./vmlinux after (+829)
Static text symbols:
Before: 40321
After: 40302 (-19)
Cc: Christopher Li
Cc: linux-spa...@vger.kernel.org
Signed-off-by: Nadav Amit
---
arch/x86/kernel/macros.S | 2 ++
include/linux/compiler.h | 60 +++-
2 files changed, 49 insertions(+), 13 deletions(-)
diff --git a/arch/x86/kernel/macros.S b/arch/x86/kernel/macros.S
index cfc1c7d1a6eb..cee28c3246dc 100644
--- a/arch/x86/kernel/macros.S
+++ b/arch/x86/kernel/macros.S
@@ -5,3 +5,5 @@
* commonly used. The macros are precompiled into assmebly file which is later
* assembled together with each compiled file.
*/
+
+#include
diff --git a/include/linux/compiler.h b/include/linux/compiler.h
index ab4711c63601..d10e752036c4 100644
--- a/include/linux/compiler.h
+++ b/include/linux/compiler.h
@@ -91,6 +91,10 @@ void ftrace_likely_update(struct ftrace_likely_data *f, int
val,
# define barrier_before_unreachable() do { } while (0)
#endif
+/* A wrapper to clearly document when a macro is used */
+#define __ASM_MACRO(name, ...) __stringify(name)
__stringify(__VA_ARGS__)
+#define ASM_MACRO(name, ...) __ASM_MACRO(name, __VA_ARGS__) "\n\t"
+
/* Unreachable code */
#ifdef CONFIG_STACK_VALIDATION
/*
@@ -99,22 +103,13 @@ void ftrace_likely_update(struct ftrace_likely_data *f,
int val,
* unique, to convince GCC not to merge duplicate inline asm statements.
*/
#define annotate_reachable() ({
\
- asm volatile("%c0:\n\t" \
-".pushsection .discard.reachable\n\t" \
-".long %c0b - .\n\t" \
-".popsection\n\t" : : "i" (__COUNTER__)); \
+ asm volatile("ANNOTATE_REACHABLE counter=%c0" \
+: : "i" (__COUNTER__));\
})
#define annotate_unreachable() ({ \
- asm volatile("%c0:\n\t" \
-".pushsection .discard.unreachable\n\t"\
-".long %c0b - .\n\t" \
-".popsection\n\t" : : "i" (__COUNTER__)); \
+ asm volatile("ANNOTATE_UNREACHABLE counter=%c0" \
+: : "i" (__COUNTER__));\
})
-#define ASM_UNREACHABLE
\
- "999:\n\t" \
- ".pushsection .discard.unreachable\n\t" \
- ".long 999b - .\n\t"\
- ".popsection\n\t"
#else
#define annotate_reachable()
#define annotate_unreachable()
@@ -280,6 +275,45 @@ unsigned long read_word_at_a_time(const void *addr)
#endif /* __KERNEL__ */
+#else /* __ASSEMBLY__ */
+
+#ifdef __KERNEL__
+#ifndef LINKER_SCRIPT
+
+#ifdef CONFIG_STACK_VALIDATION
+.macro ANNOTATE_UNREACHABLE counter:req
+\counter:
+ .pushsection .discard.unreachable
+ .long \counter\()b -.
+ .popsection
+.endm
+
+.macro ANNOTATE_REACHABLE counter:req
+\counter:
+ .pushsection .discard.reachable
+ .long \counter\()b -.
+ .popsection
+.endm
+
+.macro ASM_UNREACHABLE
+999:
+ .pushsection .discard.unreachable
+ .long 999b - .
+ .popsection
+.endm
+#else /* CONFIG_STACK_VALIDATION */
+.macro ANNOTATE_UNREACHABLE counter:req
+.endm
+
+.macro ANNOTATE_UNREACHABLE counter:req
+.endm
+
+.macro ASM_UNREACHABLE
+.endm /* CONFIG_STACK_VALIDATION */
+#endif
+
+#endif /* LINKER_SCRIPT */
+#endif /* __KERNEL__ */
#endif /* __ASSEMBLY__ */
#ifndef __optimize
--
2.17.0
[PATCH v2 2/9] x86: objtool: use asm macro for better compiler decisions
GCC considers the number of statements in inlined assembly blocks,
according to new-lines and semicolons, as an indication to the cost of
the block in time and space. This data is distorted by the kernel code,
which puts information in alternative sections. As a result, the
compiler may perform incorrect inlining and branch optimizations.
In the case of objtool, this distortion is extreme, since anyhow the
annotations of objtool are discarded during linkage.
The solution is to set an assembly macro and call it from the inline
assembly block. As a result GCC considers the inline assembly block as
a single instruction.
This patch slightly increases the kernel size.
textdata bss dec hex filename
18140829 10224724 2957312 31322865 1ddf2f1 ./vmlinux before
18140970 10225412 2957312 31323694 1ddf62e ./vmlinux after (+829)
Static text symbols:
Before: 40321
After: 40302 (-19)
Cc: Christopher Li
Cc: linux-spa...@vger.kernel.org
Signed-off-by: Nadav Amit
---
arch/x86/kernel/macros.S | 2 ++
include/linux/compiler.h | 60 +++-
2 files changed, 49 insertions(+), 13 deletions(-)
diff --git a/arch/x86/kernel/macros.S b/arch/x86/kernel/macros.S
index cfc1c7d1a6eb..cee28c3246dc 100644
--- a/arch/x86/kernel/macros.S
+++ b/arch/x86/kernel/macros.S
@@ -5,3 +5,5 @@
* commonly used. The macros are precompiled into assmebly file which is later
* assembled together with each compiled file.
*/
+
+#include
diff --git a/include/linux/compiler.h b/include/linux/compiler.h
index ab4711c63601..d10e752036c4 100644
--- a/include/linux/compiler.h
+++ b/include/linux/compiler.h
@@ -91,6 +91,10 @@ void ftrace_likely_update(struct ftrace_likely_data *f, int
val,
# define barrier_before_unreachable() do { } while (0)
#endif
+/* A wrapper to clearly document when a macro is used */
+#define __ASM_MACRO(name, ...) __stringify(name)
__stringify(__VA_ARGS__)
+#define ASM_MACRO(name, ...) __ASM_MACRO(name, __VA_ARGS__) "\n\t"
+
/* Unreachable code */
#ifdef CONFIG_STACK_VALIDATION
/*
@@ -99,22 +103,13 @@ void ftrace_likely_update(struct ftrace_likely_data *f,
int val,
* unique, to convince GCC not to merge duplicate inline asm statements.
*/
#define annotate_reachable() ({
\
- asm volatile("%c0:\n\t" \
-".pushsection .discard.reachable\n\t" \
-".long %c0b - .\n\t" \
-".popsection\n\t" : : "i" (__COUNTER__)); \
+ asm volatile("ANNOTATE_REACHABLE counter=%c0" \
+: : "i" (__COUNTER__));\
})
#define annotate_unreachable() ({ \
- asm volatile("%c0:\n\t" \
-".pushsection .discard.unreachable\n\t"\
-".long %c0b - .\n\t" \
-".popsection\n\t" : : "i" (__COUNTER__)); \
+ asm volatile("ANNOTATE_UNREACHABLE counter=%c0" \
+: : "i" (__COUNTER__));\
})
-#define ASM_UNREACHABLE
\
- "999:\n\t" \
- ".pushsection .discard.unreachable\n\t" \
- ".long 999b - .\n\t"\
- ".popsection\n\t"
#else
#define annotate_reachable()
#define annotate_unreachable()
@@ -280,6 +275,45 @@ unsigned long read_word_at_a_time(const void *addr)
#endif /* __KERNEL__ */
+#else /* __ASSEMBLY__ */
+
+#ifdef __KERNEL__
+#ifndef LINKER_SCRIPT
+
+#ifdef CONFIG_STACK_VALIDATION
+.macro ANNOTATE_UNREACHABLE counter:req
+\counter:
+ .pushsection .discard.unreachable
+ .long \counter\()b -.
+ .popsection
+.endm
+
+.macro ANNOTATE_REACHABLE counter:req
+\counter:
+ .pushsection .discard.reachable
+ .long \counter\()b -.
+ .popsection
+.endm
+
+.macro ASM_UNREACHABLE
+999:
+ .pushsection .discard.unreachable
+ .long 999b - .
+ .popsection
+.endm
+#else /* CONFIG_STACK_VALIDATION */
+.macro ANNOTATE_UNREACHABLE counter:req
+.endm
+
+.macro ANNOTATE_UNREACHABLE counter:req
+.endm
+
+.macro ASM_UNREACHABLE
+.endm /* CONFIG_STACK_VALIDATION */
+#endif
+
+#endif /* LINKER_SCRIPT */
+#endif /* __KERNEL__ */
#endif /* __ASSEMBLY__ */
#ifndef __optimize
--
2.17.0
