Re: [PATCH v2 22/35] vfs: don't open real

2018-05-15 Thread Vivek Goyal
On Mon, May 14, 2018 at 09:58:03AM -0400, Vivek Goyal wrote: [..] > Talked to Dan and he mentioned that he was trying to test entrypoint > failure (and not exec failure) and that's whey he might have allowed exec > to mounter. > > I think that current entrypoint test's expectations are wrong. >

Re: [PATCH v2 22/35] vfs: don't open real

2018-05-15 Thread Vivek Goyal
On Mon, May 14, 2018 at 09:58:03AM -0400, Vivek Goyal wrote: [..] > Talked to Dan and he mentioned that he was trying to test entrypoint > failure (and not exec failure) and that's whey he might have allowed exec > to mounter. > > I think that current entrypoint test's expectations are wrong. >

Re: [PATCH v2 22/35] vfs: don't open real

2018-05-14 Thread Daniel Walsh
On 05/11/2018 03:42 PM, Vivek Goyal wrote: On Fri, May 11, 2018 at 02:54:30PM -0400, Vivek Goyal wrote: On Mon, May 07, 2018 at 10:37:54AM +0200, Miklos Szeredi wrote: Let overlayfs do its thing when opening a file. This enables stacking and fixes the corner case when a file is opened for

Re: [PATCH v2 22/35] vfs: don't open real

2018-05-14 Thread Daniel Walsh
On 05/11/2018 03:42 PM, Vivek Goyal wrote: On Fri, May 11, 2018 at 02:54:30PM -0400, Vivek Goyal wrote: On Mon, May 07, 2018 at 10:37:54AM +0200, Miklos Szeredi wrote: Let overlayfs do its thing when opening a file. This enables stacking and fixes the corner case when a file is opened for

Re: [PATCH v2 22/35] vfs: don't open real

2018-05-14 Thread Vivek Goyal
On Fri, May 11, 2018 at 03:42:48PM -0400, Vivek Goyal wrote: > On Fri, May 11, 2018 at 02:54:30PM -0400, Vivek Goyal wrote: > > On Mon, May 07, 2018 at 10:37:54AM +0200, Miklos Szeredi wrote: > > > Let overlayfs do its thing when opening a file. > > > > > > This enables stacking and fixes the

Re: [PATCH v2 22/35] vfs: don't open real

2018-05-14 Thread Vivek Goyal
On Fri, May 11, 2018 at 03:42:48PM -0400, Vivek Goyal wrote: > On Fri, May 11, 2018 at 02:54:30PM -0400, Vivek Goyal wrote: > > On Mon, May 07, 2018 at 10:37:54AM +0200, Miklos Szeredi wrote: > > > Let overlayfs do its thing when opening a file. > > > > > > This enables stacking and fixes the

Re: [PATCH v2 22/35] vfs: don't open real

2018-05-11 Thread Vivek Goyal
On Fri, May 11, 2018 at 02:54:30PM -0400, Vivek Goyal wrote: > On Mon, May 07, 2018 at 10:37:54AM +0200, Miklos Szeredi wrote: > > Let overlayfs do its thing when opening a file. > > > > This enables stacking and fixes the corner case when a file is opened for > > read, modified through a

Re: [PATCH v2 22/35] vfs: don't open real

2018-05-11 Thread Vivek Goyal
On Fri, May 11, 2018 at 02:54:30PM -0400, Vivek Goyal wrote: > On Mon, May 07, 2018 at 10:37:54AM +0200, Miklos Szeredi wrote: > > Let overlayfs do its thing when opening a file. > > > > This enables stacking and fixes the corner case when a file is opened for > > read, modified through a

Re: [PATCH v2 22/35] vfs: don't open real

2018-05-11 Thread Vivek Goyal
On Mon, May 07, 2018 at 10:37:54AM +0200, Miklos Szeredi wrote: > Let overlayfs do its thing when opening a file. > > This enables stacking and fixes the corner case when a file is opened for > read, modified through a writable open, and data is read from the read-only > file. After this patch

Re: [PATCH v2 22/35] vfs: don't open real

2018-05-11 Thread Vivek Goyal
On Mon, May 07, 2018 at 10:37:54AM +0200, Miklos Szeredi wrote: > Let overlayfs do its thing when opening a file. > > This enables stacking and fixes the corner case when a file is opened for > read, modified through a writable open, and data is read from the read-only > file. After this patch

Re: [PATCH v2 22/35] vfs: don't open real

2018-05-07 Thread Miklos Szeredi
On Mon, May 7, 2018 at 12:27 PM, Amir Goldstein wrote: > On Mon, May 7, 2018 at 11:37 AM, Miklos Szeredi wrote: >> Let overlayfs do its thing when opening a file. >> >> This enables stacking and fixes the corner case when a file is opened for >> read,

Re: [PATCH v2 22/35] vfs: don't open real

2018-05-07 Thread Miklos Szeredi
On Mon, May 7, 2018 at 12:27 PM, Amir Goldstein wrote: > On Mon, May 7, 2018 at 11:37 AM, Miklos Szeredi wrote: >> Let overlayfs do its thing when opening a file. >> >> This enables stacking and fixes the corner case when a file is opened for >> read, modified through a writable open, and data

Re: [PATCH v2 22/35] vfs: don't open real

2018-05-07 Thread Amir Goldstein
On Mon, May 7, 2018 at 11:37 AM, Miklos Szeredi wrote: > Let overlayfs do its thing when opening a file. > > This enables stacking and fixes the corner case when a file is opened for > read, modified through a writable open, and data is read from the read-only > file. After

Re: [PATCH v2 22/35] vfs: don't open real

2018-05-07 Thread Amir Goldstein
On Mon, May 7, 2018 at 11:37 AM, Miklos Szeredi wrote: > Let overlayfs do its thing when opening a file. > > This enables stacking and fixes the corner case when a file is opened for > read, modified through a writable open, and data is read from the read-only > file. After this patch the

[PATCH v2 22/35] vfs: don't open real

2018-05-07 Thread Miklos Szeredi
Let overlayfs do its thing when opening a file. This enables stacking and fixes the corner case when a file is opened for read, modified through a writable open, and data is read from the read-only file. After this patch the read-only open will not return stale data even in this case.

[PATCH v2 22/35] vfs: don't open real

2018-05-07 Thread Miklos Szeredi
Let overlayfs do its thing when opening a file. This enables stacking and fixes the corner case when a file is opened for read, modified through a writable open, and data is read from the read-only file. After this patch the read-only open will not return stale data even in this case.