Re: [PATCH v2 3/3] PCI: imx: Initial imx7d pm support

2018-07-24 Thread Lucas Stach
Am Dienstag, den 24.07.2018, 12:04 + schrieb Leonard Crestez: > On Tue, 2018-07-24 at 12:09 +0200, Lucas Stach wrote: > > Am Montag, den 23.07.2018, 12:37 + schrieb Leonard Crestez: > > > On Mon, 2018-07-23 at 11:38 +0200, Lucas Stach wrote: > > > > Am Freitag, den 20.07.2018, 15:47 +0300

Re: [PATCH v2 3/3] PCI: imx: Initial imx7d pm support

2018-07-24 Thread Lucas Stach
Am Dienstag, den 24.07.2018, 12:04 + schrieb Leonard Crestez: > On Tue, 2018-07-24 at 12:09 +0200, Lucas Stach wrote: > > Am Montag, den 23.07.2018, 12:37 + schrieb Leonard Crestez: > > > On Mon, 2018-07-23 at 11:38 +0200, Lucas Stach wrote: > > > > Am Freitag, den 20.07.2018, 15:47 +0300

Re: [PATCH v2 3/3] PCI: imx: Initial imx7d pm support

2018-07-24 Thread Leonard Crestez
On Tue, 2018-07-24 at 12:09 +0200, Lucas Stach wrote: > Am Montag, den 23.07.2018, 12:37 + schrieb Leonard Crestez: > > On Mon, 2018-07-23 at 11:38 +0200, Lucas Stach wrote: > > > Am Freitag, den 20.07.2018, 15:47 +0300 schrieb Leonard Crestez: > > > > On imx7d the pcie-phy power domain is

Re: [PATCH v2 3/3] PCI: imx: Initial imx7d pm support

2018-07-24 Thread Leonard Crestez
On Tue, 2018-07-24 at 12:09 +0200, Lucas Stach wrote: > Am Montag, den 23.07.2018, 12:37 + schrieb Leonard Crestez: > > On Mon, 2018-07-23 at 11:38 +0200, Lucas Stach wrote: > > > Am Freitag, den 20.07.2018, 15:47 +0300 schrieb Leonard Crestez: > > > > On imx7d the pcie-phy power domain is

Re: [PATCH v2 3/3] PCI: imx: Initial imx7d pm support

2018-07-24 Thread Lucas Stach
Am Montag, den 23.07.2018, 12:37 + schrieb Leonard Crestez: > On Mon, 2018-07-23 at 11:38 +0200, Lucas Stach wrote: > > Hi Leonard, > > > > Am Freitag, den 20.07.2018, 15:47 +0300 schrieb Leonard Crestez: > > > On imx7d the pcie-phy power domain is turned off in suspend and this can > > >

Re: [PATCH v2 3/3] PCI: imx: Initial imx7d pm support

2018-07-24 Thread Lucas Stach
Am Montag, den 23.07.2018, 12:37 + schrieb Leonard Crestez: > On Mon, 2018-07-23 at 11:38 +0200, Lucas Stach wrote: > > Hi Leonard, > > > > Am Freitag, den 20.07.2018, 15:47 +0300 schrieb Leonard Crestez: > > > On imx7d the pcie-phy power domain is turned off in suspend and this can > > >

Re: [PATCH v2 3/3] PCI: imx: Initial imx7d pm support

2018-07-23 Thread Leonard Crestez
On Mon, 2018-07-23 at 11:38 +0200, Lucas Stach wrote: > Hi Leonard, > > Am Freitag, den 20.07.2018, 15:47 +0300 schrieb Leonard Crestez: > > On imx7d the pcie-phy power domain is turned off in suspend and this can > > make the system hang after resume when attempting any read from PCI. > > > >

Re: [PATCH v2 3/3] PCI: imx: Initial imx7d pm support

2018-07-23 Thread Leonard Crestez
On Mon, 2018-07-23 at 11:38 +0200, Lucas Stach wrote: > Hi Leonard, > > Am Freitag, den 20.07.2018, 15:47 +0300 schrieb Leonard Crestez: > > On imx7d the pcie-phy power domain is turned off in suspend and this can > > make the system hang after resume when attempting any read from PCI. > > > >

Re: [PATCH v2 3/3] PCI: imx: Initial imx7d pm support

2018-07-23 Thread Lucas Stach
Hi Leonard, Am Freitag, den 20.07.2018, 15:47 +0300 schrieb Leonard Crestez: > On imx7d the pcie-phy power domain is turned off in suspend and this can > make the system hang after resume when attempting any read from PCI. > > Fix this by adding minimal suspend/resume code from the nxp internal

Re: [PATCH v2 3/3] PCI: imx: Initial imx7d pm support

2018-07-23 Thread Lucas Stach
Hi Leonard, Am Freitag, den 20.07.2018, 15:47 +0300 schrieb Leonard Crestez: > On imx7d the pcie-phy power domain is turned off in suspend and this can > make the system hang after resume when attempting any read from PCI. > > Fix this by adding minimal suspend/resume code from the nxp internal

Re: [PATCH v2 3/3] PCI: imx: Initial imx7d pm support

2018-07-20 Thread Fabio Estevam
Hi Leonard, On Fri, Jul 20, 2018 at 9:47 AM, Leonard Crestez wrote: > +static int imx6_pcie_resume_noirq(struct device *dev) > +{ > + int ret = 0; There is no need for initializing 'ret' here. > + struct imx6_pcie *imx6_pcie = dev_get_drvdata(dev); > + struct pcie_port *pp =

Re: [PATCH v2 3/3] PCI: imx: Initial imx7d pm support

2018-07-20 Thread Fabio Estevam
Hi Leonard, On Fri, Jul 20, 2018 at 9:47 AM, Leonard Crestez wrote: > +static int imx6_pcie_resume_noirq(struct device *dev) > +{ > + int ret = 0; There is no need for initializing 'ret' here. > + struct imx6_pcie *imx6_pcie = dev_get_drvdata(dev); > + struct pcie_port *pp =

[PATCH v2 3/3] PCI: imx: Initial imx7d pm support

2018-07-20 Thread Leonard Crestez
On imx7d the pcie-phy power domain is turned off in suspend and this can make the system hang after resume when attempting any read from PCI. Fix this by adding minimal suspend/resume code from the nxp internal tree. This will prepare for powering down on suspend and reset the block on resume.

[PATCH v2 3/3] PCI: imx: Initial imx7d pm support

2018-07-20 Thread Leonard Crestez
On imx7d the pcie-phy power domain is turned off in suspend and this can make the system hang after resume when attempting any read from PCI. Fix this by adding minimal suspend/resume code from the nxp internal tree. This will prepare for powering down on suspend and reset the block on resume.