Re: [PATCH v2 3/3] hpsa: add an assert to prevent from __packed reintroduction

2021-04-03 Thread Sergei Trofimovich
On Fri, 2 Apr 2021 14:40:39 + "Elliott, Robert (Servers)" wrote: > It looks like ia64 implements atomic_t as a 64-bit value and expects atomic_t > to be 64-bit aligned, but does nothing to ensure that. > > For x86, atomic_t is a 32-bit value and atomic64_t is a 64-bit value, and > the

RE: [PATCH v2 3/3] hpsa: add an assert to prevent from __packed reintroduction

2021-04-02 Thread Elliott, Robert (Servers)
It looks like ia64 implements atomic_t as a 64-bit value and expects atomic_t to be 64-bit aligned, but does nothing to ensure that. For x86, atomic_t is a 32-bit value and atomic64_t is a 64-bit value, and the definition of atomic64_t is overridden in a way that ensures 64-bit (8 byte)

Re: [PATCH v2 3/3] hpsa: add an assert to prevent from __packed reintroduction

2021-03-30 Thread Arnd Bergmann
On Tue, Mar 30, 2021 at 9:23 AM Sergei Trofimovich wrote: > +/* > + * Make sure our embedded atomic variable is aligned. Otherwise we break > atomic > + * operations on architectures that don't support unaligned atomics like > IA64. > + * > + * The assert guards against reintroductin against

[PATCH v2 3/3] hpsa: add an assert to prevent from __packed reintroduction

2021-03-30 Thread Sergei Trofimovich
CC: linux-i...@vger.kernel.org CC: storage...@microchip.com CC: linux-s...@vger.kernel.org CC: Joe Szczypek CC: Scott Benesh CC: Scott Teel CC: Tomas Henzl CC: "Martin K. Petersen" CC: Don Brace Reported-by: John Paul Adrian Glaubitz Suggested-by: Don Brace Fixes: f749d8b7a "scsi: hpsa: