Re: [PATCH v2 3/3] tty: Replace goldfish_tty_line_count with a #define

2018-08-02 Thread Alan Cox
On Tue, 24 Jul 2018 17:51:33 -0700 r...@google.com wrote: > From: Roman Kiryanov > > The driver never mutates this variable - no benefits of > keeping it mutable. > > Signed-off-by: Roman Kiryanov > --- > Changes in v2: > - Replaced "const u32" with "#define". v1 was IMHO definitely better.

Re: [PATCH v2 3/3] tty: Replace goldfish_tty_line_count with a #define

2018-08-02 Thread Alan Cox
On Tue, 24 Jul 2018 17:51:33 -0700 r...@google.com wrote: > From: Roman Kiryanov > > The driver never mutates this variable - no benefits of > keeping it mutable. > > Signed-off-by: Roman Kiryanov > --- > Changes in v2: > - Replaced "const u32" with "#define". v1 was IMHO definitely better.

Re: [PATCH v2 3/3] tty: Replace goldfish_tty_line_count with a #define

2018-08-02 Thread Greg KH
On Tue, Jul 24, 2018 at 05:51:33PM -0700, r...@google.com wrote: > From: Roman Kiryanov > > The driver never mutates this variable - no benefits of > keeping it mutable. > > Signed-off-by: Roman Kiryanov > --- > Changes in v2: > - Replaced "const u32" with "#define". > >

Re: [PATCH v2 3/3] tty: Replace goldfish_tty_line_count with a #define

2018-08-02 Thread Greg KH
On Tue, Jul 24, 2018 at 05:51:33PM -0700, r...@google.com wrote: > From: Roman Kiryanov > > The driver never mutates this variable - no benefits of > keeping it mutable. > > Signed-off-by: Roman Kiryanov > --- > Changes in v2: > - Replaced "const u32" with "#define". > >

[PATCH v2 3/3] tty: Replace goldfish_tty_line_count with a #define

2018-07-24 Thread rkir
From: Roman Kiryanov The driver never mutates this variable - no benefits of keeping it mutable. Signed-off-by: Roman Kiryanov --- Changes in v2: - Replaced "const u32" with "#define". drivers/tty/goldfish.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git

[PATCH v2 3/3] tty: Replace goldfish_tty_line_count with a #define

2018-07-24 Thread rkir
From: Roman Kiryanov The driver never mutates this variable - no benefits of keeping it mutable. Signed-off-by: Roman Kiryanov --- Changes in v2: - Replaced "const u32" with "#define". drivers/tty/goldfish.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git