Re: [PATCH v2 3/3] x86/quirks: Add early quirk to reset Apple AirPort card

2016-06-28 Thread Lukas Wunner
Hi Ingo, On Sun, Jun 12, 2016 at 01:13:38PM +0200, Lukas Wunner wrote: > I've just posted v2, taking into account all of Bjorn's suggestions: > https://lkml.org/lkml/2016/6/12/65 > > @Ingo Molnar: I noticed that you've removed the line breaks in > read/write_pci_config_16(). I've carried that chan

Re: [PATCH v2 3/3] x86/quirks: Add early quirk to reset Apple AirPort card

2016-06-14 Thread Ingo Molnar
* Matt Fleming wrote: > On Sun, 12 Jun, at 02:37:26PM, Lukas Wunner wrote: > > > > Resetting the card solves the problem at the root and fixes both, > > the spurious interrupts and the memory corruption. > > It also avoids the need to figure out exactly which Boot Services > regions may have

Re: [PATCH v2 3/3] x86/quirks: Add early quirk to reset Apple AirPort card

2016-06-13 Thread Matt Fleming
On Sun, 12 Jun, at 02:37:26PM, Lukas Wunner wrote: > > Resetting the card solves the problem at the root and fixes both, > the spurious interrupts and the memory corruption. It also avoids the need to figure out exactly which Boot Services regions may have become corrupt. This would be necessar

Re: [PATCH v2 3/3] x86/quirks: Add early quirk to reset Apple AirPort card

2016-06-12 Thread Lukas Wunner
On Sun, Jun 12, 2016 at 01:49:02PM +0200, Ingo Molnar wrote: > * Lukas Wunner wrote: > > The solution is to reset the card on boot by writing to a reset bit in > > its mmio space. This must be done as an early quirk and not as a plain > > vanilla PCI quirk to successfully combat memory corruption

Re: [PATCH v2 3/3] x86/quirks: Add early quirk to reset Apple AirPort card

2016-06-12 Thread Ingo Molnar
* Lukas Wunner wrote: > The solution is to reset the card on boot by writing to a reset bit in > its mmio space. This must be done as an early quirk and not as a plain > vanilla PCI quirk to successfully combat memory corruption by DMAed > packets: Matthew Garrett found out in 2012 that the pack

[PATCH v2 3/3] x86/quirks: Add early quirk to reset Apple AirPort card

2016-06-12 Thread Lukas Wunner
The EFI firmware on Macs contains a full-fledged network stack for downloading OS X images from osrecovery.apple.com. Unfortunately on Macs introduced 2011 and 2012, EFI brings up the Broadcom 4331 wireless card on every boot and leaves it enabled even after ExitBootServices has been called. The ca