Re: [PATCH v2 3/4] KVM: x86: kvm_hv_flush_tlb use inputs from XMM registers

2021-04-13 Thread Siddharth Chandrasekaran
On Tue, Apr 13, 2021 at 04:09:48PM +0200, Vitaly Kuznetsov wrote: > Siddharth Chandrasekaran writes: > > Hyper-V supports the use of XMM registers to perform fast hypercalls. > > This allows guests to take advantage of the improved performance of the > > fast hypercall interface even though a

Re: [PATCH v2 3/4] KVM: x86: kvm_hv_flush_tlb use inputs from XMM registers

2021-04-13 Thread Vitaly Kuznetsov
Siddharth Chandrasekaran writes: > Hyper-V supports the use of XMM registers to perform fast hypercalls. > This allows guests to take advantage of the improved performance of the > fast hypercall interface even though a hypercall may require more than > (the current maximum of) two input

Re: [PATCH v2 3/4] KVM: x86: kvm_hv_flush_tlb use inputs from XMM registers

2021-04-13 Thread Siddharth Chandrasekaran
On Mon, Apr 12, 2021 at 08:13:19PM +, Wei Liu wrote: > On Mon, Apr 12, 2021 at 07:00:16PM +0200, Siddharth Chandrasekaran wrote: > > + > > +static inline void kvm_hv_hypercall_read_xmm(struct kvm_hv_hcall *hc) > > Do you really need inline here? The compiler should be smart enough to > inline

Re: [PATCH v2 3/4] KVM: x86: kvm_hv_flush_tlb use inputs from XMM registers

2021-04-12 Thread Wei Liu
On Mon, Apr 12, 2021 at 07:00:16PM +0200, Siddharth Chandrasekaran wrote: > + > +static inline void kvm_hv_hypercall_read_xmm(struct kvm_hv_hcall *hc) Do you really need inline here? The compiler should be smart enough to inline this function if necessary. > +{ > + int reg; > + > +

[PATCH v2 3/4] KVM: x86: kvm_hv_flush_tlb use inputs from XMM registers

2021-04-12 Thread Siddharth Chandrasekaran
Hyper-V supports the use of XMM registers to perform fast hypercalls. This allows guests to take advantage of the improved performance of the fast hypercall interface even though a hypercall may require more than (the current maximum of) two input registers. The XMM fast hypercall interface uses