Hi Linus,
On Mon, Oct 21, 2019 at 02:57:31AM +0200, Linus Walleij wrote:
> On Sat, Oct 19, 2019 at 6:05 PM Manivannan Sadhasivam
> wrote:
> > On Wed, Oct 16, 2019 at 02:41:32PM +0200, Linus Walleij wrote:
>
> > > select GPIO_GENERIC
> >
> > hmm.. I don't think this driver can use it. Please see
On Sat, Oct 19, 2019 at 6:05 PM Manivannan Sadhasivam
wrote:
> On Wed, Oct 16, 2019 at 02:41:32PM +0200, Linus Walleij wrote:
> > select GPIO_GENERIC
>
> hmm.. I don't think this driver can use it. Please see the justification
> below.
(...)
> As you can see in this driver, there are 2 separate
Hi Linus,
Thanks for the review! Please see comments inline.
On Wed, Oct 16, 2019 at 02:41:32PM +0200, Linus Walleij wrote:
> Hi Manivannan!
>
> Thanks for your patch!
>
> On Tue, Oct 15, 2019 at 7:30 PM Manivannan Sadhasivam
> wrote:
>
> > Add support for GPIO controller from RDA Micro.
> >
Hi Manivannan!
Thanks for your patch!
On Tue, Oct 15, 2019 at 7:30 PM Manivannan Sadhasivam
wrote:
> Add support for GPIO controller from RDA Micro.
>
> Signed-off-by: Manivannan Sadhasivam
Please use a little bit more verbose commit message, who
made this hardware and what is it for. If you
On Tue, Oct 15, 2019 at 11:00:25PM +0530, Manivannan Sadhasivam wrote:
> Add support for GPIO controller from RDA Micro.
>
> Signed-off-by: Manivannan Sadhasivam
> ---
> drivers/gpio/Kconfig| 8 +
> drivers/gpio/Makefile | 1 +
> drivers/gpio/gpio-rda.c | 315
Add support for GPIO controller from RDA Micro.
Signed-off-by: Manivannan Sadhasivam
---
drivers/gpio/Kconfig| 8 +
drivers/gpio/Makefile | 1 +
drivers/gpio/gpio-rda.c | 315
3 files changed, 324 insertions(+)
create mode 100644
6 matches
Mail list logo
