Re: [PATCH v2 3/4] perf/x86/intel/pt: Add Intel PT logger

Takao Indoh writes: > On 2015/09/08 18:48, Alexander Shishkin wrote: >> Takao Indoh writes: >> >>> +/* intel_pt */ >>> +static struct perf_event_attr pt_attr_pt = { >>> + .config = 0x400, /* bit10: TSCEn */ >> >> Doesn't it make sense to make these things configurable via sysfs or

Re: [PATCH v2 3/4] perf/x86/intel/pt: Add Intel PT logger

Takao Indoh writes: > On 2015/09/08 18:48, Alexander Shishkin wrote: >> Takao Indoh writes: >> >>> +/* intel_pt */ >>> +static struct perf_event_attr pt_attr_pt = { >>> + .config = 0x400, /* bit10: TSCEn */ >> >> Doesn't it

Re: [PATCH v2 3/4] perf/x86/intel/pt: Add Intel PT logger

On 2015/09/08 18:48, Alexander Shishkin wrote: > Takao Indoh writes: > >> +/* intel_pt */ >> +static struct perf_event_attr pt_attr_pt = { >> +.config = 0x400, /* bit10: TSCEn */ > > Doesn't it make sense to make these things configurable via sysfs or > whatnot? That make sense,

Re: [PATCH v2 3/4] perf/x86/intel/pt: Add Intel PT logger

Takao Indoh writes: > +/* intel_pt */ > +static struct perf_event_attr pt_attr_pt = { > + .config = 0x400, /* bit10: TSCEn */ Doesn't it make sense to make these things configurable via sysfs or whatnot? > +static int pt_log_buf_nr_pages = 128; /* number of pages for log buffer */

Re: [PATCH v2 3/4] perf/x86/intel/pt: Add Intel PT logger

Takao Indoh writes: > +/* intel_pt */ > +static struct perf_event_attr pt_attr_pt = { > + .config = 0x400, /* bit10: TSCEn */ Doesn't it make sense to make these things configurable via sysfs or whatnot? > +static int pt_log_buf_nr_pages = 128; /* number

Re: [PATCH v2 3/4] perf/x86/intel/pt: Add Intel PT logger

On 2015/09/08 18:48, Alexander Shishkin wrote: > Takao Indoh writes: > >> +/* intel_pt */ >> +static struct perf_event_attr pt_attr_pt = { >> +.config = 0x400, /* bit10: TSCEn */ > > Doesn't it make sense to make these things configurable via sysfs or >

[PATCH v2 3/4] perf/x86/intel/pt: Add Intel PT logger

This patch provides Intel PT logging feature. When system boots with a parameter "intel_pt_log", log buffers for Intel PT are allocated and logging starts, then processor flow information is written in the log buffer by hardware like flight recorder. This is very helpful to investigate a cause of

[PATCH v2 3/4] perf/x86/intel/pt: Add Intel PT logger

This patch provides Intel PT logging feature. When system boots with a parameter "intel_pt_log", log buffers for Intel PT are allocated and logging starts, then processor flow information is written in the log buffer by hardware like flight recorder. This is very helpful to investigate a cause of