Re: [PATCH v2 3/5] Creates macro to avoid variable shadowing

2018-10-29 Thread Leonardo Bras
Thank you! On Sun, Oct 28, 2018 at 1:38 PM Masahiro Yamada wrote: > > On Tue, Oct 23, 2018 at 10:11 AM Leonardo Brás wrote: > > > > Creates DEF_FIELD_ADDR_VAR as a more generic version of the DEF_FIELD_ADD > > macro, allowing usage of a variable name other than the struct element name. > > Also,

Re: [PATCH v2 3/5] Creates macro to avoid variable shadowing

2018-10-29 Thread Leonardo Bras
Thank you! On Sun, Oct 28, 2018 at 1:38 PM Masahiro Yamada wrote: > > On Tue, Oct 23, 2018 at 10:11 AM Leonardo Brás wrote: > > > > Creates DEF_FIELD_ADDR_VAR as a more generic version of the DEF_FIELD_ADD > > macro, allowing usage of a variable name other than the struct element name. > > Also,

Re: [PATCH v2 3/5] Creates macro to avoid variable shadowing

2018-10-28 Thread Masahiro Yamada
On Tue, Oct 23, 2018 at 10:11 AM Leonardo Brás wrote: > > Creates DEF_FIELD_ADDR_VAR as a more generic version of the DEF_FIELD_ADD > macro, allowing usage of a variable name other than the struct element name. > Also, sets DEF_FIELD_ADDR as a specific usage of DEF_FILD_ADDR_VAR in which > the

Re: [PATCH v2 3/5] Creates macro to avoid variable shadowing

2018-10-28 Thread Masahiro Yamada
On Tue, Oct 23, 2018 at 10:11 AM Leonardo Brás wrote: > > Creates DEF_FIELD_ADDR_VAR as a more generic version of the DEF_FIELD_ADD > macro, allowing usage of a variable name other than the struct element name. > Also, sets DEF_FIELD_ADDR as a specific usage of DEF_FILD_ADDR_VAR in which > the

Re: [PATCH v2 3/5] Creates macro to avoid variable shadowing

2018-10-23 Thread Leonardo Bras
Hello Helen, On Tue, Oct 23, 2018 at 6:35 PM Helen Koike wrote: > Like this you are not changing the logic in this file, you are just > renaming the variable which is more then enough to solve the -Wshadow > warning. > I don't it is worthy changing the logic. You are right, that was what the

Re: [PATCH v2 3/5] Creates macro to avoid variable shadowing

2018-10-23 Thread Leonardo Bras
Hello Helen, On Tue, Oct 23, 2018 at 6:35 PM Helen Koike wrote: > Like this you are not changing the logic in this file, you are just > renaming the variable which is more then enough to solve the -Wshadow > warning. > I don't it is worthy changing the logic. You are right, that was what the

Re: [PATCH v2 3/5] Creates macro to avoid variable shadowing

2018-10-23 Thread Helen Koike
Hi Leonardo, On 10/22/18 11:10 PM, Leonardo Brás wrote: > Creates DEF_FIELD_ADDR_VAR as a more generic version of the DEF_FIELD_ADD > macro, allowing usage of a variable name other than the struct element name. > Also, sets DEF_FIELD_ADDR as a specific usage of DEF_FILD_ADDR_VAR in which > the

Re: [PATCH v2 3/5] Creates macro to avoid variable shadowing

2018-10-23 Thread Helen Koike
Hi Leonardo, On 10/22/18 11:10 PM, Leonardo Brás wrote: > Creates DEF_FIELD_ADDR_VAR as a more generic version of the DEF_FIELD_ADD > macro, allowing usage of a variable name other than the struct element name. > Also, sets DEF_FIELD_ADDR as a specific usage of DEF_FILD_ADDR_VAR in which > the

Re: [PATCH v2 3/5] Creates macro to avoid variable shadowing

2018-10-23 Thread Helen Koike
Hi Leonardo, Thanks for your patch. On 10/22/18 11:10 PM, Leonardo Brás wrote: > Creates DEF_FIELD_ADDR_VAR as a more generic version of the DEF_FIELD_ADD > macro, allowing usage of a variable name other than the struct element name. > Also, sets DEF_FIELD_ADDR as a specific usage of

Re: [PATCH v2 3/5] Creates macro to avoid variable shadowing

2018-10-23 Thread Helen Koike
Hi Leonardo, Thanks for your patch. On 10/22/18 11:10 PM, Leonardo Brás wrote: > Creates DEF_FIELD_ADDR_VAR as a more generic version of the DEF_FIELD_ADD > macro, allowing usage of a variable name other than the struct element name. > Also, sets DEF_FIELD_ADDR as a specific usage of

[PATCH v2 3/5] Creates macro to avoid variable shadowing

2018-10-22 Thread Leonardo Brás
Creates DEF_FIELD_ADDR_VAR as a more generic version of the DEF_FIELD_ADD macro, allowing usage of a variable name other than the struct element name. Also, sets DEF_FIELD_ADDR as a specific usage of DEF_FILD_ADDR_VAR in which the var name is the same as the struct element name. Signed-off-by:

[PATCH v2 3/5] Creates macro to avoid variable shadowing

2018-10-22 Thread Leonardo Brás
Creates DEF_FIELD_ADDR_VAR as a more generic version of the DEF_FIELD_ADD macro, allowing usage of a variable name other than the struct element name. Also, sets DEF_FIELD_ADDR as a specific usage of DEF_FILD_ADDR_VAR in which the var name is the same as the struct element name. Signed-off-by: