Re: [PATCH v2 3/6] clk: rockchip: Export rockchip_register_softrst()

[Kever Yang]

On 2020/9/3 下午2:31, Elaine Zhang wrote:

This is used by the Rockchip clk driver, export it to allow that
driver to be compiled as a module..

Signed-off-by: Elaine Zhang 
---
  drivers/clk/rockchip/softrst.c | 7 ---
  1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/clk/rockchip/softrst.c b/drivers/clk/rockchip/softrst.c
index 5f1ff5e47c4f..caba9055090b 100644
--- a/drivers/clk/rockchip/softrst.c
+++ b/drivers/clk/rockchip/softrst.c
@@ -77,9 +77,9 @@ static const struct reset_control_ops rockchip_softrst_ops = {
.deassert   = rockchip_softrst_deassert,
  };
  
-void __init rockchip_register_softrst(struct device_node *np,

- unsigned int num_regs,
- void __iomem *base, u8 flags)
+void rockchip_register_softrst(struct device_node *np,
+  unsigned int num_regs,
+  void __iomem *base, u8 flags)
  {
struct rockchip_softrst *softrst;
int ret;
@@ -107,3 +107,4 @@ void __init rockchip_register_softrst(struct device_node 
*np,
kfree(softrst);
}
  };
+EXPORT_SYMBOL(rockchip_register_softrst);


This looks good to me, so

Reviewed-by: Kever Yang 

Thanks,

- Kever

[PATCH v2 3/6] clk: rockchip: Export rockchip_register_softrst()

[Elaine Zhang]

This is used by the Rockchip clk driver, export it to allow that
driver to be compiled as a module..

Signed-off-by: Elaine Zhang 
---
 drivers/clk/rockchip/softrst.c | 7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/clk/rockchip/softrst.c b/drivers/clk/rockchip/softrst.c
index 5f1ff5e47c4f..caba9055090b 100644
--- a/drivers/clk/rockchip/softrst.c
+++ b/drivers/clk/rockchip/softrst.c
@@ -77,9 +77,9 @@ static const struct reset_control_ops rockchip_softrst_ops = {
.deassert   = rockchip_softrst_deassert,
 };
 
-void __init rockchip_register_softrst(struct device_node *np,
- unsigned int num_regs,
- void __iomem *base, u8 flags)
+void rockchip_register_softrst(struct device_node *np,
+  unsigned int num_regs,
+  void __iomem *base, u8 flags)
 {
struct rockchip_softrst *softrst;
int ret;
@@ -107,3 +107,4 @@ void __init rockchip_register_softrst(struct device_node 
*np,
kfree(softrst);
}
 };
+EXPORT_SYMBOL(rockchip_register_softrst);
-- 
2.17.1