Re: [PATCH v2 3/7] staging: rtl8188eu: remove unused rtw_handle_tkip_mic_err()

2018-07-30 Thread Greg KH
On Mon, Jul 30, 2018 at 12:09:14PM +0200, Michael Straube wrote: > On 07/30/18 11:27, Michael Straube wrote: > > On 07/30/18 11:02, Greg KH wrote: > > > On Sun, Jul 29, 2018 at 08:54:43PM +0200, Michael Straube wrote: > > > > The function rtw_handle_tkip_mic_err() is never used, so remove it. > >

Re: [PATCH v2 3/7] staging: rtl8188eu: remove unused rtw_handle_tkip_mic_err()

2018-07-30 Thread Greg KH
On Mon, Jul 30, 2018 at 12:09:14PM +0200, Michael Straube wrote: > On 07/30/18 11:27, Michael Straube wrote: > > On 07/30/18 11:02, Greg KH wrote: > > > On Sun, Jul 29, 2018 at 08:54:43PM +0200, Michael Straube wrote: > > > > The function rtw_handle_tkip_mic_err() is never used, so remove it. > >

Re: [PATCH v2 3/7] staging: rtl8188eu: remove unused rtw_handle_tkip_mic_err()

2018-07-30 Thread Michael Straube
On 07/30/18 11:27, Michael Straube wrote: On 07/30/18 11:02, Greg KH wrote: On Sun, Jul 29, 2018 at 08:54:43PM +0200, Michael Straube wrote: The function rtw_handle_tkip_mic_err() is never used, so remove it. Discovered by cppcheck. That's a bad tool then, as this is used, and the build

Re: [PATCH v2 3/7] staging: rtl8188eu: remove unused rtw_handle_tkip_mic_err()

2018-07-30 Thread Michael Straube
On 07/30/18 11:27, Michael Straube wrote: On 07/30/18 11:02, Greg KH wrote: On Sun, Jul 29, 2018 at 08:54:43PM +0200, Michael Straube wrote: The function rtw_handle_tkip_mic_err() is never used, so remove it. Discovered by cppcheck. That's a bad tool then, as this is used, and the build

Re: [PATCH v2 3/7] staging: rtl8188eu: remove unused rtw_handle_tkip_mic_err()

2018-07-30 Thread Michael Straube
On 07/30/18 11:02, Greg KH wrote: On Sun, Jul 29, 2018 at 08:54:43PM +0200, Michael Straube wrote: The function rtw_handle_tkip_mic_err() is never used, so remove it. Discovered by cppcheck. That's a bad tool then, as this is used, and the build breaks when this patch is applied :( I've

Re: [PATCH v2 3/7] staging: rtl8188eu: remove unused rtw_handle_tkip_mic_err()

2018-07-30 Thread Michael Straube
On 07/30/18 11:02, Greg KH wrote: On Sun, Jul 29, 2018 at 08:54:43PM +0200, Michael Straube wrote: The function rtw_handle_tkip_mic_err() is never used, so remove it. Discovered by cppcheck. That's a bad tool then, as this is used, and the build breaks when this patch is applied :( I've

Re: [PATCH v2 3/7] staging: rtl8188eu: remove unused rtw_handle_tkip_mic_err()

2018-07-30 Thread Greg KH
On Sun, Jul 29, 2018 at 08:54:43PM +0200, Michael Straube wrote: > The function rtw_handle_tkip_mic_err() is never used, so remove it. > Discovered by cppcheck. That's a bad tool then, as this is used, and the build breaks when this patch is applied :( I've dropped it now. thanks, greg k-h

Re: [PATCH v2 3/7] staging: rtl8188eu: remove unused rtw_handle_tkip_mic_err()

2018-07-30 Thread Greg KH
On Sun, Jul 29, 2018 at 08:54:43PM +0200, Michael Straube wrote: > The function rtw_handle_tkip_mic_err() is never used, so remove it. > Discovered by cppcheck. That's a bad tool then, as this is used, and the build breaks when this patch is applied :( I've dropped it now. thanks, greg k-h

[PATCH v2 3/7] staging: rtl8188eu: remove unused rtw_handle_tkip_mic_err()

2018-07-29 Thread Michael Straube
The function rtw_handle_tkip_mic_err() is never used, so remove it. Discovered by cppcheck. Signed-off-by: Michael Straube --- .../staging/rtl8188eu/include/recv_osdep.h| 2 -- drivers/staging/rtl8188eu/os_dep/recv_linux.c | 36 --- 2 files changed, 38 deletions(-) diff

[PATCH v2 3/7] staging: rtl8188eu: remove unused rtw_handle_tkip_mic_err()

2018-07-29 Thread Michael Straube
The function rtw_handle_tkip_mic_err() is never used, so remove it. Discovered by cppcheck. Signed-off-by: Michael Straube --- .../staging/rtl8188eu/include/recv_osdep.h| 2 -- drivers/staging/rtl8188eu/os_dep/recv_linux.c | 36 --- 2 files changed, 38 deletions(-) diff